You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/12/06 00:42:19 UTC
[kudu-CR] [i-tests] separated implementation of the ext mini-cluster
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5367
Change subject: [i-tests] separated implementation of the ext mini-cluster
......................................................................
[i-tests] separated implementation of the ext mini-cluster
Separated implementation of the external mini-cluster methods into a
separate .cc file: those methods contain too many code to be candidates
for inlining. Besides, this helps to have less header-wise dependencies
and avoid clang-tidy warnings like
warning: function 'StopCluster' defined in a header file; function
definitions in header files can lead to ODR violations
[misc-definitions-in-headers]
This patch does not contain any functional changes.
Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-test.cc
A src/kudu/integration-tests/external_mini_cluster-itest-base.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/tablet_replacement-itest.cc
7 files changed, 111 insertions(+), 54 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/5367/1
--
To view, visit http://gerrit.cloudera.org:8080/5367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [ExternalMiniClusterITestBase] move some methods into .cc
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [ExternalMiniClusterITestBase] move some methods into .cc
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5367/2//COMMIT_MSG
Commit Message:
Line 14: warning: function 'StopCluster' defined in a header file; function
> Yep: check https://gerrit.cloudera.org/#/c/5345/5/src/kudu/integration-test
Hmm, interesting
--
To view, visit http://gerrit.cloudera.org:8080/5367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [i-tests] separated implementation of the ext mini-cluster
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [i-tests] separated implementation of the ext mini-cluster
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5367/2//COMMIT_MSG
Commit Message:
Line 7: [i-tests] separated implementation of the ext mini-cluster
nit: I think a better commit message would be something like
Move some ExternalMiniClusterITestBase methods into .cc file
Line 14: warning: function 'StopCluster' defined in a header file; function
nit: Are you sure about this? I don't see any functions in here, only class methods which are excepted from ODR rules.
--
To view, visit http://gerrit.cloudera.org:8080/5367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [ExternalMiniClusterITestBase] move some methods into .cc
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: [ExternalMiniClusterITestBase] move some methods into .cc
......................................................................
[ExternalMiniClusterITestBase] move some methods into .cc
Separated implementation of the external mini-cluster methods into a
separate .cc file: those methods contain too much code to be candidates
for inlining. Besides, this helps to have less header-wise dependencies
and avoid clang-tidy warnings like
warning: function 'StopCluster' defined in a header file; function
definitions in header files can lead to ODR violations
[misc-definitions-in-headers]
This patch does not contain any functional changes.
Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
Reviewed-on: http://gerrit.cloudera.org:8080/5367
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-test.cc
A src/kudu/integration-tests/external_mini_cluster-itest-base.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/tablet_replacement-itest.cc
7 files changed, 111 insertions(+), 54 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [ExternalMiniClusterITestBase] move some methods into .cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5367
to look at the new patch set (#3).
Change subject: [ExternalMiniClusterITestBase] move some methods into .cc
......................................................................
[ExternalMiniClusterITestBase] move some methods into .cc
Separated implementation of the external mini-cluster methods into a
separate .cc file: those methods contain too much code to be candidates
for inlining. Besides, this helps to have less header-wise dependencies
and avoid clang-tidy warnings like
warning: function 'StopCluster' defined in a header file; function
definitions in header files can lead to ODR violations
[misc-definitions-in-headers]
This patch does not contain any functional changes.
Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-test.cc
A src/kudu/integration-tests/external_mini_cluster-itest-base.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/tablet_replacement-itest.cc
7 files changed, 111 insertions(+), 54 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/5367/3
--
To view, visit http://gerrit.cloudera.org:8080/5367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [ExternalMiniClusterITestBase] move some methods into .cc
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [ExternalMiniClusterITestBase] move some methods into .cc
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [i-tests] separated implementation of the ext mini-cluster
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [i-tests] separated implementation of the ext mini-cluster
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5367/2//COMMIT_MSG
Commit Message:
Line 7: [i-tests] separated implementation of the ext mini-cluster
> nit: I think a better commit message would be something like
Done
Line 14: warning: function 'StopCluster' defined in a header file; function
> nit: Are you sure about this? I don't see any functions in here, only class
Yep: check https://gerrit.cloudera.org/#/c/5345/5/src/kudu/integration-tests/external_mini_cluster-itest-base.h
It might be false positive from clang-tidy, but even if that, having less include-dependencies would be better.
--
To view, visit http://gerrit.cloudera.org:8080/5367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [i-tests] separated implementation of the ext mini-cluster
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [i-tests] separated implementation of the ext mini-cluster
......................................................................
[i-tests] separated implementation of the ext mini-cluster
Separated implementation of the external mini-cluster methods into a
separate .cc file: those methods contain too much code to be candidates
for inlining. Besides, this helps to have less header-wise dependencies
and avoid clang-tidy warnings like
warning: function 'StopCluster' defined in a header file; function
definitions in header files can lead to ODR violations
[misc-definitions-in-headers]
This patch does not contain any functional changes.
Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-test.cc
A src/kudu/integration-tests/external_mini_cluster-itest-base.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/tablet_replacement-itest.cc
7 files changed, 111 insertions(+), 54 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/5367/2
--
To view, visit http://gerrit.cloudera.org:8080/5367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins