Re: [Bug 3825] Unescaped '#' in rawbody causes havoc

[Justin Mason <jm...@jmason.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Daniel Quinlan writes:
> I think it would be better if we did not allow end-of-line comments and
> required all comments to match:
> 
>   /^\s*#/
> 
> Then comments don't need to be escaped.  I think that would involve less
> surprise and also solves the problem.  I don't think this is purely a
> documentation problem.

That would be a major change in how our configuration files are parsed,
breaking a documented (although not particularly clearly) convention
that's been there since the project began.   It's also inconsistent with
the convention for this configuration file format.

the escaped-hash thing works fine (and I've used it myself at times),
and just needs to be documented.

I'm not keen on that at all: -1

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFBWJ0BQTcbUG5Y7woRAumpAKCFWgpeXutRdBr63WHWt4RN0XTGJACfRxMi
1NwN6SarUBc4JLWd/825vsM=
=UaZi
-----END PGP SIGNATURE-----

Re: [Bug 3825] Unescaped '#' in rawbody causes havoc

[Daniel Quinlan <qu...@pathname.com>]

Justin Mason <jm...@jmason.org> writes:

> That would be a major change in how our configuration files are parsed,
> breaking a documented (although not particularly clearly) convention
> that's been there since the project began.   It's also inconsistent with
> the convention for this configuration file format.

It would be better if our parser detected invalid lines rather than
outputting perl errors due to us parsing garbage.  That's my main
concern.  I am actually fine with requiring # to be escaped.  My main
concern is the non-clarity of the error statements, documentation does
not fix that.

(Side note: although not a requirement for this, getting rid of EOL
comments would make this easier if it was coupled with a requirement
that # be escaped.)

-- 
Daniel Quinlan                     ApacheCon! 13-17 November (3 SpamAssassin
http://www.pathname.com/~quinlan/  http://www.apachecon.com/  sessions & more)