You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/15 15:58:21 UTC
[GitHub] [apisix] tzssangglass opened a new pull request #2751: docs: how could I only enable passive health check (#2734)
tzssangglass opened a new pull request #2751:
URL: https://github.com/apache/apisix/pull/2751
fix: #2734
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #2751: docs: how could I only enable passive health check
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r523835705
##########
File path: FAQ.md
##########
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
```
2. Reload or restart APISIX
+
+## How could I only enable passive health check?
Review comment:
What exactly does that mean？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2751: docs: how could I only enable passive health check
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r523825777
##########
File path: FAQ.md
##########
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
```
2. Reload or restart APISIX
+
+## How could I only enable passive health check?
Review comment:
How about adding this tip standalone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2751: docs: how could I only enable passive health check
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r524867441
##########
File path: FAQ.md
##########
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
```
2. Reload or restart APISIX
+
+## How could I only enable passive health check?
Review comment:
Oh I know what happened, looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2751: docs: how could I only enable passive health check
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r525156242
##########
File path: FAQ.md
##########
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
```
2. Reload or restart APISIX
+
+## How could I only enable passive health check?
Review comment:
@tzssangglass sorry for the trouble, I update the title of issue #2748
the new title is: "It is unreasonable to only enable passive checking"
for more information, please take a look at: https://github.com/apache/apisix/issues/2746#issuecomment-727174592
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #2751: docs: how could I only enable passive health check
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r524820583
##########
File path: FAQ.md
##########
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
```
2. Reload or restart APISIX
+
+## How could I only enable passive health check?
Review comment:
ping@juzhiyuan ,standalone mean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2751: docs: how could I only enable passive health check
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r524825421
##########
File path: FAQ.md
##########
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
```
2. Reload or restart APISIX
+
+## How could I only enable passive health check?
Review comment:
I mean this PR's content is more like a new QA? How about creating a new QA in the FAQ instead of adding content under `How to change the log level?`
I'm not sure if it's a new QA or the improvements for `How to change the log level?`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #2751: docs: how could I only enable passive health check
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#issuecomment-728064962
> Is it better to add it to [health check documentation](https://github.com/apache/apisix/blob/master/doc/zh-cn/health-check.md)?
I see the health check documentation is a use document, not an F&Q. But your suggestion would make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #2751: docs: how could I only enable passive health check
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r525629329
##########
File path: FAQ.md
##########
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
```
2. Reload or restart APISIX
+
+## How could I only enable passive health check?
Review comment:
ok, I close this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] idbeta commented on pull request #2751: docs: how could I only enable passive health check
Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#issuecomment-727720476
Is it better to add it to [health check documentation](https://github.com/apache/apisix/blob/master/doc/zh-cn/health-check.md)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass closed pull request #2751: docs: how could I only enable passive health check
Posted by GitBox <gi...@apache.org>.
tzssangglass closed pull request #2751:
URL: https://github.com/apache/apisix/pull/2751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #2751: docs: how could I only enable passive health check
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #2751:
URL: https://github.com/apache/apisix/pull/2751#discussion_r524834780
##########
File path: FAQ.md
##########
@@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you
```
2. Reload or restart APISIX
+
+## How could I only enable passive health check?
Review comment:
this PR is a new QA, but it's not under `How to change the log level?`
in my markdown display, it looks like this
just like a new QA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org