You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/09/13 14:50:40 UTC
[GitHub] [ozone] sodonnel opened a new pull request #2634: HDDS-5738. EC: Resolve findbugs warnings after branch merge
sodonnel opened a new pull request #2634:
URL: https://github.com/apache/ozone/pull/2634
## What changes were proposed in this pull request?
After merging master into the EC branch, there are findbugs warnings on the branch. This PR is to fix them.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5738
## How was this patch tested?
No tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on pull request #2634: HDDS-5738. EC: Resolve findbugs warnings after branch merge
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on pull request #2634:
URL: https://github.com/apache/ozone/pull/2634#issuecomment-919273641
ok sure. I am not seeing this complaints as well so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on pull request #2634: HDDS-5738. EC: Resolve findbugs warnings after branch merge
Posted by GitBox <gi...@apache.org>.
sodonnel commented on pull request #2634:
URL: https://github.com/apache/ozone/pull/2634#issuecomment-918475758
I tried running findbugs again locally, and the problem is not coming up now. I am not sure what happened before. I will close this PR for now and open again later if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel closed pull request #2634: HDDS-5738. EC: Resolve findbugs warnings after branch merge
Posted by GitBox <gi...@apache.org>.
sodonnel closed pull request #2634:
URL: https://github.com/apache/ozone/pull/2634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on a change in pull request #2634: HDDS-5738. EC: Resolve findbugs warnings after branch merge
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #2634:
URL: https://github.com/apache/ozone/pull/2634#discussion_r707558409
##########
File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/response/key/TestOMKeyResponse.java
##########
@@ -76,7 +76,6 @@ public void setup() throws Exception {
random = new Random();
}
Review comment:
The findbugs complaints were mostly "redundant null check for value known to not be null", so removing the annotation made the warning go away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on a change in pull request #2634: HDDS-5738. EC: Resolve findbugs warnings after branch merge
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on a change in pull request #2634:
URL: https://github.com/apache/ozone/pull/2634#discussion_r707497299
##########
File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/response/key/TestOMKeyResponse.java
##########
@@ -76,7 +76,6 @@ public void setup() throws Exception {
random = new Random();
}
Review comment:
I still confused why it is complaining.
I see code of getOpenKey:
```
@Override
public String getOpenKey(String volume, String bucket,
String key, long id) {
String openKey = OM_KEY_PREFIX + volume + OM_KEY_PREFIX + bucket +
OM_KEY_PREFIX + key + OM_KEY_PREFIX + id;
return openKey;
}
```
Looks like it will not be null. Not sure whats going on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org