You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by atcurtis <gi...@git.apache.org> on 2014/11/21 05:36:42 UTC
[GitHub] helix pull request: [HELIX-555] Fix deficiency in ClusterStateVeri...
GitHub user atcurtis opened a pull request:
https://github.com/apache/helix/pull/12
[HELIX-555] Fix deficiency in ClusterStateVerifier api
https://issues.apache.org/jira/browse/HELIX-555
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/atcurtis/helix HELIX-555
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/12.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12
----
commit b2794e744e945da966c7ac6ae6408636951281d3
Author: Antony T Curtis <ac...@linkedin.com>
Date: 2014-11-21T04:36:01Z
[HELIX-555] Fix deficiency in ClusterStateVerifier api
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-555] Fix deficiency in ClusterStateVeri...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/helix/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-555] Fix deficiency in ClusterStateVeri...
Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on the pull request:
https://github.com/apache/helix/pull/12#issuecomment-63927164
OK, in that case, merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-555] Fix deficiency in ClusterStateVeri...
Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on the pull request:
https://github.com/apache/helix/pull/12#issuecomment-63924907
Or are there a bunch of tests/tools that create their own ZK client in addition to the one created by `ClusterStateVerifier`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request: [HELIX-555] Fix deficiency in ClusterStateVeri...
Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on the pull request:
https://github.com/apache/helix/pull/12#issuecomment-63924711
It looks like the original code already used `ZkClientPool`. How does this change improve the situation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---