You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jena.apache.org by afs <gi...@git.apache.org> on 2016/10/08 15:55:32 UTC

[GitHub] jena pull request #151: JENA-576: Moving away from deprecated HttpCommons Cl...

Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/151#discussion_r82504834
  
    --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java ---
    @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI, Query query, String queryString, Http
             this.query = query;
             this.queryString = queryString;
             this.service = serviceURI;
    -        // Copy the global context to freeze it.
    -        this.context = new Context(ARQ.getContext());
    +        this.context = ARQ.getContext();
    --- End diff --
    
    Need to take a copy of the context to isolate it from changes to the global context that may come later.
    
    It should be, current style:
    
        this.context = ARQ.getContext.copy() ;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---