[GitHub] [spark] sunchao commented on a change in pull request #33969: [SPARK-36726] Upgrade Parquet to 1.12.1

[GitBox <gi...@apache.org>]

sunchao commented on a change in pull request #33969:
URL: https://github.com/apache/spark/pull/33969#discussion_r707814742



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala
##########
@@ -855,6 +855,12 @@ class ParquetIOSuite extends QueryTest with ParquetTest with SharedSparkSession
     }
   }
 
+  test("SPARK-36726: test incorrect Parquet row group file offset") {
+    readParquetFile("test-data/malformed-file-offset.parquet") { df =>
+      assert(df.count() == 3650)

Review comment:
       I think `readParquetFile` already takes care of that, see `FileBasedDataSourceTest.readFile`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org