You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by tv...@apache.org on 2021/09/09 08:04:19 UTC
[buildstream] branch tristan/source-api-kwargs updated (16142f2 ->
71736af)
This is an automated email from the ASF dual-hosted git repository.
tvb pushed a change to branch tristan/source-api-kwargs
in repository https://gitbox.apache.org/repos/asf/buildstream.git.
discard 16142f2 source.py: Remove ambiguous kwargs from public API signature
new 71736af source.py: Remove ambiguous kwargs from public API signature
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (16142f2)
\
N -- N -- N refs/heads/tristan/source-api-kwargs (71736af)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
[buildstream] 01/01: source.py: Remove ambiguous kwargs from public
API signature
Posted by tv...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tvb pushed a commit to branch tristan/source-api-kwargs
in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit 71736afd041adc24367c81918a13c3eebe9f7a78
Author: Tristan van Berkom <tr...@codethink.co.uk>
AuthorDate: Thu Sep 9 17:02:40 2021 +0900
source.py: Remove ambiguous kwargs from public API signature
Fixes #1329
---
src/buildstream/source.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/buildstream/source.py b/src/buildstream/source.py
index 01bc270..bd4b3ec 100644
--- a/src/buildstream/source.py
+++ b/src/buildstream/source.py
@@ -424,7 +424,7 @@ class Source(Plugin):
"""
raise ImplError("Source plugin '{}' does not implement set_ref()".format(self.get_kind()))
- def track(self, **kwargs) -> SourceRef:
+ def track(self, *, previous_sources_dir: str = None) -> SourceRef:
"""Resolve a new ref from the plugin's track option
Args:
@@ -452,7 +452,7 @@ class Source(Plugin):
# Allow a non implementation
return None
- def fetch(self, **kwargs) -> None:
+ def fetch(self, *, previous_sources_dir: str = None) -> None:
"""Fetch remote sources and mirror them locally, ensuring at least
that the specific reference is cached locally.