Re: Review Request 73848: RANGER-3621 Optimise Tag/Policy iterator

[Madhan Neethiraj <ma...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73848/#review224077
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 18, 2022, 5:23 p.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73848/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2022, 5:23 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-3621
>     https://issues.apache.org/jira/browse/RANGER-3621
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Optimise the logic of Tag and service-policies cache iterator
> 
> Problem Statement:
> Tags/policies in the iterator are not freed till the whole processing of all Tags/policies are done. So, in the case where there are lot of tag/policies, the performance can be impacted as the large number of tags/policies are held by iterator for long time. This causes performance degradation while retrieving the tags from db.
> 
> Solution:
> The individual tag/policy as soon as it is processed should be removed from the iterator.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyRetriever.java 4a8a5ee2d 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java 1b7e8b272 
> 
> 
> Diff: https://reviews.apache.org/r/73848/diff/2/
> 
> 
> Testing
> -------
> 
> Tested Manually by using bulk data.
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>