[GitHub] john-bodley closed pull request #4573: [cache] Ensuring that the datasource UID is defined

[GitBox <gi...@apache.org>]

john-bodley closed pull request #4573: [cache] Ensuring that the datasource UID is defined
URL: https://github.com/apache/incubator-superset/pull/4573
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/viz.py b/superset/viz.py
index 9225e5da8f..36696bd317 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -276,9 +276,10 @@ def cache_key(self, query_obj):
         for k in ['from_dttm', 'to_dttm']:
             del cache_dict[k]
 
-        for k in ['since', 'until', 'datasource']:
+        for k in ['since', 'until']:
             cache_dict[k] = self.form_data.get(k)
 
+        cache_dict['datasource'] = self.datasource.uid
         json_data = self.json_dumps(cache_dict, sort_keys=True)
         return hashlib.md5(json_data.encode('utf-8')).hexdigest()
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services