You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "trns1997 (via GitHub)" <gi...@apache.org> on 2023/06/30 08:16:52 UTC

[GitHub] [nuttx] trns1997 commented on a diff in pull request #9639: Fixes for xmc4700-relax board

trns1997 commented on code in PR #9639:
URL: https://github.com/apache/nuttx/pull/9639#discussion_r1247579206


##########
boards/arm/xmc4/xmc4700-relax/src/xmc4_bringup.c:
##########
@@ -26,9 +26,15 @@
 
 #include <debug.h>
 #include <errno.h>
-#include <nuttx/spi/spi_transfer.h>
 #include <sys/types.h>
 
+#ifdef CONFIG_XMC4_USCI_SPI
+  #include <nuttx/spi/spi_transfer.h>
+#endif
+#ifdef CONFIG_USERLED
+  #include <nuttx/leds/userled.h>

Review Comment:
   Alright noted, sorry just my usual coding habit. It is more readable your way though I guess I might take it up :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org