You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/13 13:10:58 UTC
[GitHub] [flink] StephanEwen opened a new pull request #16483: [FLINK-22545][coordination] Fix check during creation of Source Coordinator thread
StephanEwen opened a new pull request #16483:
URL: https://github.com/apache/flink/pull/16483
## What is the purpose of the change
Fixed bug [FLINK-22545](https://issues.apache.org/jira/browse/FLINK-22545) leading to test instabilities, by changing a "safety net" sanity check during the creation of the Source Coordinator thread (which drives the Source's Split Enumerator).
The check was meant as a safeguard to prevent re-instantiation after fatal errors killed a previous thread.
But the check was susceptible to thread termination due to idleness in the executor.
This updates the check to only fail if there is in fact an instantiation next to a running thread, or after a
previously crashed thread.
## Verifying this change
This fixes a test instability, and is verified by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #16483: [FLINK-22545][coordination] Fix check during creation of Source Coordinator thread
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #16483:
URL: https://github.com/apache/flink/pull/16483#issuecomment-879449632
Thanks for the review, @rmetzger.
Manually merged in 331ae2cdfa7462b7cc5ed018484cb3eda257a174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16483: [FLINK-22545][coordination] Fix check during creation of Source Coordinator thread
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16483:
URL: https://github.com/apache/flink/pull/16483#issuecomment-879116792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff27afba1a08b713a01f1d7ca0fea535271b29ea",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20386",
"triggerID" : "ff27afba1a08b713a01f1d7ca0fea535271b29ea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff27afba1a08b713a01f1d7ca0fea535271b29ea Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20386)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen closed pull request #16483: [FLINK-22545][coordination] Fix check during creation of Source Coordinator thread
Posted by GitBox <gi...@apache.org>.
StephanEwen closed pull request #16483:
URL: https://github.com/apache/flink/pull/16483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #16483: [FLINK-22545][coordination] Fix check during creation of Source Coordinator thread
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #16483:
URL: https://github.com/apache/flink/pull/16483#issuecomment-879075462
@rmetzger FYI, as you previously worked on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16483: [FLINK-22545][coordination] Fix check during creation of Source Coordinator thread
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16483:
URL: https://github.com/apache/flink/pull/16483#issuecomment-879116792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff27afba1a08b713a01f1d7ca0fea535271b29ea",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20386",
"triggerID" : "ff27afba1a08b713a01f1d7ca0fea535271b29ea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff27afba1a08b713a01f1d7ca0fea535271b29ea Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20386)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16483: [FLINK-22545][coordination] Fix check during creation of Source Coordinator thread
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16483:
URL: https://github.com/apache/flink/pull/16483#issuecomment-879077094
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ff27afba1a08b713a01f1d7ca0fea535271b29ea (Tue Jul 13 13:13:40 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #16483: [FLINK-22545][coordination] Fix check during creation of Source Coordinator thread
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #16483:
URL: https://github.com/apache/flink/pull/16483#discussion_r668962271
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorProvider.java
##########
@@ -110,18 +115,32 @@ public OperatorCoordinator getCoordinator(OperatorCoordinator.Context context) {
@Override
public synchronized Thread newThread(Runnable r) {
- if (t != null) {
+ if (t != null && t.isAlive()) {
+ throw new Error(
+ "Source Coordinator Thread already exists. There should never be more than one "
+ + "thread driving the actions of a Source Coordinator. Existing Thread: "
+ + t);
+ }
+ if (t != null && previousFailureReason != null) {
throw new Error(
- "This indicates that a fatal error has happened and caused the "
- + "coordinator executor thread to exit. Check the earlier logs"
- + "to see the root cause of the problem.");
+ "The following a fatal error has happened in a previously spawned "
+ + "Source Coordinator thread. No new thread can be spawned.",
+ previousFailureReason);
Review comment:
```suggestion
"The following fatal error has happened in a previously spawned "
+ "Source Coordinator thread. No new thread can be spawned.",
previousFailureReason);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16483: [FLINK-22545][coordination] Fix check during creation of Source Coordinator thread
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16483:
URL: https://github.com/apache/flink/pull/16483#issuecomment-879116792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff27afba1a08b713a01f1d7ca0fea535271b29ea",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ff27afba1a08b713a01f1d7ca0fea535271b29ea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff27afba1a08b713a01f1d7ca0fea535271b29ea UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16483: [FLINK-22545][coordination] Fix check during creation of Source Coordinator thread
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16483:
URL: https://github.com/apache/flink/pull/16483#issuecomment-879077094
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ff27afba1a08b713a01f1d7ca0fea535271b29ea (Thu Sep 23 18:02:50 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org