[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4127: Declare byte array size when initializing ByteArrayOutputStream

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on issue #4127: Declare byte array size when initializing ByteArrayOutputStream
URL: https://github.com/apache/incubator-pinot/pull/4127#issuecomment-484196775
 
 
   > @Jackie-Jiang The byte array `buf` is encapsulated in `byteArrayOutputStream` and cannot directly be accessed though. Plus, `ByteBuffer.wrap()` only returns byte buffer, which isn't what we want to return in the end.
   
   You need to pass in a byte array into `ByteBuffer.wrap()`, which you can directly return.
   While, after consideration, maybe we should move it off-heap. But let's first make a tool to test the performance and gather some numbers. You can find examples under pinot-perf package.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org