You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/09 01:51:01 UTC
[GitHub] [apisix] spacewander opened a new pull request #3563: test: split prometheus test case
spacewander opened a new pull request #3563:
URL: https://github.com/apache/apisix/pull/3563
Fix #3561
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander edited a comment on pull request #3563: test: split prometheus test case
Posted by GitBox <gi...@apache.org>.
spacewander edited a comment on pull request #3563:
URL: https://github.com/apache/apisix/pull/3563#issuecomment-775643902
This change avoids a race in the test framework.
Also make the very long test bearable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3563: test: split prometheus test case
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #3563:
URL: https://github.com/apache/apisix/pull/3563#issuecomment-776455962
>
>
> Is the problem caused by defining `apisix_yaml` in test 44? If yes, do we need to worry about other tests which have the same customized yaml?
To trigger the error we need `TEST_NGINX_USE_HUP` set. So other tests are not affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3563: test: split prometheus test case
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #3563:
URL: https://github.com/apache/apisix/pull/3563#issuecomment-776456466
>
>
> should we make some limmitaions（lines or test cases） for one single test file？
What about 800 lines or 30 tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3563: test: split prometheus test case
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #3563:
URL: https://github.com/apache/apisix/pull/3563
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3563: test: split prometheus test case
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #3563:
URL: https://github.com/apache/apisix/pull/3563#issuecomment-775643902
This change avoid a race in the test framework.
Also make the very long test bearable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3563: test: split prometheus test case
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #3563:
URL: https://github.com/apache/apisix/pull/3563#issuecomment-776439271
Is the problem caused by defining `apisix_yaml` in test 44? If yes, do we need to worry about other tests which have the same customized yaml?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3563: test: split prometheus test case
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #3563:
URL: https://github.com/apache/apisix/pull/3563#issuecomment-776459681
> To trigger the error we need `TEST_NGINX_USE_HUP` set. So other tests are not affected.
Thanks a lot for the explanation!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org