You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/03 03:19:21 UTC

[GitHub] [skywalking] hanahmily opened a new pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

hanahmily opened a new pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431


   As docs indicate, the changes intend to introduce SSL to Prometheus telemetry and fetcher.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.87%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.28%   +0.87%     
   - Complexity     3271     3315      +44     
   ============================================
     Files           878      882       +4     
     Lines         21765    21861      +96     
     Branches       2087     2093       +6     
   ============================================
   + Hits          11191    11431     +240     
   + Misses         9680     9511     -169     
   - Partials        894      919      +25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [29 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     51.41%   0.00%   -51.42%     
   ============================================
     Files           878     161      -717     
     Lines         21765    3895    -17870     
     Branches       2087     443     -1644     
   ============================================
   - Hits          11191       0    -11191     
   + Misses         9680    3895     -5785     
   + Partials        894       0      -894     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [841 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `5.89%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   45.51%   -5.90%     
   + Complexity     3271     3004     -267     
   ============================================
     Files           878      877       -1     
     Lines         21765    21650     -115     
     Branches       2087     2063      -24     
   ============================================
   - Hits          11191     9855    -1336     
   - Misses         9680    10981    +1301     
   + Partials        894      814      -80     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [113 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **increase** coverage by `2.79%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     49.53%   52.33%   +2.79%     
   - Complexity     3190     3330     +140     
   ============================================
     Files           881     1576     +695     
     Lines         21863    33749   +11886     
     Branches       2094     3664    +1570     
   ============================================
   + Hits          10830    17661    +6831     
   - Misses        10143    15256    +5113     
   + Partials        890      832      -58     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1086 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   52.33%   -0.04%     
   - Complexity     3321     3330       +9     
   ============================================
     Files           879     1576     +697     
     Lines         21843    33749   +11906     
     Branches       2093     3664    +1571     
   ============================================
   + Hits          11439    17661    +6222     
   - Misses         9493    15256    +5763     
   + Partials        911      832      -79     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1076 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `22.43%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   28.98%   -22.44%     
   + Complexity     3271     1855     -1416     
   =============================================
     Files           878      862       -16     
     Lines         21765    21197      -568     
     Branches       2087     2034       -53     
   =============================================
   - Hits          11191     6143     -5048     
   - Misses         9680    14595     +4915     
   + Partials        894      459      -435     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [339 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.42%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.84%   +0.42%     
   - Complexity     3271     3278       +7     
   ============================================
     Files           878      880       +2     
     Lines         21765    21756       -9     
     Branches       2087     2084       -3     
   ============================================
   + Hits          11191    11279      +88     
   + Misses         9680     9575     -105     
   - Partials        894      902       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [40 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `22.38%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   30.06%   -22.39%     
   + Complexity     3320     1923     -1397     
   =============================================
     Files          1568      862      -706     
     Lines         33680    21235    -12445     
     Branches       3662     2027     -1635     
   =============================================
   - Hits          17666     6385    -11281     
   + Misses        15166    14369      -797     
   + Partials        848      481      -367     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1210 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `5.62%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   46.82%   -5.63%     
   + Complexity     3320     3027     -293     
   ============================================
     Files          1568      870     -698     
     Lines         33680    21496   -12184     
     Branches       3662     2061    -1601     
   ============================================
   - Hits          17666    10065    -7601     
   + Misses        15166    10584    -4582     
   + Partials        848      847       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1112 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **increase** coverage by `2.62%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     49.53%   52.15%   +2.62%     
   - Complexity     3190     3329     +139     
   ============================================
     Files           881      889       +8     
     Lines         21863    22031     +168     
     Branches       2094     2109      +15     
   ============================================
   + Hits          10830    11491     +661     
   + Misses        10143     9618     -525     
   - Partials        890      922      +32     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [62 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `11.96%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   39.44%   -11.97%     
   + Complexity     3271     2476      -795     
   =============================================
     Files           878      875        -3     
     Lines         21765    21633      -132     
     Branches       2087     2074       -13     
   =============================================
   - Hits          11191     8534     -2657     
   - Misses         9680    12467     +2787     
   + Partials        894      632      -262     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [215 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `1.19%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.61%   +1.19%     
   - Complexity     3271     3316      +45     
   ============================================
     Files           878      881       +3     
     Lines         21765    21744      -21     
     Branches       2087     2085       -2     
   ============================================
   + Hits          11191    11441     +250     
   + Misses         9680     9385     -295     
   - Partials        894      918      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [32 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `11.46%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   39.95%   -11.47%     
   + Complexity     3271     2514      -757     
   =============================================
     Files           878      875        -3     
     Lines         21765    21661      -104     
     Branches       2087     2079        -8     
   =============================================
   - Hits          11191     8655     -2536     
   - Misses         9680    12367     +2687     
   + Partials        894      639      -255     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [206 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `4.72%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.25%   47.52%   -4.73%     
   + Complexity     3301     3071     -230     
   ============================================
     Files          1567      887     -680     
     Lines         33609    21816   -11793     
     Branches       3654     2090    -1564     
   ============================================
   - Hits          17561    10368    -7193     
   + Misses        15215    10592    -4623     
   - Partials        833      856      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1100 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.49%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.91%   +0.49%     
   - Complexity     3271     3286      +15     
   ============================================
     Files           878      875       -3     
     Lines         21765    21691      -74     
     Branches       2087     2081       -6     
   ============================================
   + Hits          11191    11261      +70     
   + Misses         9680     9528     -152     
   - Partials        894      902       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [34 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `21.15%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   30.25%   -21.16%     
   + Complexity     3271     1946     -1325     
   =============================================
     Files           878      860       -18     
     Lines         21765    21157      -608     
     Branches       2087     2030       -57     
   =============================================
   - Hits          11191     6402     -4789     
   - Misses         9680    14275     +4595     
   + Partials        894      480      -414     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [315 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `4.47%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   47.98%   -4.48%     
   + Complexity     3320     3075     -245     
   ============================================
     Files          1568      870     -698     
     Lines         33680    21510   -12170     
     Branches       3662     2062    -1600     
   ============================================
   - Hits          17666    10321    -7345     
   + Misses        15166    10326    -4840     
   - Partials        848      863      +15     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1107 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `23.26%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   29.18%   -23.27%     
   + Complexity     3320     1875     -1445     
   =============================================
     Files          1568      867      -701     
     Lines         33680    21356    -12324     
     Branches       3662     2050     -1612     
   =============================================
   - Hits          17666     6233    -11433     
   + Misses        15166    14658      -508     
   + Partials        848      465      -383     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1208 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `13.72%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   38.52%   -13.73%     
   + Complexity     3301     2412      -889     
   =============================================
     Files          1567      887      -680     
     Lines         33609    21816    -11793     
     Branches       3654     2090     -1564     
   =============================================
   - Hits          17561     8405     -9156     
   + Misses        15215    12790     -2425     
   + Partials        833      621      -212     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1155 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `11.16%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   40.24%   -11.17%     
   + Complexity     3271     2508      -763     
   =============================================
     Files           878      879        +1     
     Lines         21765    21702       -63     
     Branches       2087     2079        -8     
   =============================================
   - Hits          11191     8735     -2456     
   - Misses         9680    12324     +2644     
   + Partials        894      643      -251     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [199 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `52.45%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     52.45%   0.00%   -52.46%     
   ============================================
     Files          1568     161     -1407     
     Lines         33680    3954    -29726     
     Branches       3662     465     -3197     
   ============================================
   - Hits          17666       0    -17666     
   + Misses        15166    3954    -11212     
   + Partials        848       0      -848     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1535 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `4.87%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   47.57%   -4.88%     
   + Complexity     3320     3116     -204     
   ============================================
     Files          1568      887     -681     
     Lines         33680    21948   -11732     
     Branches       3662     2103    -1559     
   ============================================
   - Hits          17666    10442    -7224     
   + Misses        15166    10633    -4533     
   - Partials        848      873      +25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1094 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **increase** coverage by `2.54%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     49.53%   52.07%   +2.54%     
   - Complexity     3190     3323     +133     
   ============================================
     Files           881      887       +6     
     Lines         21863    22025     +162     
     Branches       2094     2109      +15     
   ============================================
   + Hits          10830    11470     +640     
   + Misses        10143     9632     -511     
   - Partials        890      923      +33     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [65 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `52.45%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     52.45%   0.00%   -52.46%     
   ============================================
     Files          1568     156     -1412     
     Lines         33680    3835    -29845     
     Branches       3662     452     -3210     
   ============================================
   - Hits          17666       0    -17666     
   + Misses        15166    3835    -11331     
   + Partials        848       0      -848     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1537 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `4.68%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.25%   47.56%   -4.69%     
   + Complexity     3301     3075     -226     
   ============================================
     Files          1567      887     -680     
     Lines         33609    21816   -11793     
     Branches       3654     2090    -1564     
   ============================================
   - Hits          17561    10377    -7184     
   + Misses        15215    10584    -4631     
   - Partials        833      855      +22     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1099 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   52.28%   -0.08%     
   - Complexity     3321     3330       +9     
   ============================================
     Files           879      887       +8     
     Lines         21843    21970     +127     
     Branches       2093     2103      +10     
   ============================================
   + Hits          11439    11488      +49     
   - Misses         9493     9568      +75     
   - Partials        911      914       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [25 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `14.50%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   37.74%   -14.51%     
   + Complexity     3301     2387      -914     
   =============================================
     Files          1567      887      -680     
     Lines         33609    21806    -11803     
     Branches       3654     2089     -1565     
   =============================================
   - Hits          17561     8231     -9330     
   + Misses        15215    12972     -2243     
   + Partials        833      603      -230     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1155 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `3.41%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   48.95%   -3.42%     
   + Complexity     3321     3171     -150     
   ============================================
     Files           879      883       +4     
     Lines         21843    21904      +61     
     Branches       2093     2083      -10     
   ============================================
   - Hits          11439    10724     -715     
   - Misses         9493    10315     +822     
   + Partials        911      865      -46     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [81 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/596c85fd5c3aa64d7f6918f1be87da49d4dbe438?el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `57.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     52.38%   52.44%   +0.05%     
   - Complexity     3304     3330      +26     
   ============================================
     Files          1562      887     -675     
     Lines         33446    21876   -11570     
     Branches       3662     2092    -1570     
   ============================================
   - Hits          17520    11472    -6048     
   + Misses        15094     9488    -5606     
   - Partials        832      916      +84     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...ovider/handler/grpc/BrowserPerfServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvZ3JwYy9Ccm93c2VyUGVyZlNlcnZpY2VIYW5kbGVyLmphdmE=) | `51.85% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | [.../rest/BrowserErrorLogReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRMaXN0U2VydmxldEhhbmRsZXIuamF2YQ==) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | |
   | [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <30.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...dler/rest/BrowserPerfDataReportServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyUGVyZkRhdGFSZXBvcnRTZXJ2bGV0SGFuZGxlci5qYXZh) | `38.70% <38.70%> (ø)` | `3.00 <3.00> (?)` | |
   | [.../rest/BrowserErrorLogReportBaseServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRCYXNlU2VydmxldEhhbmRsZXIuamF2YQ==) | `45.83% <45.83%> (ø)` | `2.00 <2.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | ... and [1090 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.50%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.92%   +0.50%     
   - Complexity     3271     3294      +23     
   ============================================
     Files           878     1571     +693     
     Lines         21765    33611   +11846     
     Branches       2087     3661    +1574     
   ============================================
   + Hits          11191    17452    +6261     
   - Misses         9680    15326    +5646     
   + Partials        894      833      -61     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1071 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `2.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   54.28%   +2.86%     
   + Complexity     3271      715    -2556     
   ============================================
     Files           878      163     -715     
     Lines         21765     3907   -17858     
     Branches       2087      443    -1644     
   ============================================
   - Hits          11191     2121    -9070     
   + Misses         9680     1523    -8157     
   + Partials        894      263     -631     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
   | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
   | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | | | |
   | [...rver/storage/plugin/influxdb/query/AlarmQuery.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9BbGFybVF1ZXJ5LmphdmE=) | | | |
   | [...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh) | | | |
   | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | | | |
   | [...alking/oap/server/core/cache/ProfileTaskCache.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2FjaGUvUHJvZmlsZVRhc2tDYWNoZS5qYXZh) | | | |
   | ... and [705 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `11.98%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   39.43%   -11.99%     
   + Complexity     3271     2475      -796     
   =============================================
     Files           878      875        -3     
     Lines         21765    21623      -142     
     Branches       2087     2074       -13     
   =============================================
   - Hits          11191     8526     -2665     
   - Misses         9680    12465     +2785     
   + Partials        894      632      -262     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [216 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **decrease** coverage by `49.53%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     49.53%   0.00%   -49.54%     
   ============================================
     Files           881     157      -724     
     Lines         21863    3853    -18010     
     Branches       2094     445     -1649     
   ============================================
   - Hits          10830       0    -10830     
   + Misses        10143    3853     -6290     
   + Partials        890       0      -890     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [846 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `11.88%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   40.56%   -11.89%     
   + Complexity     3320     2683      -637     
   =============================================
     Files          1568      865      -703     
     Lines         33680    21380    -12300     
     Branches       3662     2039     -1623     
   =============================================
   - Hits          17666     8673     -8993     
   + Misses        15166    11983     -3183     
   + Partials        848      724      -124     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1142 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `22.37%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   29.04%   -22.38%     
   + Complexity     3271     1857     -1414     
   =============================================
     Files           878      862       -16     
     Lines         21765    21197      -568     
     Branches       2087     2034       -53     
   =============================================
   - Hits          11191     6157     -5034     
   - Misses         9680    14580     +4900     
   + Partials        894      460      -434     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [338 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **decrease** coverage by `49.53%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     49.53%   0.00%   -49.54%     
   ============================================
     Files           881     171      -710     
     Lines         21863    4142    -17721     
     Branches       2094     478     -1616     
   ============================================
   - Hits          10830       0    -10830     
   + Misses        10143    4142     -6001     
   + Partials        890       0      -890     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [836 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   51.13%   -0.29%     
   + Complexity     3271     3255      -16     
   ============================================
     Files           878      880       +2     
     Lines         21765    21732      -33     
     Branches       2087     2070      -17     
   ============================================
   - Hits          11191    11113      -78     
   - Misses         9680     9717      +37     
   - Partials        894      902       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [37 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `22.62%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   29.62%   -22.63%     
   + Complexity     3301     1886     -1415     
   =============================================
     Files          1567      862      -705     
     Lines         33609    21165    -12444     
     Branches       3654     2031     -1623     
   =============================================
   - Hits          17561     6271    -11290     
   + Misses        15215    14426      -789     
   + Partials        833      468      -365     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1208 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `12.06%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   40.39%   -12.07%     
   + Complexity     3320     2683      -637     
   =============================================
     Files          1568      870      -698     
     Lines         33680    21472    -12208     
     Branches       3662     2044     -1618     
   =============================================
   - Hits          17666     8673     -8993     
   + Misses        15166    12075     -3091     
   + Partials        848      724      -124     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1139 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `1.12%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   50.29%   -1.13%     
   + Complexity     3271     3212      -59     
   ============================================
     Files           878      875       -3     
     Lines         21765    21678      -87     
     Branches       2087     2080       -7     
   ============================================
   - Hits          11191    10902     -289     
   - Misses         9680     9898     +218     
   + Partials        894      878      -16     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [74 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on a change in pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#discussion_r483327063



##########
File path: tools/dependencies/known-oap-backend-dependencies-es7.txt
##########
@@ -157,7 +157,6 @@ retrofit-2.3.0.jar
 simpleclient-0.6.0.jar
 simpleclient_common-0.6.0.jar
 simpleclient_hotspot-0.6.0.jar
-simpleclient_httpserver-0.6.0.jar

Review comment:
       The whole simpleclient dependencies are missed in the DIST LICENSE, please fix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/596c85fd5c3aa64d7f6918f1be87da49d4dbe438?el=desc) will **decrease** coverage by `0.61%`.
   > The diff coverage is `57.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.38%   51.76%   -0.62%     
   - Complexity     3304     3309       +5     
   ============================================
     Files          1562      887     -675     
     Lines         33446    21876   -11570     
     Branches       3662     2092    -1570     
   ============================================
   - Hits          17520    11324    -6196     
   + Misses        15094     9639    -5455     
   - Partials        832      913      +81     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...ovider/handler/grpc/BrowserPerfServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvZ3JwYy9Ccm93c2VyUGVyZlNlcnZpY2VIYW5kbGVyLmphdmE=) | `51.85% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | [.../rest/BrowserErrorLogReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRMaXN0U2VydmxldEhhbmRsZXIuamF2YQ==) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | |
   | [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <30.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...dler/rest/BrowserPerfDataReportServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyUGVyZkRhdGFSZXBvcnRTZXJ2bGV0SGFuZGxlci5qYXZh) | `38.70% <38.70%> (ø)` | `3.00 <3.00> (?)` | |
   | [.../rest/BrowserErrorLogReportBaseServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRCYXNlU2VydmxldEhhbmRsZXIuamF2YQ==) | `45.83% <45.83%> (ø)` | `2.00 <2.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | ... and [1091 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/596c85fd5c3aa64d7f6918f1be87da49d4dbe438?el=desc) will **decrease** coverage by `0.08%`.
   > The diff coverage is `66.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.38%   52.29%   -0.09%     
   - Complexity     3304     3330      +26     
   ============================================
     Files          1562     1576      +14     
     Lines         33446    33754     +308     
     Branches       3662     3666       +4     
   ============================================
   + Hits          17520    17651     +131     
   - Misses        15094    15270     +176     
   - Partials        832      833       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...ovider/handler/grpc/BrowserPerfServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvZ3JwYy9Ccm93c2VyUGVyZlNlcnZpY2VIYW5kbGVyLmphdmE=) | `30.43% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | [.../rest/BrowserErrorLogReportBaseServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRCYXNlU2VydmxldEhhbmRsZXIuamF2YQ==) | `44.00% <44.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...dler/rest/BrowserPerfDataReportServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyUGVyZkRhdGFSZXBvcnRTZXJ2bGV0SGFuZGxlci5qYXZh) | `59.37% <59.37%> (ø)` | `3.00 <3.00> (?)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [43 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     51.41%   0.00%   -51.42%     
   ============================================
     Files           878     168      -710     
     Lines         21765    4043    -17722     
     Branches       2087     467     -1620     
   ============================================
   - Hits          11191       0    -11191     
   + Misses         9680    4043     -5637     
   + Partials        894       0      -894     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [836 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `4.90%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   47.54%   -4.91%     
   + Complexity     3320     3115     -205     
   ============================================
     Files          1568      887     -681     
     Lines         33680    21948   -11732     
     Branches       3662     2103    -1559     
   ============================================
   - Hits          17666    10435    -7231     
   + Misses        15166    10639    -4527     
   - Partials        848      874      +26     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1094 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **decrease** coverage by `7.96%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     49.53%   41.57%   -7.97%     
   + Complexity     3190     2585     -605     
   ============================================
     Files           881      887       +6     
     Lines         21863    22025     +162     
     Branches       2094     2109      +15     
   ============================================
   - Hits          10830     9156    -1674     
   - Misses        10143    12204    +2061     
   + Partials        890      665     -225     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [216 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **decrease** coverage by `20.13%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     49.53%   29.39%   -20.14%     
   + Complexity     3190     1890     -1300     
   =============================================
     Files           881      867       -14     
     Lines         21863    21350      -513     
     Branches       2094     2037       -57     
   =============================================
   - Hits          10830     6276     -4554     
   - Misses        10143    14598     +4455     
   + Partials        890      476      -414     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [305 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **increase** coverage by `2.67%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     49.53%   52.20%   +2.67%     
   - Complexity     3190     3333     +143     
   ============================================
     Files           881      889       +8     
     Lines         21863    22031     +168     
     Branches       2094     2109      +15     
   ============================================
   + Hits          10830    11502     +672     
   + Misses        10143     9606     -537     
   - Partials        890      923      +33     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [65 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.53%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.94%   +0.53%     
   - Complexity     3271     3287      +16     
   ============================================
     Files           878      875       -3     
     Lines         21765    21691      -74     
     Branches       2087     2081       -6     
   ============================================
   + Hits          11191    11268      +77     
   + Misses         9680     9522     -158     
   - Partials        894      901       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [33 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `1.83%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   50.53%   -1.84%     
   + Complexity     3321     3232      -89     
   ============================================
     Files           879      883       +4     
     Lines         21843    21904      +61     
     Branches       2093     2083      -10     
   ============================================
   - Hits          11439    11069     -370     
   - Misses         9493     9951     +458     
   + Partials        911      884      -27     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [71 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `19.38%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   32.86%   -19.39%     
   + Complexity     3301     2058     -1243     
   =============================================
     Files          1567      863      -704     
     Lines         33609    21224    -12385     
     Branches       3654     2034     -1620     
   =============================================
   - Hits          17561     6975    -10586     
   + Misses        15215    13730     -1485     
   + Partials        833      519      -314     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1191 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **increase** coverage by `2.53%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     49.53%   52.06%   +2.53%     
   - Complexity     3190     3324     +134     
   ============================================
     Files           881      889       +8     
     Lines         21863    22031     +168     
     Branches       2094     2109      +15     
   ============================================
   + Hits          10830    11471     +641     
   + Misses        10143     9638     -505     
   - Partials        890      922      +32     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [62 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   51.36%   -0.06%     
   - Complexity     3271     3272       +1     
   ============================================
     Files           878      880       +2     
     Lines         21765    21740      -25     
     Branches       2087     2085       -2     
   ============================================
   - Hits          11191    11167      -24     
   + Misses         9680     9668      -12     
   - Partials        894      905      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [32 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `18.37%`.
   > The diff coverage is `0.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   33.04%   -18.38%     
   + Complexity     3271     2238     -1033     
   =============================================
     Files           878      859       -19     
     Lines         21765    20859      -906     
     Branches       2087     1968      -119     
   =============================================
   - Hits          11191     6892     -4299     
   - Misses         9680    13370     +3690     
   + Partials        894      597      -297     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `50.00% <ø> (-33.34%)` | `9.00 <0.00> (-1.00)` | |
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `23.52% <0.00%> (-64.71%)` | `2.00 <0.00> (-6.00)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [272 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.86%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.28%   +0.86%     
   - Complexity     3271     3319      +48     
   ============================================
     Files           878      886       +8     
     Lines         21765    21892     +127     
     Branches       2087     2097      +10     
   ============================================
   + Hits          11191    11446     +255     
   + Misses         9680     9530     -150     
   - Partials        894      916      +22     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [22 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `11.65%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   39.76%   -11.66%     
   + Complexity     3271     2459      -812     
   =============================================
     Files           878      880        +2     
     Lines         21765    21790       +25     
     Branches       2087     2087               
   =============================================
   - Hits          11191     8664     -2527     
   - Misses         9680    12480     +2800     
   + Partials        894      646      -248     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [219 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `21.61%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   30.83%   -21.62%     
   + Complexity     3320     2005     -1315     
   =============================================
     Files          1568      869      -699     
     Lines         33680    21400    -12280     
     Branches       3662     2053     -1609     
   =============================================
   - Hits          17666     6599    -11067     
   + Misses        15166    14310      -856     
   + Partials        848      491      -357     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1194 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `16.82%`.
   > The diff coverage is `0.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.36%   35.54%   -16.83%     
   + Complexity     3321     2215     -1106     
   =============================================
     Files           879      881        +2     
     Lines         21843    21597      -246     
     Branches       2093     2031       -62     
   =============================================
   - Hits          11439     7677     -3762     
   - Misses         9493    13405     +3912     
   + Partials        911      515      -396     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `50.00% <ø> (-33.34%)` | `9.00 <0.00> (-1.00)` | |
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `23.52% <0.00%> (-64.71%)` | `2.00 <0.00> (-6.00)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [256 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `52.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     52.36%   0.00%   -52.37%     
   ============================================
     Files           879     167      -712     
     Lines         21843    4018    -17825     
     Branches       2093     457     -1636     
   ============================================
   - Hits          11439       0    -11439     
   + Misses         9493    4018     -5475     
   + Partials        911       0      -911     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [838 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `0.39%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.25%   51.85%   -0.40%     
   + Complexity     3301     3294       -7     
   ============================================
     Files          1567     1572       +5     
     Lines         33609    33656      +47     
     Branches       3654     3662       +8     
   ============================================
   - Hits          17561    17452     -109     
   - Misses        15215    15371     +156     
     Partials        833      833              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [39 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.86%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.28%   +0.86%     
   - Complexity     3271     3319      +48     
   ============================================
     Files           878      886       +8     
     Lines         21765    21892     +127     
     Branches       2087     2097      +10     
   ============================================
   + Hits          11191    11446     +255     
   + Misses         9680     9530     -150     
   - Partials        894      916      +22     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [22 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...ba53672](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `11.97%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   39.44%   -11.98%     
   + Complexity     3271     2474      -797     
   =============================================
     Files           878      875        -3     
     Lines         21765    21615      -150     
     Branches       2087     2059       -28     
   =============================================
   - Hits          11191     8525     -2666     
   - Misses         9680    12457     +2777     
   + Partials        894      633      -261     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [222 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `1.71%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   50.65%   -1.72%     
   + Complexity     3321     3239      -82     
   ============================================
     Files           879      883       +4     
     Lines         21843    21904      +61     
     Branches       2093     2083      -10     
   ============================================
   - Hits          11439    11096     -343     
   - Misses         9493     9922     +429     
   + Partials        911      886      -25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [70 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `3.81%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   47.60%   -3.82%     
   + Complexity     3271     3098     -173     
   ============================================
     Files           878      877       -1     
     Lines         21765    21686      -79     
     Branches       2087     2064      -23     
   ============================================
   - Hits          11191    10323     -868     
   - Misses         9680    10517     +837     
   + Partials        894      846      -48     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [94 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `17.92%`.
   > The diff coverage is `0.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.36%   34.44%   -17.93%     
   + Complexity     3321     2160     -1161     
   =============================================
     Files           879      880        +1     
     Lines         21843    21559      -284     
     Branches       2093     2027       -66     
   =============================================
   - Hits          11439     7425     -4014     
   - Misses         9493    13623     +4130     
   + Partials        911      511      -400     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `50.00% <ø> (-33.34%)` | `9.00 <0.00> (-1.00)` | |
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `23.52% <0.00%> (-64.71%)` | `2.00 <0.00> (-6.00)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [275 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `20.93%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   31.51%   -20.94%     
   + Complexity     3320     2021     -1299     
   =============================================
     Files          1568      862      -706     
     Lines         33680    21281    -12399     
     Branches       3662     2028     -1634     
   =============================================
   - Hits          17666     6707    -10959     
   + Misses        15166    14084     -1082     
   + Partials        848      490      -358     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1198 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/596c85fd5c3aa64d7f6918f1be87da49d4dbe438?el=desc) will **decrease** coverage by `3.42%`.
   > The diff coverage is `57.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.38%   48.95%   -3.43%     
   + Complexity     3304     3182     -122     
   ============================================
     Files          1562      887     -675     
     Lines         33446    21840   -11606     
     Branches       3662     2091    -1571     
   ============================================
   - Hits          17520    10692    -6828     
   + Misses        15094    10271    -4823     
   - Partials        832      877      +45     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...ovider/handler/grpc/BrowserPerfServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvZ3JwYy9Ccm93c2VyUGVyZlNlcnZpY2VIYW5kbGVyLmphdmE=) | `51.85% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | [.../rest/BrowserErrorLogReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRMaXN0U2VydmxldEhhbmRsZXIuamF2YQ==) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | |
   | [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <30.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...dler/rest/BrowserPerfDataReportServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyUGVyZkRhdGFSZXBvcnRTZXJ2bGV0SGFuZGxlci5qYXZh) | `38.70% <38.70%> (ø)` | `3.00 <3.00> (?)` | |
   | [.../rest/BrowserErrorLogReportBaseServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRCYXNlU2VydmxldEhhbmRsZXIuamF2YQ==) | `45.83% <45.83%> (ø)` | `2.00 <2.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | ... and [1103 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `23.04%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   29.40%   -23.05%     
   + Complexity     3320     1895     -1425     
   =============================================
     Files          1568      869      -699     
     Lines         33680    21367    -12313     
     Branches       3662     2050     -1612     
   =============================================
   - Hits          17666     6284    -11382     
   + Misses        15166    14611      -555     
   + Partials        848      472      -376     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1205 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/596c85fd5c3aa64d7f6918f1be87da49d4dbe438?el=desc) will **decrease** coverage by `1.41%`.
   > The diff coverage is `57.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.38%   50.96%   -1.42%     
   + Complexity     3304     3280      -24     
   ============================================
     Files          1562      887     -675     
     Lines         33446    21876   -11570     
     Branches       3662     2092    -1570     
   ============================================
   - Hits          17520    11150    -6370     
   + Misses        15094     9821    -5273     
   - Partials        832      905      +73     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...ovider/handler/grpc/BrowserPerfServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvZ3JwYy9Ccm93c2VyUGVyZlNlcnZpY2VIYW5kbGVyLmphdmE=) | `51.85% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | [.../rest/BrowserErrorLogReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRMaXN0U2VydmxldEhhbmRsZXIuamF2YQ==) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | |
   | [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <30.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...dler/rest/BrowserPerfDataReportServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyUGVyZkRhdGFSZXBvcnRTZXJ2bGV0SGFuZGxlci5qYXZh) | `38.70% <38.70%> (ø)` | `3.00 <3.00> (?)` | |
   | [.../rest/BrowserErrorLogReportBaseServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRCYXNlU2VydmxldEhhbmRsZXIuamF2YQ==) | `45.83% <45.83%> (ø)` | `2.00 <2.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | ... and [1093 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `0.91%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   51.45%   -0.92%     
   + Complexity     3321     3301      -20     
   ============================================
     Files           879      885       +6     
     Lines         21843    21954     +111     
     Branches       2093     2102       +9     
   ============================================
   - Hits          11439    11296     -143     
   - Misses         9493     9762     +269     
   + Partials        911      896      -15     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [39 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `7.28%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   44.13%   -7.29%     
   + Complexity     3271     2924     -347     
   ============================================
     Files           878      879       +1     
     Lines         21765    21607     -158     
     Branches       2087     2051      -36     
   ============================================
   - Hits          11191     9536    -1655     
   - Misses         9680    11266    +1586     
   + Partials        894      805      -89     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [132 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `3.04%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   54.46%   +3.04%     
   + Complexity     3271      716    -2555     
   ============================================
     Files           878      163     -715     
     Lines         21765     3907   -17858     
     Branches       2087      443    -1644     
   ============================================
   - Hits          11191     2128    -9063     
   + Misses         9680     1517    -8163     
   + Partials        894      262     -632     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
   | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | | | |
   | [...rver/storage/plugin/influxdb/query/AlarmQuery.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9BbGFybVF1ZXJ5LmphdmE=) | | | |
   | [...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh) | | | |
   | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | | | |
   | [...alking/oap/server/core/cache/ProfileTaskCache.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2FjaGUvUHJvZmlsZVRhc2tDYWNoZS5qYXZh) | | | |
   | [...r/exporter/provider/grpc/GRPCExporterProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyUHJvdmlkZXIuamF2YQ==) | | | |
   | ... and [704 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `4.48%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   47.96%   -4.49%     
   + Complexity     3320     3147     -173     
   ============================================
     Files          1568      887     -681     
     Lines         33680    21989   -11691     
     Branches       3662     2108    -1554     
   ============================================
   - Hits          17666    10548    -7118     
   + Misses        15166    10572    -4594     
   - Partials        848      869      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1094 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.04%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.46%   +0.04%     
     Complexity     3271     3271              
   ============================================
     Files           878      879       +1     
     Lines         21765    21651     -114     
     Branches       2087     2067      -20     
   ============================================
   - Hits          11191    11143      -48     
   + Misses         9680     9595      -85     
   - Partials        894      913      +19     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [41 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.53%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.95%   +0.53%     
   - Complexity     3271     3290      +19     
   ============================================
     Files           878      884       +6     
     Lines         21765    21821      +56     
     Branches       2087     2091       +4     
   ============================================
   + Hits          11191    11337     +146     
   + Misses         9680     9572     -108     
   - Partials        894      912      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [31 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `17.09%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   34.32%   -17.10%     
   + Complexity     3271     2123     -1148     
   =============================================
     Files           878      862       -16     
     Lines         21765    21258      -507     
     Branches       2087     2039       -48     
   =============================================
   - Hits          11191     7296     -3895     
   - Misses         9680    13410     +3730     
   + Partials        894      552      -342     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [284 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.43%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.85%   +0.43%     
   - Complexity     3271     3294      +23     
   ============================================
     Files           878     1572     +694     
     Lines         21765    33656   +11891     
     Branches       2087     3662    +1575     
   ============================================
   + Hits          11191    17452    +6261     
   - Misses         9680    15371    +5691     
   + Partials        894      833      -61     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1070 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.86%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.28%   +0.86%     
   - Complexity     3271     3319      +48     
   ============================================
     Files           878      886       +8     
     Lines         21765    21892     +127     
     Branches       2087     2097      +10     
   ============================================
   + Hits          11191    11446     +255     
   + Misses         9680     9530     -150     
   - Partials        894      916      +22     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [22 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `1.80%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   50.56%   -1.81%     
   + Complexity     3321     3239      -82     
   ============================================
     Files           879      885       +6     
     Lines         21843    21946     +103     
     Branches       2093     2087       -6     
   ============================================
   - Hits          11439    11096     -343     
   - Misses         9493     9964     +471     
   + Partials        911      886      -25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [68 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `17.23%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   34.18%   -17.24%     
   + Complexity     3271     2147     -1124     
   =============================================
     Files           878      856       -22     
     Lines         21765    21105      -660     
     Branches       2087     2013       -74     
   =============================================
   - Hits          11191     7214     -3977     
   - Misses         9680    13367     +3687     
   + Partials        894      524      -370     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [291 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.67%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.09%   +0.67%     
   - Complexity     3271     3294      +23     
   ============================================
     Files           878      875       -3     
     Lines         21765    21691      -74     
     Branches       2087     2081       -6     
   ============================================
   + Hits          11191    11300     +109     
   + Misses         9680     9486     -194     
   - Partials        894      905      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [30 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `11.55%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   39.85%   -11.56%     
   + Complexity     3271     2506      -765     
   =============================================
     Files           878      875        -3     
     Lines         21765    21661      -104     
     Branches       2087     2079        -8     
   =============================================
   - Hits          11191     8634     -2557     
   - Misses         9680    12389     +2709     
   + Partials        894      638      -256     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [211 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `1.15%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.57%   +1.15%     
   - Complexity     3271     3317      +46     
   ============================================
     Files           878      882       +4     
     Lines         21765    21767       +2     
     Branches       2087     2079       -8     
   ============================================
   + Hits          11191    11444     +253     
   + Misses         9680     9407     -273     
   - Partials        894      916      +22     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     51.41%   0.00%   -51.42%     
   ============================================
     Files           878     164      -714     
     Lines         21765    3989    -17776     
     Branches       2087     463     -1624     
   ============================================
   - Hits          11191       0    -11191     
   + Misses         9680    3989     -5691     
   + Partials        894       0      -894     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [838 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `19.46%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   31.95%   -19.47%     
   + Complexity     3271     2017     -1254     
   =============================================
     Files           878      862       -16     
     Lines         21765    21222      -543     
     Branches       2087     2038       -49     
   =============================================
   - Hits          11191     6781     -4410     
   - Misses         9680    13927     +4247     
   + Partials        894      514      -380     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [312 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `22.67%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   29.57%   -22.68%     
   + Complexity     3301     1886     -1415     
   =============================================
     Files          1567      863      -704     
     Lines         33609    21204    -12405     
     Branches       3654     2032     -1622     
   =============================================
   - Hits          17561     6271    -11290     
   + Misses        15215    14465      -750     
   + Partials        833      468      -365     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/596c85fd5c3aa64d7f6918f1be87da49d4dbe438?el=desc) will **decrease** coverage by `4.81%`.
   > The diff coverage is `57.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.38%   47.56%   -4.82%     
   + Complexity     3304     3075     -229     
   ============================================
     Files          1562      887     -675     
     Lines         33446    21816   -11630     
     Branches       3662     2090    -1572     
   ============================================
   - Hits          17520    10377    -7143     
   + Misses        15094    10584    -4510     
   - Partials        832      855      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...ovider/handler/grpc/BrowserPerfServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvZ3JwYy9Ccm93c2VyUGVyZlNlcnZpY2VIYW5kbGVyLmphdmE=) | `51.85% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | [.../rest/BrowserErrorLogReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRMaXN0U2VydmxldEhhbmRsZXIuamF2YQ==) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | |
   | [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <30.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...dler/rest/BrowserPerfDataReportServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyUGVyZkRhdGFSZXBvcnRTZXJ2bGV0SGFuZGxlci5qYXZh) | `38.70% <38.70%> (ø)` | `3.00 <3.00> (?)` | |
   | [.../rest/BrowserErrorLogReportBaseServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRCYXNlU2VydmxldEhhbmRsZXIuamF2YQ==) | `45.83% <45.83%> (ø)` | `2.00 <2.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | ... and [1111 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `22.40%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   29.01%   -22.41%     
   + Complexity     3271     1855     -1416     
   =============================================
     Files           878      861       -17     
     Lines         21765    21171      -594     
     Branches       2087     2034       -53     
   =============================================
   - Hits          11191     6143     -5048     
   - Misses         9680    14569     +4889     
   + Partials        894      459      -435     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [340 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `10.78%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   40.63%   -10.79%     
   + Complexity     3271     2538      -733     
   =============================================
     Files           878      875        -3     
     Lines         21765    21678       -87     
     Branches       2087     2080        -7     
   =============================================
   - Hits          11191     8808     -2383     
   - Misses         9680    12231     +2551     
   + Partials        894      639      -255     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [200 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.50%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.92%   +0.50%     
   - Complexity     3271     3294      +23     
   ============================================
     Files           878     1571     +693     
     Lines         21765    33611   +11846     
     Branches       2087     3661    +1574     
   ============================================
   + Hits          11191    17452    +6261     
   - Misses         9680    15326    +5646     
   + Partials        894      833      -61     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1071 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] commented on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] commented on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     51.41%   0.00%   -51.42%     
   ============================================
     Files           878     156      -722     
     Lines         21765    3834    -17931     
     Branches       2087     438     -1649     
   ============================================
   - Hits          11191       0    -11191     
   + Misses         9680    3834     -5846     
   + Partials        894       0      -894     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [845 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `52.45%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     52.45%   0.00%   -52.46%     
   ============================================
     Files          1568     171     -1397     
     Lines         33680    4142    -29538     
     Branches       3662     478     -3184     
   ============================================
   - Hits          17666       0    -17666     
   + Misses        15166    4142    -11024     
   + Partials        848       0      -848     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [1531 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `10.50%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   40.91%   -10.51%     
   + Complexity     3271     2534      -737     
   =============================================
     Files           878      880        +2     
     Lines         21765    21742       -23     
     Branches       2087     2083        -4     
   =============================================
   - Hits          11191     8896     -2295     
   - Misses         9680    12196     +2516     
   + Partials        894      650      -244     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [194 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   51.11%   -0.30%     
   + Complexity     3271     3255      -16     
   ============================================
     Files           878      880       +2     
     Lines         21765    21740      -25     
     Branches       2087     2085       -2     
   ============================================
   - Hits          11191    11113      -78     
   - Misses         9680     9725      +45     
   - Partials        894      902       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [30 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `21.56%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   29.85%   -21.57%     
   + Complexity     3271     1921     -1350     
   =============================================
     Files           878      860       -18     
     Lines         21765    21157      -608     
     Branches       2087     2030       -57     
   =============================================
   - Hits          11191     6316     -4875     
   - Misses         9680    14370     +4690     
   + Partials        894      471      -423     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [328 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `6.58%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   44.83%   -6.59%     
   + Complexity     3271     2966     -305     
   ============================================
     Files           878      879       +1     
     Lines         21765    21615     -150     
     Branches       2087     2066      -21     
   ============================================
   - Hits          11191     9691    -1500     
   - Misses         9680    11110    +1430     
   + Partials        894      814      -80     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [122 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `17.86%`.
   > The diff coverage is `0.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.36%   34.50%   -17.87%     
   + Complexity     3321     2160     -1161     
   =============================================
     Files           879      879               
     Lines         21843    21520      -323     
     Branches       2093     2026       -67     
   =============================================
   - Hits          11439     7425     -4014     
   - Misses         9493    13584     +4091     
   + Partials        911      511      -400     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `50.00% <ø> (-33.34%)` | `9.00 <0.00> (-1.00)` | |
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `23.52% <0.00%> (-64.71%)` | `2.00 <0.00> (-6.00)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [276 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.59%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.01%   +0.59%     
   - Complexity     3271     3295      +24     
   ============================================
     Files           878      880       +2     
     Lines         21765    21740      -25     
     Branches       2087     2085       -2     
   ============================================
   + Hits          11191    11307     +116     
   + Misses         9680     9517     -163     
   - Partials        894      916      +22     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [36 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     51.41%   0.00%   -51.42%     
   ============================================
     Files           878     169      -709     
     Lines         21765    4100    -17665     
     Branches       2087     474     -1613     
   ============================================
   - Hits          11191       0    -11191     
   + Misses         9680    4100     -5580     
   + Partials        894       0      -894     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [835 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `4.01%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   48.43%   -4.02%     
   + Complexity     3320     3161     -159     
   ============================================
     Files          1568      887     -681     
     Lines         33680    21961   -11719     
     Branches       3662     2103    -1559     
   ============================================
   - Hits          17666    10637    -7029     
   + Misses        15166    10451    -4715     
   - Partials        848      873      +25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1087 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `11.65%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   39.76%   -11.66%     
   + Complexity     3271     2460      -811     
   =============================================
     Files           878      880        +2     
     Lines         21765    21790       +25     
     Branches       2087     2087               
   =============================================
   - Hits          11191     8665     -2526     
   - Misses         9680    12480     +2800     
   + Partials        894      645      -249     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [218 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/596c85fd5c3aa64d7f6918f1be87da49d4dbe438?el=desc) will **decrease** coverage by `4.12%`.
   > The diff coverage is `57.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.38%   48.25%   -4.13%     
   + Complexity     3304     3116     -188     
   ============================================
     Files          1562      887     -675     
     Lines         33446    21816   -11630     
     Branches       3662     2090    -1572     
   ============================================
   - Hits          17520    10528    -6992     
   + Misses        15094    10423    -4671     
   - Partials        832      865      +33     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...ovider/handler/grpc/BrowserPerfServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvZ3JwYy9Ccm93c2VyUGVyZlNlcnZpY2VIYW5kbGVyLmphdmE=) | `51.85% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | [.../rest/BrowserErrorLogReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRMaXN0U2VydmxldEhhbmRsZXIuamF2YQ==) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | |
   | [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <30.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...dler/rest/BrowserPerfDataReportServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyUGVyZkRhdGFSZXBvcnRTZXJ2bGV0SGFuZGxlci5qYXZh) | `38.70% <38.70%> (ø)` | `3.00 <3.00> (?)` | |
   | [.../rest/BrowserErrorLogReportBaseServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRCYXNlU2VydmxldEhhbmRsZXIuamF2YQ==) | `45.83% <45.83%> (ø)` | `2.00 <2.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | ... and [1108 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.66%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.08%   +0.66%     
   - Complexity     3271     3288      +17     
   ============================================
     Files           878      882       +4     
     Lines         21765    21762       -3     
     Branches       2087     2084       -3     
   ============================================
   + Hits          11191    11335     +144     
   + Misses         9680     9515     -165     
   - Partials        894      912      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [34 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `0.14%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   52.22%   -0.15%     
   - Complexity     3321     3328       +7     
   ============================================
     Files           879      885       +6     
     Lines         21843    21964     +121     
     Branches       2093     2103      +10     
   ============================================
   + Hits          11439    11470      +31     
   - Misses         9493     9580      +87     
   - Partials        911      914       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **increase** coverage by `2.57%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     49.53%   52.11%   +2.57%     
   - Complexity     3190     3328     +138     
   ============================================
     Files           881      889       +8     
     Lines         21863    22031     +168     
     Branches       2094     2109      +15     
   ============================================
   + Hits          10830    11481     +651     
   + Misses        10143     9629     -514     
   - Partials        890      921      +31     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [62 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `0.99%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   51.37%   -1.00%     
   + Complexity     3321     3293      -28     
   ============================================
     Files           879      885       +6     
     Lines         21843    21954     +111     
     Branches       2093     2102       +9     
   ============================================
   - Hits          11439    11278     -161     
   - Misses         9493     9778     +285     
   + Partials        911      898      -13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [41 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `52.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     52.36%   0.00%   -52.37%     
   ============================================
     Files           879     153      -726     
     Lines         21843    3748    -18095     
     Branches       2093     434     -1659     
   ============================================
   - Hits          11439       0    -11439     
   + Misses         9493    3748     -5745     
   + Partials        911       0      -911     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [848 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `2.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   54.26%   +2.84%     
   + Complexity     3271      714    -2557     
   ============================================
     Files           878      163     -715     
     Lines         21765     3907   -17858     
     Branches       2087      443    -1644     
   ============================================
   - Hits          11191     2120    -9071     
   + Misses         9680     1523    -8157     
   + Partials        894      264     -630     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
   | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
   | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `79.41% <0.00%> (-2.95%)` | `10.00% <0.00%> (-1.00%)` | |
   | [...ap/server/exporter/provider/grpc/GRPCExporter.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyLmphdmE=) | | | |
   | [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | | | |
   | [...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==) | | | |
   | [...g/oap/server/core/source/ServiceInstanceCLRGC.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUNMUkdDLmphdmE=) | | | |
   | ... and [706 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     51.41%   0.00%   -51.42%     
   ============================================
     Files           878     166      -712     
     Lines         21765    4031    -17734     
     Branches       2087     467     -1620     
   ============================================
   - Hits          11191       0    -11191     
   + Misses         9680    4031     -5649     
   + Partials        894       0      -894     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [836 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `9.28%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   42.13%   -9.29%     
   + Complexity     3271     2586     -685     
   ============================================
     Files           878      882       +4     
     Lines         21765    21820      +55     
     Branches       2087     2088       +1     
   ============================================
   - Hits          11191     9194    -1997     
   - Misses         9680    11953    +2273     
   + Partials        894      673     -221     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [187 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     51.41%   0.00%   -51.42%     
   ============================================
     Files           878     164      -714     
     Lines         21765    3989    -17776     
     Branches       2087     463     -1624     
   ============================================
   - Hits          11191       0    -11191     
   + Misses         9680    3989     -5691     
   + Partials        894       0      -894     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [838 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **decrease** coverage by `18.61%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     49.53%   30.92%   -18.62%     
   + Complexity     3190     1990     -1200     
   =============================================
     Files           881      867       -14     
     Lines         21863    21402      -461     
     Branches       2094     2053       -41     
   =============================================
   - Hits          10830     6618     -4212     
   - Misses        10143    14300     +4157     
   + Partials        890      484      -406     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [304 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `4.78%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   47.66%   -4.79%     
   + Complexity     3320     3119     -201     
   ============================================
     Files          1568      887     -681     
     Lines         33680    21989   -11691     
     Branches       3662     2108    -1554     
   ============================================
   - Hits          17666    10481    -7185     
   + Misses        15166    10641    -4525     
   - Partials        848      867      +19     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1097 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `2.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   54.26%   +2.84%     
   + Complexity     3271      714    -2557     
   ============================================
     Files           878      163     -715     
     Lines         21765     3907   -17858     
     Branches       2087      443    -1644     
   ============================================
   - Hits          11191     2120    -9071     
   + Misses         9680     1523    -8157     
   + Partials        894      264     -630     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
   | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
   | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `79.41% <0.00%> (-2.95%)` | `10.00% <0.00%> (-1.00%)` | |
   | [...server/core/analysis/metrics/MinDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Eb3VibGVNZXRyaWNzLmphdmE=) | | | |
   | [...p/server/receiver/zipkin/ZipkinReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJNb2R1bGUuamF2YQ==) | | | |
   | [...server/core/management/ui/template/UITemplate.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlLmphdmE=) | | | |
   | [.../server/library/server/jetty/JettyJsonHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2pldHR5L0pldHR5SnNvbkhhbmRsZXIuamF2YQ==) | | | |
   | ... and [706 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `20.58%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   30.82%   -20.59%     
   + Complexity     3271     1974     -1297     
   =============================================
     Files           878      854       -24     
     Lines         21765    21101      -664     
     Branches       2087     2013       -74     
   =============================================
   - Hits          11191     6505     -4686     
   - Misses         9680    14110     +4430     
   + Partials        894      486      -408     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [317 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.49%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.91%   +0.49%     
   - Complexity     3271     3294      +23     
   ============================================
     Files           878     1571     +693     
     Lines         21765    33617   +11852     
     Branches       2087     3661    +1574     
   ============================================
   + Hits          11191    17452    +6261     
   - Misses         9680    15332    +5652     
   + Partials        894      833      -61     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1071 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `13.11%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   38.29%   -13.12%     
   + Complexity     3271     2369      -902     
   =============================================
     Files           878      860       -18     
     Lines         21765    21176      -589     
     Branches       2087     2032       -55     
   =============================================
   - Hits          11191     8110     -3081     
   - Misses         9680    12460     +2780     
   + Partials        894      606      -288     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [235 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `2.15%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   50.29%   -2.16%     
   + Complexity     3320     3255      -65     
   ============================================
     Files          1568      887     -681     
     Lines         33680    22008   -11672     
     Branches       3662     2108    -1554     
   ============================================
   - Hits          17666    11070    -6596     
   + Misses        15166    10023    -5143     
   - Partials        848      915      +67     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1085 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.95%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.37%   +0.95%     
   - Complexity     3271     3319      +48     
   ============================================
     Files           878      885       +7     
     Lines         21765    21853      +88     
     Branches       2087     2096       +9     
   ============================================
   + Hits          11191    11446     +255     
   + Misses         9680     9491     -189     
   - Partials        894      916      +22     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [23 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     51.41%   0.00%   -51.42%     
   ============================================
     Files           878     155      -723     
     Lines         21765    3791    -17974     
     Branches       2087     429     -1658     
   ============================================
   - Hits          11191       0    -11191     
   + Misses         9680    3791     -5889     
   + Partials        894       0      -894     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [845 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `15.79%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   36.45%   -15.80%     
   + Complexity     3301     2304      -997     
   =============================================
     Files          1567      886      -681     
     Lines         33609    21762    -11847     
     Branches       3654     2084     -1570     
   =============================================
   - Hits          17561     7934     -9627     
   + Misses        15215    13233     -1982     
   + Partials        833      595      -238     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1162 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng merged pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

wu-sheng merged pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `0.24%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   52.20%   -0.25%     
   - Complexity     3320     3333      +13     
   ============================================
     Files          1568      889     -679     
     Lines         33680    22031   -11649     
     Branches       3662     2109    -1553     
   ============================================
   - Hits          17666    11502    -6164     
   + Misses        15166     9606    -5560     
   - Partials        848      923      +75     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1076 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `52.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     52.36%   0.00%   -52.37%     
   ============================================
     Files           879     167      -712     
     Lines         21843    4018    -17825     
     Branches       2093     457     -1636     
   ============================================
   - Hits          11439       0    -11439     
   + Misses         9493    4018     -5475     
   + Partials        911       0      -911     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [838 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `1.59%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   49.82%   -1.60%     
   + Complexity     3271     3190      -81     
   ============================================
     Files           878      879       +1     
     Lines         21765    21651     -114     
     Branches       2087     2067      -20     
   ============================================
   - Hits          11191    10787     -404     
   - Misses         9680     9973     +293     
   + Partials        894      891       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [51 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `1.68%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   50.68%   -1.69%     
   + Complexity     3321     3252      -69     
   ============================================
     Files           879      885       +6     
     Lines         21843    21954     +111     
     Branches       2093     2102       +9     
   ============================================
   - Hits          11439    11127     -312     
   - Misses         9493     9939     +446     
   + Partials        911      888      -23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [47 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.46%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.87%   +0.46%     
   - Complexity     3271     3279       +8     
   ============================================
     Files           878      882       +4     
     Lines         21765    21762       -3     
     Branches       2087     2084       -3     
   ============================================
   + Hits          11191    11290      +99     
   + Misses         9680     9569     -111     
   - Partials        894      903       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [37 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `18.66%`.
   > The diff coverage is `0.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.36%   33.70%   -18.67%     
   + Complexity     3321     2122     -1199     
   =============================================
     Files           879      879               
     Lines         21843    21520      -323     
     Branches       2093     2026       -67     
   =============================================
   - Hits          11439     7253     -4186     
   - Misses         9493    13773     +4280     
   + Partials        911      494      -417     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `50.00% <ø> (-33.34%)` | `9.00 <0.00> (-1.00)` | |
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `23.52% <0.00%> (-64.71%)` | `2.00 <0.00> (-6.00)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [285 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `21.62%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   29.79%   -21.63%     
   + Complexity     3271     1882     -1389     
   =============================================
     Files           878      856       -22     
     Lines         21765    21063      -702     
     Branches       2087     2012       -75     
   =============================================
   - Hits          11191     6276     -4915     
   - Misses         9680    14319     +4639     
   + Partials        894      468      -426     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [333 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `22.67%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   29.57%   -22.68%     
   + Complexity     3301     1886     -1415     
   =============================================
     Files          1567      863      -704     
     Lines         33609    21204    -12405     
     Branches       3654     2032     -1622     
   =============================================
   - Hits          17561     6271    -11290     
   + Misses        15215    14465      -750     
   + Partials        833      468      -365     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `21.31%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   30.09%   -21.32%     
   + Complexity     3271     1913     -1358     
   =============================================
     Files           878      854       -24     
     Lines         21765    21058      -707     
     Branches       2087     2012       -75     
   =============================================
   - Hits          11191     6338     -4853     
   - Misses         9680    14244     +4564     
   + Partials        894      476      -418     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [330 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `9.36%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   42.05%   -9.37%     
   + Complexity     3271     2578     -693     
   ============================================
     Files           878      880       +2     
     Lines         21765    21814      +49     
     Branches       2087     2088       +1     
   ============================================
   - Hits          11191     9173    -2018     
   - Misses         9680    11969    +2289     
   + Partials        894      672     -222     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [193 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `21.25%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   30.16%   -21.26%     
   + Complexity     3271     1938     -1333     
   =============================================
     Files           878      860       -18     
     Lines         21765    21157      -608     
     Branches       2087     2030       -57     
   =============================================
   - Hits          11191     6381     -4810     
   - Misses         9680    14297     +4617     
   + Partials        894      479      -415     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [319 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `11.96%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   40.49%   -11.97%     
   + Complexity     3320     2683      -637     
   =============================================
     Files          1568      866      -702     
     Lines         33680    21419    -12261     
     Branches       3662     2040     -1622     
   =============================================
   - Hits          17666     8673     -8993     
   + Misses        15166    12022     -3144     
   + Partials        848      724      -124     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1141 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `2.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   54.26%   +2.84%     
   + Complexity     3271      714    -2557     
   ============================================
     Files           878      163     -715     
     Lines         21765     3907   -17858     
     Branches       2087      443    -1644     
   ============================================
   - Hits          11191     2120    -9071     
   + Misses         9680     1523    -8157     
   + Partials        894      264     -630     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
   | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
   | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `79.41% <0.00%> (-2.95%)` | `10.00% <0.00%> (-1.00%)` | |
   | [...p/server/receiver/jaeger/JaegerReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2phZWdlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9qYWVnZXIvSmFlZ2VyUmVjZWl2ZXJNb2R1bGUuamF2YQ==) | | | |
   | [...kywalking/oap/server/core/alarm/AlarmEntrance.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1FbnRyYW5jZS5qYXZh) | | | |
   | [...tion/zookeeper/ZookeeperConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLXpvb2tlZXBlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vem9va2VlcGVyL1pvb2tlZXBlckNvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | | | |
   | [...ing/oap/server/core/profile/ProfileTaskRecord.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1JlY29yZC5qYXZh) | | | |
   | ... and [706 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `10.27%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   41.13%   -10.28%     
   + Complexity     3271     2542      -729     
   =============================================
     Files           878      880        +2     
     Lines         21765    21814       +49     
     Branches       2087     2088        +1     
   =============================================
   - Hits          11191     8974     -2217     
   - Misses         9680    12177     +2497     
   + Partials        894      663      -231     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [205 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `6.58%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   44.83%   -6.59%     
   + Complexity     3271     2965     -306     
   ============================================
     Files           878      879       +1     
     Lines         21765    21607     -158     
     Branches       2087     2051      -36     
   ============================================
   - Hits          11191     9687    -1504     
   - Misses         9680    11105    +1425     
   + Partials        894      815      -79     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [126 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.95%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.37%   +0.95%     
   - Complexity     3271     3320      +49     
   ============================================
     Files           878      882       +4     
     Lines         21765    21861      +96     
     Branches       2087     2093       +6     
   ============================================
   + Hits          11191    11449     +258     
   + Misses         9680     9493     -187     
   - Partials        894      919      +25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [31 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `1.18%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.59%   +1.18%     
   - Complexity     3271     3315      +44     
   ============================================
     Files           878      880       +2     
     Lines         21765    21740      -25     
     Branches       2087     2085       -2     
   ============================================
   + Hits          11191    11435     +244     
   + Misses         9680     9387     -293     
   - Partials        894      918      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [32 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `3.22%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   49.14%   -3.23%     
   + Complexity     3321     3171     -150     
   ============================================
     Files           879      881       +2     
     Lines         21843    21822      -21     
     Branches       2093     2066      -27     
   ============================================
   - Hits          11439    10724     -715     
   - Misses         9493    10233     +740     
   + Partials        911      865      -46     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [83 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.67%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.09%   +0.67%     
   - Complexity     3271     3290      +19     
   ============================================
     Files           878      882       +4     
     Lines         21765    21762       -3     
     Branches       2087     2084       -3     
   ============================================
   + Hits          11191    11337     +146     
   + Misses         9680     9513     -167     
   - Partials        894      912      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [33 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `8.87%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   42.53%   -8.88%     
   + Complexity     3271     2616     -655     
   ============================================
     Files           878      882       +4     
     Lines         21765    21848      +83     
     Branches       2087     2093       +6     
   ============================================
   - Hits          11191     9294    -1897     
   - Misses         9680    11875    +2195     
   + Partials        894      679     -215     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [182 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.24%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   51.16%   -0.25%     
   + Complexity     3271     3259      -12     
   ============================================
     Files           878      880       +2     
     Lines         21765    21740      -25     
     Branches       2087     2085       -2     
   ============================================
   - Hits          11191    11124      -67     
   - Misses         9680     9713      +33     
   - Partials        894      903       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [33 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `1.20%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   50.21%   -1.21%     
   + Complexity     3271     3194      -77     
   ============================================
     Files           878      877       -1     
     Lines         21765    21700      -65     
     Branches       2087     2065      -22     
   ============================================
   - Hits          11191    10897     -294     
   - Misses         9680     9914     +234     
   + Partials        894      889       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [67 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   52.30%   -0.07%     
   - Complexity     3321     3330       +9     
   ============================================
     Files           879      885       +6     
     Lines         21843    21964     +121     
     Branches       2093     2103      +10     
   ============================================
   + Hits          11439    11488      +49     
   - Misses         9493     9562      +69     
   - Partials        911      914       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [27 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `11.88%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   40.56%   -11.89%     
   + Complexity     3320     2683      -637     
   =============================================
     Files          1568      865      -703     
     Lines         33680    21380    -12300     
     Branches       3662     2039     -1623     
   =============================================
   - Hits          17666     8673     -8993     
   + Misses        15166    11983     -3183     
   + Partials        848      724      -124     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1142 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **decrease** coverage by `19.41%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     49.53%   30.11%   -19.42%     
   + Complexity     3190     1955     -1235     
   =============================================
     Files           881      867       -14     
     Lines         21863    21399      -464     
     Branches       2094     2053       -41     
   =============================================
   - Hits          10830     6445     -4385     
   - Misses        10143    14472     +4329     
   + Partials        890      482      -408     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [288 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `24.99%`.
   > The diff coverage is `0.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.36%   27.37%   -25.00%     
   + Complexity     3321     1740     -1581     
   =============================================
     Files           879      862       -17     
     Lines         21843    21012      -831     
     Branches       2093     1978      -115     
   =============================================
   - Hits          11439     5751     -5688     
   - Misses         9493    14851     +5358     
   + Partials        911      410      -501     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `50.00% <ø> (-33.34%)` | `9.00 <0.00> (-1.00)` | |
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `23.52% <0.00%> (-64.71%)` | `2.00 <0.00> (-6.00)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [356 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `1.77%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   50.59%   -1.78%     
   + Complexity     3321     3239      -82     
   ============================================
     Files           879      884       +5     
     Lines         21843    21930      +87     
     Branches       2093     2083      -10     
   ============================================
   - Hits          11439    11096     -343     
   - Misses         9493     9948     +455     
   + Partials        911      886      -25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [69 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **decrease** coverage by `15.01%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     49.53%   34.51%   -15.02%     
   + Complexity     3190     2209      -981     
   =============================================
     Files           881      869       -12     
     Lines         21863    21451      -412     
     Branches       2094     2059       -35     
   =============================================
   - Hits          10830     7404     -3426     
   - Misses        10143    13514     +3371     
   + Partials        890      533      -357     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [281 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **decrease** coverage by `49.53%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     49.53%   0.00%   -49.54%     
   ============================================
     Files           881     167      -714     
     Lines         21863    4088    -17775     
     Branches       2094     474     -1620     
   ============================================
   - Hits          10830       0    -10830     
   + Misses        10143    4088     -6055     
   + Partials        890       0      -890     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [838 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `52.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     52.36%   0.00%   -52.37%     
   ============================================
     Files           879     166      -713     
     Lines         21843    4007    -17836     
     Branches       2093     457     -1636     
   ============================================
   - Hits          11439       0    -11439     
   + Misses         9493    4007     -5486     
   + Partials        911       0      -911     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [839 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `13.98%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   38.46%   -13.99%     
   + Complexity     3320     2398      -922     
   =============================================
     Files          1568      870      -698     
     Lines         33680    21469    -12211     
     Branches       3662     2057     -1605     
   =============================================
   - Hits          17666     8258     -9408     
   + Misses        15166    12589     -2577     
   + Partials        848      622      -226     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1161 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `9.35%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   43.09%   -9.36%     
   + Complexity     3320     2825     -495     
   ============================================
     Files          1568      870     -698     
     Lines         33680    21488   -12192     
     Branches       3662     2046    -1616     
   ============================================
   - Hits          17666     9260    -8406     
   + Misses        15166    11452    -3714     
   + Partials        848      776      -72     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1130 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `7.03%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   45.42%   -7.04%     
   + Complexity     3320     2979     -341     
   ============================================
     Files          1568      870     -698     
     Lines         33680    21496   -12184     
     Branches       3662     2061    -1601     
   ============================================
   - Hits          17666     9764    -7902     
   + Misses        15166    10919    -4247     
   + Partials        848      813      -35     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1115 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `16.61%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   35.63%   -16.62%     
   + Complexity     3301     2203     -1098     
   =============================================
     Files          1567      863      -704     
     Lines         33609    21224    -12385     
     Branches       3654     2034     -1620     
   =============================================
   - Hits          17561     7563     -9998     
   + Misses        15215    13081     -2134     
   + Partials        833      580      -253     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1182 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.35%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.76%   +0.35%     
   + Complexity     3271     3270       -1     
   ============================================
     Files           878      880       +2     
     Lines         21765    21756       -9     
     Branches       2087     2084       -3     
   ============================================
   + Hits          11191    11263      +72     
   + Misses         9680     9592      -88     
   - Partials        894      901       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [48 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `5.84%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   45.57%   -5.85%     
   + Complexity     3271     3000     -271     
   ============================================
     Files           878      879       +1     
     Lines         21765    21618     -147     
     Branches       2087     2066      -21     
   ============================================
   - Hits          11191     9852    -1339     
   - Misses         9680    10951    +1271     
   + Partials        894      815      -79     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [104 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **increase** coverage by `2.67%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     49.53%   52.20%   +2.67%     
   - Complexity     3190     3333     +143     
   ============================================
     Files           881      889       +8     
     Lines         21863    22031     +168     
     Branches       2094     2109      +15     
   ============================================
   + Hits          10830    11502     +672     
   + Misses        10143     9606     -537     
   - Partials        890      923      +33     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [65 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `23.02%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   29.42%   -23.03%     
   + Complexity     3320     1895     -1425     
   =============================================
     Files          1568      867      -701     
     Lines         33680    21356    -12324     
     Branches       3662     2050     -1612     
   =============================================
   - Hits          17666     6284    -11382     
   + Misses        15166    14600      -566     
   + Partials        848      472      -376     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1205 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `20.83%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   31.61%   -20.84%     
   + Complexity     3320     2030     -1290     
   =============================================
     Files          1568      862      -706     
     Lines         33680    21281    -12399     
     Branches       3662     2028     -1634     
   =============================================
   - Hits          17666     6729    -10937     
   + Misses        15166    14062     -1104     
   + Partials        848      490      -358     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1197 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `16.11%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   35.29%   -16.12%     
   + Complexity     3271     2259     -1012     
   =============================================
     Files           878      875        -3     
     Lines         21765    21596      -169     
     Branches       2087     2059       -28     
   =============================================
   - Hits          11191     7623     -3568     
   - Misses         9680    13421     +3741     
   + Partials        894      552      -342     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [261 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `15.69%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   36.55%   -15.70%     
   + Complexity     3301     2304      -997     
   =============================================
     Files          1567      880      -687     
     Lines         33609    21703    -11906     
     Branches       3654     2080     -1574     
   =============================================
   - Hits          17561     7934     -9627     
   + Misses        15215    13174     -2041     
   + Partials        833      595      -238     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1166 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `4.27%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   48.17%   -4.28%     
   + Complexity     3320     3156     -164     
   ============================================
     Files          1568      887     -681     
     Lines         33680    21989   -11691     
     Branches       3662     2108    -1554     
   ============================================
   - Hits          17666    10594    -7072     
   + Misses        15166    10517    -4649     
   - Partials        848      878      +30     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1093 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `2.57%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   49.79%   -2.58%     
   + Complexity     3321     3205     -116     
   ============================================
     Files           879      883       +4     
     Lines         21843    21904      +61     
     Branches       2093     2083      -10     
   ============================================
   - Hits          11439    10907     -532     
   - Misses         9493    10115     +622     
   + Partials        911      882      -29     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [76 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.50%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.92%   +0.50%     
   - Complexity     3271     3294      +23     
   ============================================
     Files           878     1571     +693     
     Lines         21765    33609   +11844     
     Branches       2087     3661    +1574     
   ============================================
   + Hits          11191    17452    +6261     
   - Misses         9680    15324    +5644     
   + Partials        894      833      -61     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1073 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `12.17%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.36%   40.19%   -12.18%     
   + Complexity     3321     2515      -806     
   =============================================
     Files           879      881        +2     
     Lines         21843    21822       -21     
     Branches       2093     2066       -27     
   =============================================
   - Hits          11439     8772     -2667     
   - Misses         9493    12420     +2927     
   + Partials        911      630      -281     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [203 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   52.33%   -0.04%     
   - Complexity     3321     3330       +9     
   ============================================
     Files           879     1576     +697     
     Lines         21843    33749   +11906     
     Branches       2093     3664    +1571     
   ============================================
   + Hits          11439    17661    +6222     
   - Misses         9493    15256    +5763     
   + Partials        911      832      -79     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1076 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `15.78%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   36.46%   -15.79%     
   + Complexity     3301     2304      -997     
   =============================================
     Files          1567      884      -683     
     Lines         33609    21756    -11853     
     Branches       3654     2084     -1570     
   =============================================
   - Hits          17561     7934     -9627     
   + Misses        15215    13227     -1988     
   + Partials        833      595      -238     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1164 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.43%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.85%   +0.43%     
   - Complexity     3271     3294      +23     
   ============================================
     Files           878     1572     +694     
     Lines         21765    33656   +11891     
     Branches       2087     3662    +1575     
   ============================================
   + Hits          11191    17452    +6261     
   - Misses         9680    15371    +5691     
   + Partials        894      833      -61     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1070 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `1.20%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.62%   +1.20%     
   - Complexity     3271     3316      +45     
   ============================================
     Files           878      880       +2     
     Lines         21765    21740      -25     
     Branches       2087     2085       -2     
   ============================================
   + Hits          11191    11441     +250     
   + Misses         9680     9381     -299     
   - Partials        894      918      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [33 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.43%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.85%   +0.43%     
   - Complexity     3271     3294      +23     
   ============================================
     Files           878     1572     +694     
     Lines         21765    33656   +11891     
     Branches       2087     3662    +1575     
   ============================================
   + Hits          11191    17452    +6261     
   - Misses         9680    15371    +5691     
   + Partials        894      833      -61     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1070 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `14.10%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   38.34%   -14.11%     
   + Complexity     3320     2442      -878     
   =============================================
     Files          1568      887      -681     
     Lines         33680    21948    -11732     
     Branches       3662     2103     -1559     
   =============================================
   - Hits          17666     8417     -9249     
   + Misses        15166    12904     -2262     
   + Partials        848      627      -221     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1151 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `9.32%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   42.08%   -9.33%     
   + Complexity     3271     2586     -685     
   ============================================
     Files           878      880       +2     
     Lines         21765    21756       -9     
     Branches       2087     2084       -3     
   ============================================
   - Hits          11191     9157    -2034     
   - Misses         9680    11933    +2253     
   + Partials        894      666     -228     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [182 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.50%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.92%   +0.50%     
   - Complexity     3271     3294      +23     
   ============================================
     Files           878     1571     +693     
     Lines         21765    33609   +11844     
     Branches       2087     3661    +1574     
   ============================================
   + Hits          11191    17452    +6261     
   - Misses         9680    15324    +5644     
   + Partials        894      833      -61     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1073 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `17.95%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   33.46%   -17.96%     
   + Complexity     3271     2080     -1191     
   =============================================
     Files           878      856       -22     
     Lines         21765    21072      -693     
     Branches       2087     2012       -75     
   =============================================
   - Hits          11191     7051     -4140     
   - Misses         9680    13507     +3827     
   + Partials        894      514      -380     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [304 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.85%`.
   > The diff coverage is `64.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.27%   +0.85%     
   - Complexity     3271     3320      +49     
   ============================================
     Files           878     1572     +694     
     Lines         21765    33654   +11889     
     Branches       2087     3659    +1572     
   ============================================
   + Hits          11191    17591    +6400     
   - Misses         9680    15231    +5551     
   + Partials        894      832      -62     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `62.50% <62.50%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `64.70% <64.70%> (ø)` | `5.00 <5.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `81.81% <81.81%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1070 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/596c85fd5c3aa64d7f6918f1be87da49d4dbe438?el=desc) will **decrease** coverage by `3.51%`.
   > The diff coverage is `57.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.38%   48.86%   -3.52%     
   + Complexity     3304     3173     -131     
   ============================================
     Files          1562      887     -675     
     Lines         33446    21840   -11606     
     Branches       3662     2091    -1571     
   ============================================
   - Hits          17520    10673    -6847     
   + Misses        15094    10292    -4802     
   - Partials        832      875      +43     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...ovider/handler/grpc/BrowserPerfServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvZ3JwYy9Ccm93c2VyUGVyZlNlcnZpY2VIYW5kbGVyLmphdmE=) | `51.85% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | [.../rest/BrowserErrorLogReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRMaXN0U2VydmxldEhhbmRsZXIuamF2YQ==) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | |
   | [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <30.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...dler/rest/BrowserPerfDataReportServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyUGVyZkRhdGFSZXBvcnRTZXJ2bGV0SGFuZGxlci5qYXZh) | `38.70% <38.70%> (ø)` | `3.00 <3.00> (?)` | |
   | [.../rest/BrowserErrorLogReportBaseServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRCYXNlU2VydmxldEhhbmRsZXIuamF2YQ==) | `45.83% <45.83%> (ø)` | `2.00 <2.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | ... and [1104 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.16%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   51.25%   -0.17%     
     Complexity     3271     3271              
   ============================================
     Files           878      882       +4     
     Lines         21765    21742      -23     
     Branches       2087     2078       -9     
   ============================================
   - Hits          11191    11143      -48     
   - Misses         9680     9686       +6     
   - Partials        894      913      +19     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [39 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `16.47%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   35.77%   -16.48%     
   + Complexity     3301     2256     -1045     
   =============================================
     Files          1567      880      -687     
     Lines         33609    21703    -11906     
     Branches       3654     2080     -1574     
   =============================================
   - Hits          17561     7764     -9797     
   + Misses        15215    13347     -1868     
   + Partials        833      592      -241     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1172 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `9.41%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   42.00%   -9.42%     
   + Complexity     3271     2577     -694     
   ============================================
     Files           878      880       +2     
     Lines         21765    21814      +49     
     Branches       2087     2088       +1     
   ============================================
   - Hits          11191     9162    -2029     
   - Misses         9680    11981    +2301     
   + Partials        894      671     -223     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [194 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `52.45%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     52.45%   0.00%   -52.46%     
   ============================================
     Files          1568     166     -1402     
     Lines         33680    4001    -29679     
     Branches       3662     463     -3199     
   ============================================
   - Hits          17666       0    -17666     
   + Misses        15166    4001    -11165     
   + Partials        848       0      -848     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [1535 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **increase** coverage by `2.67%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     49.53%   52.20%   +2.67%     
   - Complexity     3190     3333     +143     
   ============================================
     Files           881      889       +8     
     Lines         21863    22031     +168     
     Branches       2094     2109      +15     
   ============================================
   + Hits          10830    11502     +672     
   + Misses        10143     9606     -537     
   - Partials        890      923      +33     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [65 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...6854ee3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `2.80%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   48.61%   -2.81%     
   + Complexity     3271     3136     -135     
   ============================================
     Files           878      879       +1     
     Lines         21765    21637     -128     
     Branches       2087     2066      -21     
   ============================================
   - Hits          11191    10518     -673     
   - Misses         9680    10245     +565     
   + Partials        894      874      -20     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [64 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `5.83%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   45.57%   -5.84%     
   + Complexity     3271     3004     -267     
   ============================================
     Files           878      875       -3     
     Lines         21765    21622     -143     
     Branches       2087     2061      -26     
   ============================================
   - Hits          11191     9855    -1336     
   - Misses         9680    10953    +1273     
   + Partials        894      814      -80     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [115 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.52%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.94%   +0.52%     
   - Complexity     3271     3290      +19     
   ============================================
     Files           878      885       +7     
     Lines         21765    21825      +60     
     Branches       2087     2091       +4     
   ============================================
   + Hits          11191    11337     +146     
   + Misses         9680     9576     -104     
   - Partials        894      912      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [30 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `2.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   54.28%   +2.86%     
   + Complexity     3271      715    -2556     
   ============================================
     Files           878      163     -715     
     Lines         21765     3907   -17858     
     Branches       2087      443    -1644     
   ============================================
   - Hits          11191     2121    -9070     
   + Misses         9680     1523    -8157     
   + Partials        894      263     -631     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
   | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
   | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...server/storage/plugin/jdbc/h2/dao/H2RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUmVjb3JkREFPLmphdmE=) | | | |
   | [.../aop/server/receiver/jaeger/JaegerGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2phZWdlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9qYWVnZXIvSmFlZ2VyR1JQQ0hhbmRsZXIuamF2YQ==) | | | |
   | [...ver/library/module/DuplicateProviderException.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL0R1cGxpY2F0ZVByb3ZpZGVyRXhjZXB0aW9uLmphdmE=) | | | |
   | [...erver/storage/plugin/jdbc/h2/dao/H2MetricsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc0RBTy5qYXZh) | | | |
   | [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
   | ... and [705 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.94%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   50.46%   -0.95%     
   + Complexity     3271     3213      -58     
   ============================================
     Files           878      879       +1     
     Lines         21765    21651     -114     
     Branches       2087     2067      -20     
   ============================================
   - Hits          11191    10927     -264     
   - Misses         9680     9822     +142     
   - Partials        894      902       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     51.41%   0.00%   -51.42%     
   ============================================
     Files           878     166      -712     
     Lines         21765    4001    -17764     
     Branches       2087     463     -1624     
   ============================================
   - Hits          11191       0    -11191     
   + Misses         9680    4001     -5679     
   + Partials        894       0      -894     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [838 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **decrease** coverage by `18.18%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     49.53%   31.34%   -18.19%     
   + Complexity     3190     2020     -1170     
   =============================================
     Files           881      867       -14     
     Lines         21863    21430      -433     
     Branches       2094     2058       -36     
   =============================================
   - Hits          10830     6718     -4112     
   - Misses        10143    14222     +4079     
   + Partials        890      490      -400     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [309 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `11.57%`.
   > The diff coverage is `0.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   39.84%   -11.58%     
   + Complexity     3271     2673      -598     
   =============================================
     Files           878      877        -1     
     Lines         21765    21423      -342     
     Branches       2087     2017       -70     
   =============================================
   - Hits          11191     8535     -2656     
   - Misses         9680    12193     +2513     
   + Partials        894      695      -199     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `50.00% <ø> (-33.34%)` | `9.00 <0.00> (-1.00)` | |
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `23.52% <0.00%> (-64.71%)` | `2.00 <0.00> (-6.00)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [177 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.52%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.94%   +0.52%     
   - Complexity     3271     3290      +19     
   ============================================
     Files           878      885       +7     
     Lines         21765    21825      +60     
     Branches       2087     2091       +4     
   ============================================
   + Hits          11191    11337     +146     
   + Misses         9680     9576     -104     
   - Partials        894      912      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [30 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.47%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   51.89%   +0.47%     
   - Complexity     3271     3296      +25     
   ============================================
     Files           878      882       +4     
     Lines         21765    21767       +2     
     Branches       2087     2079       -8     
   ============================================
   + Hits          11191    11296     +105     
   + Misses         9680     9558     -122     
   - Partials        894      913      +19     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [31 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1473c04d3e0973d08e4e478dbbccaa3873377e7c?el=desc) will **decrease** coverage by `18.20%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     49.53%   31.33%   -18.21%     
   + Complexity     3190     2020     -1170     
   =============================================
     Files           881      869       -12     
     Lines         21863    21441      -422     
     Branches       2094     2058       -36     
   =============================================
   - Hits          10830     6718     -4112     
   - Misses        10143    14233     +4090     
   + Partials        890      490      -400     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [307 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [1473c04...527c5e1](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `3.41%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   48.95%   -3.42%     
   + Complexity     3321     3171     -150     
   ============================================
     Files           879      883       +4     
     Lines         21843    21904      +61     
     Branches       2093     2083      -10     
   ============================================
   - Hits          11439    10724     -715     
   - Misses         9493    10315     +822     
   + Partials        911      865      -46     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [81 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `0.17%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   52.18%   -0.18%     
   - Complexity     3321     3325       +4     
   ============================================
     Files           879      885       +6     
     Lines         21843    21964     +121     
     Branches       2093     2103      +10     
   ============================================
   + Hits          11439    11463      +24     
   - Misses         9493     9587      +94     
   - Partials        911      914       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [31 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `14.91%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     51.41%   36.49%   -14.92%     
   + Complexity     3271     2345      -926     
   =============================================
     Files           878      875        -3     
     Lines         21765    21622      -143     
     Branches       2087     2061       -26     
   =============================================
   - Hits          11191     7892     -3299     
   - Misses         9680    13151     +3471     
   + Partials        894      579      -315     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [242 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.90%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.32%   +0.90%     
   - Complexity     3271     3316      +45     
   ============================================
     Files           878      882       +4     
     Lines         21765    21861      +96     
     Branches       2087     2093       +6     
   ============================================
   + Hits          11191    11438     +247     
   + Misses         9680     9505     -175     
   - Partials        894      918      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `5.61%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   46.84%   -5.62%     
   + Complexity     3320     3027     -293     
   ============================================
     Files          1568      870     -698     
     Lines         33680    21496   -12184     
     Branches       3662     2061    -1601     
   ============================================
   - Hits          17666    10069    -7597     
   + Misses        15166    10581    -4585     
   + Partials        848      846       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1112 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `2.88%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   48.53%   -2.89%     
   + Complexity     3271     3129     -142     
   ============================================
     Files           878      879       +1     
     Lines         21765    21637     -128     
     Branches       2087     2066      -21     
   ============================================
   - Hits          11191    10501     -690     
   - Misses         9680    10261     +581     
   + Partials        894      875      -19     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [67 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/596c85fd5c3aa64d7f6918f1be87da49d4dbe438?el=desc) will **decrease** coverage by `0.63%`.
   > The diff coverage is `57.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.38%   51.75%   -0.64%     
   - Complexity     3304     3306       +2     
   ============================================
     Files          1562      887     -675     
     Lines         33446    21876   -11570     
     Branches       3662     2092    -1570     
   ============================================
   - Hits          17520    11321    -6199     
   + Misses        15094     9641    -5453     
   - Partials        832      914      +82     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...ovider/handler/grpc/BrowserPerfServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvZ3JwYy9Ccm93c2VyUGVyZlNlcnZpY2VIYW5kbGVyLmphdmE=) | `51.85% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | [.../rest/BrowserErrorLogReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRMaXN0U2VydmxldEhhbmRsZXIuamF2YQ==) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | |
   | [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <30.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...dler/rest/BrowserPerfDataReportServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyUGVyZkRhdGFSZXBvcnRTZXJ2bGV0SGFuZGxlci5qYXZh) | `38.70% <38.70%> (ø)` | `3.00 <3.00> (?)` | |
   | [.../rest/BrowserErrorLogReportBaseServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRCYXNlU2VydmxldEhhbmRsZXIuamF2YQ==) | `45.83% <45.83%> (ø)` | `2.00 <2.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | ... and [1091 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `51.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     51.41%   0.00%   -51.42%     
   ============================================
     Files           878     159      -719     
     Lines         21765    3921    -17844     
     Branches       2087     456     -1631     
   ============================================
   - Hits          11191       0    -11191     
   + Misses         9680    3921     -5759     
   + Partials        894       0      -894     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [842 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `52.45%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     52.45%   0.00%   -52.46%     
   ============================================
     Files          1568     157     -1411     
     Lines         33680    3845    -29835     
     Branches       3662     445     -3217     
   ============================================
   - Hits          17666       0    -17666     
   + Misses        15166    3845    -11321     
   + Partials        848       0      -848     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1536 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   52.28%   -0.08%     
   - Complexity     3321     3330       +9     
   ============================================
     Files           879      887       +8     
     Lines         21843    21970     +127     
     Branches       2093     2103      +10     
   ============================================
   + Hits          11439    11488      +49     
   - Misses         9493     9568      +75     
   - Partials        911      914       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [25 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `0.11%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   52.25%   -0.12%     
   - Complexity     3321     3329       +8     
   ============================================
     Files           879      885       +6     
     Lines         21843    21964     +121     
     Branches       2093     2103      +10     
   ============================================
   + Hits          11439    11477      +38     
   - Misses         9493     9574      +81     
   - Partials        911      913       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `7.01%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   45.43%   -7.02%     
   + Complexity     3320     2978     -342     
   ============================================
     Files          1568      870     -698     
     Lines         33680    21488   -12192     
     Branches       3662     2046    -1616     
   ============================================
   - Hits          17666     9763    -7903     
   + Misses        15166    10912    -4254     
   + Partials        848      813      -35     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1116 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `13.89%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.45%   38.55%   -13.90%     
   + Complexity     3320     2451      -869     
   =============================================
     Files          1568      887      -681     
     Lines         33680    21948    -11732     
     Branches       3662     2103     -1559     
   =============================================
   - Hits          17666     8463     -9203     
   + Misses        15166    12849     -2317     
   + Partials        848      636      -212     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1150 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `2.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   54.26%   +2.84%     
   + Complexity     3271      714    -2557     
   ============================================
     Files           878      163     -715     
     Lines         21765     3907   -17858     
     Branches       2087      443    -1644     
   ============================================
   - Hits          11191     2120    -9071     
   + Misses         9680     1523    -8157     
   + Partials        894      264     -630     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
   | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
   | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `79.41% <0.00%> (-2.95%)` | `10.00% <0.00%> (-1.00%)` | |
   | [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | | | |
   | [...ing/oap/server/core/source/ScopeDefaultColumn.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1Njb3BlRGVmYXVsdENvbHVtbi5qYXZh) | | | |
   | [...oap/server/receiver/envoy/als/ServiceMetaInfo.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1NlcnZpY2VNZXRhSW5mby5qYXZh) | | | |
   | [...king/oap/server/core/remote/selector/Selector.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL3NlbGVjdG9yL1NlbGVjdG9yLmphdmE=) | | | |
   | ... and [706 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `0.86%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   52.28%   +0.86%     
   - Complexity     3271     3319      +48     
   ============================================
     Files           878      886       +8     
     Lines         21765    21892     +127     
     Branches       2087     2097      +10     
   ============================================
   + Hits          11191    11446     +255     
   + Misses         9680     9530     -150     
   - Partials        894      916      +22     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [22 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...df90366](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `9.44%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   41.97%   -9.45%     
   + Complexity     3271     2576     -695     
   ============================================
     Files           878      880       +2     
     Lines         21765    21814      +49     
     Branches       2087     2088       +1     
   ============================================
   - Hits          11191     9156    -2035     
   - Misses         9680    11987    +2307     
   + Partials        894      671     -223     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [195 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `15.78%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   36.46%   -15.79%     
   + Complexity     3301     2304      -997     
   =============================================
     Files          1567      884      -683     
     Lines         33609    21756    -11853     
     Branches       3654     2084     -1570     
   =============================================
   - Hits          17561     7934     -9627     
   + Misses        15215    13227     -1988     
   + Partials        833      595      -238     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1164 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `22.71%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   29.53%   -22.72%     
   + Complexity     3301     1882     -1419     
   =============================================
     Files          1567      860      -707     
     Lines         33609    21153    -12456     
     Branches       3654     2029     -1625     
   =============================================
   - Hits          17561     6247    -11314     
   + Misses        15215    14435      -780     
   + Partials        833      471      -362     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1210 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.18%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   51.23%   -0.19%     
     Complexity     3271     3271              
   ============================================
     Files           878      882       +4     
     Lines         21765    21750      -15     
     Branches       2087     2078       -9     
   ============================================
   - Hits          11191    11143      -48     
   - Misses         9680     9694      +14     
   - Partials        894      913      +19     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [38 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9143f1342d5cbdab1876d39006e7d8d5743d56a6?el=desc) will **decrease** coverage by `15.71%`.
   > The diff coverage is `53.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5431       +/-   ##
   =============================================
   - Coverage     52.25%   36.53%   -15.72%     
   + Complexity     3301     2304      -997     
   =============================================
     Files          1567      882      -685     
     Lines         33609    21714    -11895     
     Branches       3654     2080     -1574     
   =============================================
   - Hits          17561     7934     -9627     
   + Misses        15215    13185     -2030     
   + Partials        833      595      -238     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-75.68%)` | `0.00 <0.00> (-12.00)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1166 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [9143f13...51eb03a](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **increase** coverage by `2.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   + Coverage     51.41%   54.28%   +2.86%     
   + Complexity     3271      715    -2556     
   ============================================
     Files           878      163     -715     
     Lines         21765     3907   -17858     
     Branches       2087      443    -1644     
   ============================================
   - Hits          11191     2121    -9070     
   + Misses         9680     1523    -8157     
   + Partials        894      263     -631     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
   | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
   | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...che/skywalking/oap/server/core/source/Segment.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlZ21lbnQuamF2YQ==) | | | |
   | [...re/analysis/metrics/expression/LessEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xlc3NFcXVhbE1hdGNoLmphdmE=) | | | |
   | [...p/server/core/profile/analyze/ProfileAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVBbmFseXplci5qYXZh) | | | |
   | [.../server/core/cluster/ServiceRegisterException.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9TZXJ2aWNlUmVnaXN0ZXJFeGNlcHRpb24uamF2YQ==) | | | |
   | [...rver/cluster/plugin/kubernetes/UidEnvSupplier.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvVWlkRW52U3VwcGxpZXIuamF2YQ==) | | | |
   | ... and [705 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...868f4e3](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15b0068fdf8df2c610abc58dd763679ca1a7f22b?el=desc) will **decrease** coverage by `0.22%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     51.41%   51.18%   -0.23%     
   + Complexity     3271     3252      -19     
   ============================================
     Files           878      875       -3     
     Lines         21765    21688      -77     
     Branches       2087     2081       -6     
   ============================================
   - Hits          11191    11102      -89     
   - Misses         9680     9685       +5     
   - Partials        894      901       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [53 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [15b0068...0e72706](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `1.67%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.36%   50.69%   -1.68%     
   + Complexity     3321     3251      -70     
   ============================================
     Files           879      885       +6     
     Lines         21843    21946     +103     
     Branches       2093     2087       -6     
   ============================================
   - Hits          11439    11126     -313     
   - Misses         9493     9932     +439     
   + Partials        911      888      -23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `1.46%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5431      +/-   ##
   ============================================
   - Coverage     52.45%   50.99%   -1.47%     
   + Complexity     3320     3277      -43     
   ============================================
     Files          1568      887     -681     
     Lines         33680    22025   -11655     
     Branches       3662     2109    -1553     
   ============================================
   - Hits          17666    11231    -6435     
   + Misses        15166     9875    -5291     
   - Partials        848      919      +71     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
   | [...emetry/prometheus/PrometheusTelemetryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c1RlbGVtZXRyeVByb3ZpZGVyLmphdmE=) | `88.23% <50.00%> (ø)` | `8.00 <0.00> (ø)` | |
   | [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <61.76%> (ø)` | `5.00 <5.00> (?)` | |
   | [...ver/fetcher/prometheus/http/HttpClientHandler.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRIYW5kbGVyLmphdmE=) | `68.75% <68.75%> (ø)` | `5.00 <5.00> (?)` | |
   | [...y/prometheus/httpserver/HttpServerInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySW5pdGlhbGl6ZXIuamF2YQ==) | `71.42% <71.42%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...fetcher/prometheus/http/HttpClientInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnRJbml0aWFsaXplci5qYXZh) | `81.81% <81.81%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `82.35% <82.35%> (ø)` | `2.00 <2.00> (?)` | |
   | [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `85.71% <85.71%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [1084 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0e132685e6900c4d985430e03e7b61905ee4a2ef?el=desc) will **decrease** coverage by `52.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     52.36%   0.00%   -52.37%     
   ============================================
     Files           879     162      -717     
     Lines         21843    3902    -17941     
     Branches       2093     446     -1647     
   ============================================
   - Hits          11439       0    -11439     
   + Misses         9493    3902     -5591     
   + Partials        911       0      -911     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [843 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [0e13268...ffbc260](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

Posted by GitBox <gi...@apache.org>.

codecov[bot] edited a comment on pull request #5431:
URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report
   > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f4ed3c7deed2ef7664d7c7114b9896281787553?el=desc) will **decrease** coverage by `52.45%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5431/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #5431       +/-   ##
   ============================================
   - Coverage     52.45%   0.00%   -52.46%     
   ============================================
     Files          1568     164     -1404     
     Lines         33680    3989    -29691     
     Branches       3662     463     -3199     
   ============================================
   - Hits          17666       0    -17666     
   + Misses        15166    3989    -11177     
   + Partials        848       0      -848     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [1535 more](https://codecov.io/gh/apache/skywalking/pull/5431/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=footer). Last update [4f4ed3c...3105836](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org