You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "boneanxs (via GitHub)" <gi...@apache.org> on 2023/05/09 03:47:19 UTC

[GitHub] [hudi] boneanxs opened a new pull request, #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

boneanxs opened a new pull request, #8669:
URL: https://github.com/apache/hudi/pull/8669

   ### Change Logs
   
   _Describe context and summary for this change. Highlight if any code was copied._
   
    Rebase IncrementalRelation over HoodieBaseRelation
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   None.
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   none.
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] yihua commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1563249411

   Hey @boneanxs no worries!  I guess my PR is not fully reviewed and it's left behind.  Should I apply the difference on #6045 and close this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] boneanxs commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1560809922

   > Is this a duplicate of https://github.com/apache/hudi/pull/6045?
   
   @yihua Oops, nearly same, looks the only difference is this pr only push down partition filters if it's a fullTableScan(Keep the consistent behavior with `MergeOnReadIncrementalRelation`)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1539373231

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b8fd1cd5d56d58fc52d334a54e326c405fadf53 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] boneanxs commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1563714652

   > I guess my PR is not fully reviewed and it's left behind. Should I apply the difference on https://github.com/apache/hudi/pull/6045 and close this one?
   
   Yea, sure, let me close it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1539984536

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b8fd1cd5d56d58fc52d334a54e326c405fadf53 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1545056608

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b8fd1cd5d56d58fc52d334a54e326c405fadf53 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966) 
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * 9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1547116474

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031",
       "triggerID" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17036",
       "triggerID" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "triggerType" : "PUSH"
     }, {
       "hash" : "530990d2ada5b8c33d31f8d45284e9038b2df719",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17065",
       "triggerID" : "530990d2ada5b8c33d31f8d45284e9038b2df719",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * d2f1d265394f8a6fa33f96577704af6f8422e996 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17036) 
   * 530990d2ada5b8c33d31f8d45284e9038b2df719 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17065) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1547222193

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031",
       "triggerID" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17036",
       "triggerID" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "triggerType" : "PUSH"
     }, {
       "hash" : "530990d2ada5b8c33d31f8d45284e9038b2df719",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17065",
       "triggerID" : "530990d2ada5b8c33d31f8d45284e9038b2df719",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * 530990d2ada5b8c33d31f8d45284e9038b2df719 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17065) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1545098262

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031",
       "triggerID" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * 9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030) 
   * b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1545371849

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031",
       "triggerID" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17036",
       "triggerID" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031) 
   * d2f1d265394f8a6fa33f96577704af6f8422e996 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17036) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1545060546

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * 9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030) 
   * b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] boneanxs commented on a diff in pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs commented on code in PR #8669:
URL: https://github.com/apache/hudi/pull/8669#discussion_r1188092438


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/IncrementalRelation.scala:
##########
@@ -17,281 +17,82 @@
 
 package org.apache.hudi
 
-import org.apache.avro.Schema
-import org.apache.hadoop.fs.{GlobPattern, Path}
-import org.apache.hudi.HoodieBaseRelation.isSchemaEvolutionEnabledOnRead
-import org.apache.hudi.client.common.HoodieSparkEngineContext
-import org.apache.hudi.client.utils.SparkInternalSchemaConverter
-import org.apache.hudi.common.fs.FSUtils
-import org.apache.hudi.common.model.{HoodieCommitMetadata, HoodieFileFormat, HoodieRecord, HoodieReplaceCommitMetadata}
-import org.apache.hudi.common.table.timeline.{HoodieInstant, HoodieTimeline}
-import org.apache.hudi.common.table.{HoodieTableMetaClient, TableSchemaResolver}
-import org.apache.hudi.common.util.{HoodieTimer, InternalSchemaCache}
-import org.apache.hudi.config.HoodieWriteConfig
-import org.apache.hudi.exception.HoodieException
-import org.apache.hudi.internal.schema.InternalSchema
-import org.apache.hudi.internal.schema.utils.SerDeHelper
-import org.apache.hudi.table.HoodieSparkTable
-import org.apache.spark.api.java.JavaSparkContext
+import org.apache.hudi.common.table.timeline.HoodieTimeline
+import org.apache.hudi.common.table.view.HoodieTableFileSystemView
+import org.apache.hudi.common.table.HoodieTableMetaClient
+import org.apache.hudi.hadoop.utils.HoodieInputFormatUtils.getWritePartitionPaths
 import org.apache.spark.rdd.RDD
-import org.apache.spark.sql.execution.datasources.parquet.HoodieParquetFileFormat
-import org.apache.spark.sql.sources.{BaseRelation, TableScan}
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.expressions.Expression
+import org.apache.spark.sql.sources.Filter
 import org.apache.spark.sql.types.StructType
-import org.apache.spark.sql.{DataFrame, Row, SQLContext}
-import org.slf4j.LoggerFactory
+import org.apache.spark.sql.SQLContext
 
-import scala.collection.JavaConversions._
-import scala.collection.mutable
+import scala.collection.JavaConverters._
 
 /**
  * Relation, that implements the Hoodie incremental view.
  *
  * Implemented for Copy_on_write storage.
- * TODO: rebase w/ HoodieBaseRelation HUDI-5362
  *
  */
-class IncrementalRelation(val sqlContext: SQLContext,
-                          val optParams: Map[String, String],
-                          val userSchema: Option[StructType],
-                          val metaClient: HoodieTableMetaClient) extends BaseRelation with TableScan {
-
-  private val log = LoggerFactory.getLogger(classOf[IncrementalRelation])
-
-  val skeletonSchema: StructType = HoodieSparkUtils.getMetaSchema
-  private val basePath = metaClient.getBasePathV2
-  // TODO : Figure out a valid HoodieWriteConfig
-  private val hoodieTable = HoodieSparkTable.create(HoodieWriteConfig.newBuilder().withPath(basePath.toString).build(),
-    new HoodieSparkEngineContext(new JavaSparkContext(sqlContext.sparkContext)),
-    metaClient)
-  private val commitTimeline = hoodieTable.getMetaClient.getCommitTimeline.filterCompletedInstants()
-
-  private val useStateTransitionTime = optParams.get(DataSourceReadOptions.READ_BY_STATE_TRANSITION_TIME.key)
-    .map(_.toBoolean)
-    .getOrElse(DataSourceReadOptions.READ_BY_STATE_TRANSITION_TIME.defaultValue)
-
-  if (commitTimeline.empty()) {
-    throw new HoodieException("No instants to incrementally pull")
-  }
-  if (!optParams.contains(DataSourceReadOptions.BEGIN_INSTANTTIME.key)) {
-    throw new HoodieException(s"Specify the begin instant time to pull from using " +
-      s"option ${DataSourceReadOptions.BEGIN_INSTANTTIME.key}")
+case class IncrementalRelation(override val sqlContext: SQLContext,
+                               override val optParams: Map[String, String],
+                               private val userSchema: Option[StructType],
+                               override val metaClient: HoodieTableMetaClient,
+                               private val prunedDataSchema: Option[StructType] = None)
+  extends AbstractBaseFileOnlyRelation(sqlContext, metaClient, optParams, userSchema, Seq(), prunedDataSchema)
+    with HoodieIncrementalRelationTrait {
+
+  override type Relation = IncrementalRelation
+
+  override def imbueConfigs(sqlContext: SQLContext): Unit = {
+    super.imbueConfigs(sqlContext)
+    // TODO(HUDI-3639) vectorized reader has to be disabled to make sure IncrementalRelation is working properly
+    sqlContext.sparkSession.sessionState.conf.setConfString("spark.sql.parquet.enableVectorizedReader", "false")
   }
-
-  if (!metaClient.getTableConfig.populateMetaFields()) {
-    throw new HoodieException("Incremental queries are not supported when meta fields are disabled")
-  }
-
-  val useEndInstantSchema = optParams.getOrElse(DataSourceReadOptions.INCREMENTAL_READ_SCHEMA_USE_END_INSTANTTIME.key,
-    DataSourceReadOptions.INCREMENTAL_READ_SCHEMA_USE_END_INSTANTTIME.defaultValue).toBoolean
-
-  private val lastInstant = commitTimeline.lastInstant().get()
-
-  private val commitsTimelineToReturn = {
-    if (useStateTransitionTime) {
-      commitTimeline.findInstantsInRangeByStateTransitionTs(
-        optParams(DataSourceReadOptions.BEGIN_INSTANTTIME.key),
-        optParams.getOrElse(DataSourceReadOptions.END_INSTANTTIME.key(), lastInstant.getStateTransitionTime))
+  override def updatePrunedDataSchema(prunedSchema: StructType): Relation =
+    this.copy(prunedDataSchema = Some(prunedSchema))
+
+  protected override def timeline: HoodieTimeline = {
+    if (fullTableScan) {
+      metaClient.getCommitsAndCompactionTimeline
+    } else if (useStateTransitionTime) {
+      metaClient.getCommitsAndCompactionTimeline.findInstantsInRangeByStateTransitionTs(startTimestamp, endTimestamp)
     } else {
-      commitTimeline.findInstantsInRange(
-        optParams(DataSourceReadOptions.BEGIN_INSTANTTIME.key),
-        optParams.getOrElse(DataSourceReadOptions.END_INSTANTTIME.key(), lastInstant.getTimestamp))
+      metaClient.getCommitsAndCompactionTimeline.findInstantsInRange(startTimestamp, endTimestamp)
     }
   }
-  private val commitsToReturn = commitsTimelineToReturn.getInstantsAsStream.iterator().toList
-
-  // use schema from a file produced in the end/latest instant
 
-  val (usedSchema, internalSchema) = {
-    log.info("Inferring schema..")
-    val schemaResolver = new TableSchemaResolver(metaClient)
-    val iSchema : InternalSchema = if (!isSchemaEvolutionEnabledOnRead(optParams, sqlContext.sparkSession)) {
-      InternalSchema.getEmptyInternalSchema
-    } else if (useEndInstantSchema && !commitsToReturn.isEmpty) {
-      InternalSchemaCache.searchSchemaAndCache(commitsToReturn.last.getTimestamp.toLong, metaClient, hoodieTable.getConfig.getInternalSchemaCacheEnable)
-    } else {
-      schemaResolver.getTableInternalSchemaFromCommitMetadata.orElse(null)
-    }
-
-    val tableSchema = if (useEndInstantSchema && iSchema.isEmptySchema) {
-      if (commitsToReturn.isEmpty) schemaResolver.getTableAvroSchema(false) else
-        schemaResolver.getTableAvroSchema(commitsToReturn.last, false)
-    } else {
-      schemaResolver.getTableAvroSchema(false)
-    }
-    if (tableSchema.getType == Schema.Type.NULL) {
-      // if there is only one commit in the table and is an empty commit without schema, return empty RDD here
-      (StructType(Nil), InternalSchema.getEmptyInternalSchema)
-    } else {
-      val dataSchema = AvroConversionUtils.convertAvroSchemaToStructType(tableSchema)
-      if (iSchema != null && !iSchema.isEmptySchema) {
-        // if internalSchema is ready, dataSchema will contains skeletonSchema
-        (dataSchema, iSchema)
-      } else {
-        (StructType(skeletonSchema.fields ++ dataSchema.fields), InternalSchema.getEmptyInternalSchema)
-      }
-    }
+  protected override def composeRDD(fileSplits: Seq[HoodieBaseFileSplit],
+                                    tableSchema: HoodieTableSchema,
+                                    requiredSchema: HoodieTableSchema,
+                                    requestedColumns: Array[String],
+                                    filters: Array[Filter]): RDD[InternalRow] = {
+    super.composeRDD(fileSplits, tableSchema, requiredSchema, requestedColumns,
+      filters ++ incrementalSpanRecordFilters)
   }
 
-  private val filters = optParams.getOrElse(DataSourceReadOptions.PUSH_DOWN_INCR_FILTERS.key,

Review Comment:
   Hey @bvaradar, it appears this is introduced in https://github.com/apache/hudi/pull/485, but I don't find any implementation in `MergeOnReadIncrementalRelation`, Do we overlook it or this configure is a legacy one and no longer required?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1559753980

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031",
       "triggerID" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17036",
       "triggerID" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "triggerType" : "PUSH"
     }, {
       "hash" : "530990d2ada5b8c33d31f8d45284e9038b2df719",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17065",
       "triggerID" : "530990d2ada5b8c33d31f8d45284e9038b2df719",
       "triggerType" : "PUSH"
     }, {
       "hash" : "743315d3a828ebbc9623ac3b17778cf2ff4e7d63",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17296",
       "triggerID" : "743315d3a828ebbc9623ac3b17778cf2ff4e7d63",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * 743315d3a828ebbc9623ac3b17778cf2ff4e7d63 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17296) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1539383881

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b8fd1cd5d56d58fc52d334a54e326c405fadf53 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1545026508

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b8fd1cd5d56d58fc52d334a54e326c405fadf53 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966) 
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1545308323

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031",
       "triggerID" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031) 
   * d2f1d265394f8a6fa33f96577704af6f8422e996 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1545251811

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031",
       "triggerID" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1547113162

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031",
       "triggerID" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17036",
       "triggerID" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "triggerType" : "PUSH"
     }, {
       "hash" : "530990d2ada5b8c33d31f8d45284e9038b2df719",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "530990d2ada5b8c33d31f8d45284e9038b2df719",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * d2f1d265394f8a6fa33f96577704af6f8422e996 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17036) 
   * 530990d2ada5b8c33d31f8d45284e9038b2df719 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] boneanxs closed pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs closed pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation
URL: https://github.com/apache/hudi/pull/8669


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] boneanxs commented on a diff in pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs commented on code in PR #8669:
URL: https://github.com/apache/hudi/pull/8669#discussion_r1188092438


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/IncrementalRelation.scala:
##########
@@ -17,281 +17,82 @@
 
 package org.apache.hudi
 
-import org.apache.avro.Schema
-import org.apache.hadoop.fs.{GlobPattern, Path}
-import org.apache.hudi.HoodieBaseRelation.isSchemaEvolutionEnabledOnRead
-import org.apache.hudi.client.common.HoodieSparkEngineContext
-import org.apache.hudi.client.utils.SparkInternalSchemaConverter
-import org.apache.hudi.common.fs.FSUtils
-import org.apache.hudi.common.model.{HoodieCommitMetadata, HoodieFileFormat, HoodieRecord, HoodieReplaceCommitMetadata}
-import org.apache.hudi.common.table.timeline.{HoodieInstant, HoodieTimeline}
-import org.apache.hudi.common.table.{HoodieTableMetaClient, TableSchemaResolver}
-import org.apache.hudi.common.util.{HoodieTimer, InternalSchemaCache}
-import org.apache.hudi.config.HoodieWriteConfig
-import org.apache.hudi.exception.HoodieException
-import org.apache.hudi.internal.schema.InternalSchema
-import org.apache.hudi.internal.schema.utils.SerDeHelper
-import org.apache.hudi.table.HoodieSparkTable
-import org.apache.spark.api.java.JavaSparkContext
+import org.apache.hudi.common.table.timeline.HoodieTimeline
+import org.apache.hudi.common.table.view.HoodieTableFileSystemView
+import org.apache.hudi.common.table.HoodieTableMetaClient
+import org.apache.hudi.hadoop.utils.HoodieInputFormatUtils.getWritePartitionPaths
 import org.apache.spark.rdd.RDD
-import org.apache.spark.sql.execution.datasources.parquet.HoodieParquetFileFormat
-import org.apache.spark.sql.sources.{BaseRelation, TableScan}
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.expressions.Expression
+import org.apache.spark.sql.sources.Filter
 import org.apache.spark.sql.types.StructType
-import org.apache.spark.sql.{DataFrame, Row, SQLContext}
-import org.slf4j.LoggerFactory
+import org.apache.spark.sql.SQLContext
 
-import scala.collection.JavaConversions._
-import scala.collection.mutable
+import scala.collection.JavaConverters._
 
 /**
  * Relation, that implements the Hoodie incremental view.
  *
  * Implemented for Copy_on_write storage.
- * TODO: rebase w/ HoodieBaseRelation HUDI-5362
  *
  */
-class IncrementalRelation(val sqlContext: SQLContext,
-                          val optParams: Map[String, String],
-                          val userSchema: Option[StructType],
-                          val metaClient: HoodieTableMetaClient) extends BaseRelation with TableScan {
-
-  private val log = LoggerFactory.getLogger(classOf[IncrementalRelation])
-
-  val skeletonSchema: StructType = HoodieSparkUtils.getMetaSchema
-  private val basePath = metaClient.getBasePathV2
-  // TODO : Figure out a valid HoodieWriteConfig
-  private val hoodieTable = HoodieSparkTable.create(HoodieWriteConfig.newBuilder().withPath(basePath.toString).build(),
-    new HoodieSparkEngineContext(new JavaSparkContext(sqlContext.sparkContext)),
-    metaClient)
-  private val commitTimeline = hoodieTable.getMetaClient.getCommitTimeline.filterCompletedInstants()
-
-  private val useStateTransitionTime = optParams.get(DataSourceReadOptions.READ_BY_STATE_TRANSITION_TIME.key)
-    .map(_.toBoolean)
-    .getOrElse(DataSourceReadOptions.READ_BY_STATE_TRANSITION_TIME.defaultValue)
-
-  if (commitTimeline.empty()) {
-    throw new HoodieException("No instants to incrementally pull")
-  }
-  if (!optParams.contains(DataSourceReadOptions.BEGIN_INSTANTTIME.key)) {
-    throw new HoodieException(s"Specify the begin instant time to pull from using " +
-      s"option ${DataSourceReadOptions.BEGIN_INSTANTTIME.key}")
+case class IncrementalRelation(override val sqlContext: SQLContext,
+                               override val optParams: Map[String, String],
+                               private val userSchema: Option[StructType],
+                               override val metaClient: HoodieTableMetaClient,
+                               private val prunedDataSchema: Option[StructType] = None)
+  extends AbstractBaseFileOnlyRelation(sqlContext, metaClient, optParams, userSchema, Seq(), prunedDataSchema)
+    with HoodieIncrementalRelationTrait {
+
+  override type Relation = IncrementalRelation
+
+  override def imbueConfigs(sqlContext: SQLContext): Unit = {
+    super.imbueConfigs(sqlContext)
+    // TODO(HUDI-3639) vectorized reader has to be disabled to make sure IncrementalRelation is working properly
+    sqlContext.sparkSession.sessionState.conf.setConfString("spark.sql.parquet.enableVectorizedReader", "false")
   }
-
-  if (!metaClient.getTableConfig.populateMetaFields()) {
-    throw new HoodieException("Incremental queries are not supported when meta fields are disabled")
-  }
-
-  val useEndInstantSchema = optParams.getOrElse(DataSourceReadOptions.INCREMENTAL_READ_SCHEMA_USE_END_INSTANTTIME.key,
-    DataSourceReadOptions.INCREMENTAL_READ_SCHEMA_USE_END_INSTANTTIME.defaultValue).toBoolean
-
-  private val lastInstant = commitTimeline.lastInstant().get()
-
-  private val commitsTimelineToReturn = {
-    if (useStateTransitionTime) {
-      commitTimeline.findInstantsInRangeByStateTransitionTs(
-        optParams(DataSourceReadOptions.BEGIN_INSTANTTIME.key),
-        optParams.getOrElse(DataSourceReadOptions.END_INSTANTTIME.key(), lastInstant.getStateTransitionTime))
+  override def updatePrunedDataSchema(prunedSchema: StructType): Relation =
+    this.copy(prunedDataSchema = Some(prunedSchema))
+
+  protected override def timeline: HoodieTimeline = {
+    if (fullTableScan) {
+      metaClient.getCommitsAndCompactionTimeline
+    } else if (useStateTransitionTime) {
+      metaClient.getCommitsAndCompactionTimeline.findInstantsInRangeByStateTransitionTs(startTimestamp, endTimestamp)
     } else {
-      commitTimeline.findInstantsInRange(
-        optParams(DataSourceReadOptions.BEGIN_INSTANTTIME.key),
-        optParams.getOrElse(DataSourceReadOptions.END_INSTANTTIME.key(), lastInstant.getTimestamp))
+      metaClient.getCommitsAndCompactionTimeline.findInstantsInRange(startTimestamp, endTimestamp)
     }
   }
-  private val commitsToReturn = commitsTimelineToReturn.getInstantsAsStream.iterator().toList
-
-  // use schema from a file produced in the end/latest instant
 
-  val (usedSchema, internalSchema) = {
-    log.info("Inferring schema..")
-    val schemaResolver = new TableSchemaResolver(metaClient)
-    val iSchema : InternalSchema = if (!isSchemaEvolutionEnabledOnRead(optParams, sqlContext.sparkSession)) {
-      InternalSchema.getEmptyInternalSchema
-    } else if (useEndInstantSchema && !commitsToReturn.isEmpty) {
-      InternalSchemaCache.searchSchemaAndCache(commitsToReturn.last.getTimestamp.toLong, metaClient, hoodieTable.getConfig.getInternalSchemaCacheEnable)
-    } else {
-      schemaResolver.getTableInternalSchemaFromCommitMetadata.orElse(null)
-    }
-
-    val tableSchema = if (useEndInstantSchema && iSchema.isEmptySchema) {
-      if (commitsToReturn.isEmpty) schemaResolver.getTableAvroSchema(false) else
-        schemaResolver.getTableAvroSchema(commitsToReturn.last, false)
-    } else {
-      schemaResolver.getTableAvroSchema(false)
-    }
-    if (tableSchema.getType == Schema.Type.NULL) {
-      // if there is only one commit in the table and is an empty commit without schema, return empty RDD here
-      (StructType(Nil), InternalSchema.getEmptyInternalSchema)
-    } else {
-      val dataSchema = AvroConversionUtils.convertAvroSchemaToStructType(tableSchema)
-      if (iSchema != null && !iSchema.isEmptySchema) {
-        // if internalSchema is ready, dataSchema will contains skeletonSchema
-        (dataSchema, iSchema)
-      } else {
-        (StructType(skeletonSchema.fields ++ dataSchema.fields), InternalSchema.getEmptyInternalSchema)
-      }
-    }
+  protected override def composeRDD(fileSplits: Seq[HoodieBaseFileSplit],
+                                    tableSchema: HoodieTableSchema,
+                                    requiredSchema: HoodieTableSchema,
+                                    requestedColumns: Array[String],
+                                    filters: Array[Filter]): RDD[InternalRow] = {
+    super.composeRDD(fileSplits, tableSchema, requiredSchema, requestedColumns,
+      filters ++ incrementalSpanRecordFilters)
   }
 
-  private val filters = optParams.getOrElse(DataSourceReadOptions.PUSH_DOWN_INCR_FILTERS.key,

Review Comment:
   Hey @bvaradar, it appears this is introduced in https://github.com/apache/hudi/pull/485, but I don't find any implementation in `MergeOnReadIncrementalRelation`, did we overlook it or this configure is a legacy one and no longer required?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1545524592

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031",
       "triggerID" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17036",
       "triggerID" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * d2f1d265394f8a6fa33f96577704af6f8422e996 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17036) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] yihua commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1563250005

   Feel free to review that PR too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1558996699

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031",
       "triggerID" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17036",
       "triggerID" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "triggerType" : "PUSH"
     }, {
       "hash" : "530990d2ada5b8c33d31f8d45284e9038b2df719",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17065",
       "triggerID" : "530990d2ada5b8c33d31f8d45284e9038b2df719",
       "triggerType" : "PUSH"
     }, {
       "hash" : "743315d3a828ebbc9623ac3b17778cf2ff4e7d63",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "743315d3a828ebbc9623ac3b17778cf2ff4e7d63",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * 530990d2ada5b8c33d31f8d45284e9038b2df719 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17065) 
   * 743315d3a828ebbc9623ac3b17778cf2ff4e7d63 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1559011714

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16966",
       "triggerID" : "9b8fd1cd5d56d58fc52d334a54e326c405fadf53",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0eacefd8bc063e0c574068f09670014804f10dc2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17030",
       "triggerID" : "9a00f9d6ece8c5b290975988e1bc40f2ba7ff91b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17031",
       "triggerID" : "b6b0fa0b3bf274c542fa385c6b9dfe8df69925b1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17036",
       "triggerID" : "d2f1d265394f8a6fa33f96577704af6f8422e996",
       "triggerType" : "PUSH"
     }, {
       "hash" : "530990d2ada5b8c33d31f8d45284e9038b2df719",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17065",
       "triggerID" : "530990d2ada5b8c33d31f8d45284e9038b2df719",
       "triggerType" : "PUSH"
     }, {
       "hash" : "743315d3a828ebbc9623ac3b17778cf2ff4e7d63",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17296",
       "triggerID" : "743315d3a828ebbc9623ac3b17778cf2ff4e7d63",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0eacefd8bc063e0c574068f09670014804f10dc2 UNKNOWN
   * 530990d2ada5b8c33d31f8d45284e9038b2df719 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17065) 
   * 743315d3a828ebbc9623ac3b17778cf2ff4e7d63 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17296) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] yihua commented on pull request #8669: [HUDI-5362] Rebase IncrementalRelation over HoodieBaseRelation

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #8669:
URL: https://github.com/apache/hudi/pull/8669#issuecomment-1560083521

   Is this a duplicate of #6045?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org