You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/07 15:24:04 UTC

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11377: [BEAM-9439] Return split instead of total backlog size

aromanenko-dev commented on a change in pull request #11377:
URL: https://github.com/apache/beam/pull/11377#discussion_r421588662



##########
File path: sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/ShardRecordsIterator.java
##########
@@ -43,22 +42,23 @@
   private final RecordFilter filter;
   private final String streamName;
   private final String shardId;
-  private AtomicReference<ShardCheckpoint> checkpoint;
+  private final AtomicReference<ShardCheckpoint> checkpoint;
+  private final WatermarkPolicy watermarkPolicy;

Review comment:
       Why `AtomicReference` no more used here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org