You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2017/09/20 05:41:23 UTC

[GitHub] carbondata pull request #1373: [CARBONDATA-1490] Fixed memory allocation for...

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/1373

    [CARBONDATA-1490] Fixed memory allocation for carbon row

    Analysis: While creating carbon row the space for measures is assigned based on outputLength and not on measureCount which will tend to allocate more space than is actually needed.
    **outputLength = measureCount + ((noDictCount + complexCount) > 0 ? 1 : 0) + 1**
    When the table has 1 complex column then measureCount=0, noDictCount=0, complexCount=1
    therefore, outputLength = 2
    Even if there are no measure columns the measure object is created with 2 null values.
    
    Solution: Create measure object based on the measureCount.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata CARBONDATA-1490

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1373
    
----
commit 13f55ae9a2adc862be4367c8cdf265a18ad4fd58
Author: kunal642 <ku...@gmail.com>
Date:   2017-09-20T05:32:00Z

    fixed memory allocation for carbon row

----


---

[GitHub] carbondata issue #1373: [CARBONDATA-1490] Fixed memory allocation for carbon...

Posted by manishgupta88 <gi...@git.apache.org>.

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1373
  
    LGTM


---

[GitHub] carbondata pull request #1373: [CARBONDATA-1490] Fixed memory allocation for...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1373


---

[GitHub] carbondata issue #1373: [CARBONDATA-1490] Fixed memory allocation for carbon...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1373
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/870/



---

[GitHub] carbondata issue #1373: [CARBONDATA-1490] Fixed memory allocation for carbon...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1373
  
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/115/



---

[GitHub] carbondata issue #1373: [CARBONDATA-1490] Fixed memory allocation for carbon...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1373
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/239/



---