You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "crossoverJie (via GitHub)" <gi...@apache.org> on 2023/11/02 15:29:25 UTC
[PR] [improve] [pip] PIP-316 Create a producerName field for DeadLetterPolicy [pulsar]
crossoverJie opened a new pull request, #21507:
URL: https://github.com/apache/pulsar/pull/21507
Releted PR/issue: https://github.com/apache/pulsar/pull/21493 https://github.com/apache/pulsar/issues/21441
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] [pip] PIP-316 Create a producerName field for DeadLetterPolicy [pulsar]
Posted by "crossoverJie (via GitHub)" <gi...@apache.org>.
crossoverJie commented on code in PR #21507:
URL: https://github.com/apache/pulsar/pull/21507#discussion_r1396640130
##########
pip/pip-316.md:
##########
@@ -0,0 +1,83 @@
+
+# PIP-316: Create a producerName field for DeadLetterPolicy
+
+
+# Motivation
+
+Add producerName for dead letter producer, easier to locate problems.
+
+
+# Goals
+
+## In Scope
+
+Add a new field `producerName` in `org.apache.pulsar.client.api.DeadLetterPolicy` class.
+
+
+## Out of Scope
+None.
+
+# High Level Design
+
+If `producerName` is not empty, use `producerName` as the name of the dead letter producer.
Review Comment:
I have created a new PR https://github.com/apache/pulsar/pull/21589 , PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] [pip] PIP-316 Create a producerName field for DeadLetterPolicy [pulsar]
Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on code in PR #21507:
URL: https://github.com/apache/pulsar/pull/21507#discussion_r1387411745
##########
pip/pip-316.md:
##########
@@ -0,0 +1,83 @@
+
+# PIP-316: Create a producerName field for DeadLetterPolicy
+
+
+# Motivation
+
+Add producerName for dead letter producer, easier to locate problems.
Review Comment:
We need to state the motivation for adding the producer name. Is it only for debugging purposes?
##########
pip/pip-316.md:
##########
@@ -0,0 +1,83 @@
+
+# PIP-316: Create a producerName field for DeadLetterPolicy
+
+
+# Motivation
+
+Add producerName for dead letter producer, easier to locate problems.
+
+
+# Goals
+
+## In Scope
+
+Add a new field `producerName` in `org.apache.pulsar.client.api.DeadLetterPolicy` class.
+
+
+## Out of Scope
+None.
+
+# High Level Design
+
+If `producerName` is not empty, use `producerName` as the name of the dead letter producer.
Review Comment:
Could we use something like `${topic-name}-${subscription-name}-DLQ` as the producer name without introducing the `producerName` to the DLQ policy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] [pip] PIP-316 Create a producerName field for DeadLetterPolicy [pulsar]
Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on code in PR #21507:
URL: https://github.com/apache/pulsar/pull/21507#discussion_r1394128496
##########
pip/pip-316.md:
##########
@@ -0,0 +1,83 @@
+
+# PIP-316: Create a producerName field for DeadLetterPolicy
+
+
+# Motivation
+
+Add producerName for dead letter producer, easier to locate problems.
+
+
+# Goals
+
+## In Scope
+
+Add a new field `producerName` in `org.apache.pulsar.client.api.DeadLetterPolicy` class.
+
+
+## Out of Scope
+None.
+
+# High Level Design
+
+If `producerName` is not empty, use `producerName` as the name of the dead letter producer.
Review Comment:
Does this work for your case? So that we don't need to add a public interface for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] [pip] PIP-316 Create a producerName field for DeadLetterPolicy [pulsar]
Posted by "crossoverJie (via GitHub)" <gi...@apache.org>.
crossoverJie closed pull request #21507: [improve] [pip] PIP-316 Create a producerName field for DeadLetterPolicy
URL: https://github.com/apache/pulsar/pull/21507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] [pip] PIP-316 Create a producerName field for DeadLetterPolicy [pulsar]
Posted by "crossoverJie (via GitHub)" <gi...@apache.org>.
crossoverJie commented on code in PR #21507:
URL: https://github.com/apache/pulsar/pull/21507#discussion_r1387450965
##########
pip/pip-316.md:
##########
@@ -0,0 +1,83 @@
+
+# PIP-316: Create a producerName field for DeadLetterPolicy
+
+
+# Motivation
+
+Add producerName for dead letter producer, easier to locate problems.
Review Comment:
It's not just for debugging, it would also be more convenient for monitoring if there was a specific name, but right now we have no idea what this producer actually does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] [pip] PIP-316 Create a producerName field for DeadLetterPolicy [pulsar]
Posted by "crossoverJie (via GitHub)" <gi...@apache.org>.
crossoverJie commented on code in PR #21507:
URL: https://github.com/apache/pulsar/pull/21507#discussion_r1395118415
##########
pip/pip-316.md:
##########
@@ -0,0 +1,83 @@
+
+# PIP-316: Create a producerName field for DeadLetterPolicy
+
+
+# Motivation
+
+Add producerName for dead letter producer, easier to locate problems.
+
+
+# Goals
+
+## In Scope
+
+Add a new field `producerName` in `org.apache.pulsar.client.api.DeadLetterPolicy` class.
+
+
+## Out of Scope
+None.
+
+# High Level Design
+
+If `producerName` is not empty, use `producerName` as the name of the dead letter producer.
Review Comment:
Yeah, it work for me, which name would be better?
```java
producerName: persistent://my-property/my-ns/dead-letter-topic-my-subscription-DLQ
producerName: my-property/my-ns/dead-letter-topic-my-subscription-DLQ
producerName: dead-letter-topic-my-subscription-DLQ
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] [pip] PIP-316 Create a producerName field for DeadLetterPolicy [pulsar]
Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on code in PR #21507:
URL: https://github.com/apache/pulsar/pull/21507#discussion_r1396786607
##########
pip/pip-316.md:
##########
@@ -0,0 +1,83 @@
+
+# PIP-316: Create a producerName field for DeadLetterPolicy
+
+
+# Motivation
+
+Add producerName for dead letter producer, easier to locate problems.
+
+
+# Goals
+
+## In Scope
+
+Add a new field `producerName` in `org.apache.pulsar.client.api.DeadLetterPolicy` class.
+
+
+## Out of Scope
+None.
+
+# High Level Design
+
+If `producerName` is not empty, use `producerName` as the name of the dead letter producer.
Review Comment:
Thanks. Approved. Can we close this PIP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] [pip] PIP-316 Create a producerName field for DeadLetterPolicy [pulsar]
Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on code in PR #21507:
URL: https://github.com/apache/pulsar/pull/21507#discussion_r1395752511
##########
pip/pip-316.md:
##########
@@ -0,0 +1,83 @@
+
+# PIP-316: Create a producerName field for DeadLetterPolicy
+
+
+# Motivation
+
+Add producerName for dead letter producer, easier to locate problems.
+
+
+# Goals
+
+## In Scope
+
+Add a new field `producerName` in `org.apache.pulsar.client.api.DeadLetterPolicy` class.
+
+
+## Out of Scope
+None.
+
+# High Level Design
+
+If `producerName` is not empty, use `producerName` as the name of the dead letter producer.
Review Comment:
I would prefer `persistent://my-property/my-ns/dead-letter-topic-my-subscription-DLQ`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] [pip] PIP-316 Create a producerName field for DeadLetterPolicy [pulsar]
Posted by "crossoverJie (via GitHub)" <gi...@apache.org>.
crossoverJie commented on code in PR #21507:
URL: https://github.com/apache/pulsar/pull/21507#discussion_r1387451436
##########
pip/pip-316.md:
##########
@@ -0,0 +1,83 @@
+
+# PIP-316: Create a producerName field for DeadLetterPolicy
+
+
+# Motivation
+
+Add producerName for dead letter producer, easier to locate problems.
+
+
+# Goals
+
+## In Scope
+
+Add a new field `producerName` in `org.apache.pulsar.client.api.DeadLetterPolicy` class.
+
+
+## Out of Scope
+None.
+
+# High Level Design
+
+If `producerName` is not empty, use `producerName` as the name of the dead letter producer.
Review Comment:
That's a good suggestion, it can reduce the psychological burden on users when naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org