You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/13 13:31:17 UTC
[GitHub] [beam] bullet03 opened a new pull request, #22256: [Website] change getting window width method
bullet03 opened a new pull request, #22256:
URL: https://github.com/apache/beam/pull/22256
On resolutions between 1025px and 1141px right side menu overlaped left side menu. Reason is in page-nav,js in `$(window).width()`, which didn't get correct width since it didn't include horizontall scroll width. Used `window.innerWidth || document.documentElement.clientWidth || document.body.clientWidth;` instead to get correct width.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #22256: [Website] change getting window width method
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22256:
URL: https://github.com/apache/beam/pull/22256#issuecomment-1192586346
@aromanenko-dev, could you, please, help to merge current PR. It was approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #22256: [Website] change getting window width method
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22256:
URL: https://github.com/apache/beam/pull/22256#issuecomment-1183229194
before:
after:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev merged pull request #22256: [Website] change getting window width method
Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged PR #22256:
URL: https://github.com/apache/beam/pull/22256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alevtinaboiko commented on pull request #22256: [Website] change getting window width method
Posted by GitBox <gi...@apache.org>.
alevtinaboiko commented on PR #22256:
URL: https://github.com/apache/beam/pull/22256#issuecomment-1189118041
Verified, works as expected. Reviewed and tested by QA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #22256: [Website] change getting window width method
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22256:
URL: https://github.com/apache/beam/pull/22256#issuecomment-1189379901
@pcoet, could you, please, review this PR? It is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #22256: [Website] change getting window width method
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #22256:
URL: https://github.com/apache/beam/pull/22256#issuecomment-1192759615
Thanks, merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org