You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2015/12/16 07:03:16 UTC
[GitHub] incubator-zeppelin pull request: Fix when result of paragraph cont...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/538
Fix when result of paragraph contains carriage return
### What is this PR for?
When the result in paragraph contains "carriage return" or "line feed", they are getting displayed in single line. The output should be in multiline.
### What type of PR is it?
Bug Fix
### Screenshots
Before
<img width="1439" alt="screen shot 2015-12-16 at 11 26 08 am" src="https://cloud.githubusercontent.com/assets/674497/11833440/a48f1980-a3e8-11e5-908b-8d45f2e2290e.png">
After
<img width="1440" alt="screen shot 2015-12-16 at 11 27 22 am" src="https://cloud.githubusercontent.com/assets/674497/11833441/a4929074-a3e8-11e5-974b-45405cb619be.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/incubator-zeppelin multilineOutputFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/538.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #538
----
commit 9e172ca864acbd1bb51431d4668fab8f09f7f647
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-12-16T05:59:25Z
multi line output fix, when paragraph result contains "carriage return" or "line feed".
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix when result of paragraph cont...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/538#issuecomment-165692575
Does this look ok to be merged ?
Have tested this on IE10+, FF42, Chrome46, Safari9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix when result of paragraph cont...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/538
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix when result of paragraph cont...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/538#issuecomment-166087377
Tested, working great.
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix when result of paragraph cont...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/538#issuecomment-165704482
@prabhjyotsingh I will test that tomorrow. If it's good I will merge it the same day
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix when result of paragraph cont...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/538#issuecomment-165013362
Yes thanks @corneadoug, just realised, after making a PR. This should fix it.
white-space: pre-wrap;
also, there were multiple display: block and margin entries. Refactor those as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix when result of paragraph cont...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/538#issuecomment-165011618
@prabhjyotsingh I removed it to fix #531
Can you think of something that satisfies both issues?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---