You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/07/05 19:09:12 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #32274: Introduce a base class for aws triggers

eladkal commented on code in PR #32274:
URL: https://github.com/apache/airflow/pull/32274#discussion_r1253520217


##########
airflow/providers/amazon/provider.yaml:
##########
@@ -516,6 +516,9 @@ hooks:
       - airflow.providers.amazon.aws.hooks.appflow
 
 triggers:
+  - integration-name: Amazon Web Services
+    python-modules:
+      - airflow.providers.amazon.aws.triggers.base_trigger

Review Comment:
   Do we need the `_trigger` suffix?
   
   For example we have:
   `from airflow.hooks.base import BaseHook`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org