[GitHub] [spark] HyukjinKwon commented on a change in pull request #27817: [SPARK-31060][SQL] Handle column names containing `dots` in data source `Filter`

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #27817: [SPARK-31060][SQL] Handle column names containing `dots` in data source `Filter`
URL: https://github.com/apache/spark/pull/27817#discussion_r389440622
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/sources/filters.scala
 ##########
 @@ -32,6 +32,7 @@ import org.apache.spark.annotation.{Evolving, Stable}
 sealed abstract class Filter {
   /**
    * List of columns that are referenced by this filter.
+   * Note that, if a column contains `dots` in name, it will be quoted to avoid confusion.
 
 Review comment:
   Okay, I was confused about the reviewing order. This will be a breaking change - I noted in https://github.com/apache/spark/pull/27780#discussion_r389331398 too. There are non-DBMS sources too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org