You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2012/07/17 15:47:37 UTC
[jira] [Created] (DERBY-5860) Remove unused methods in DDMReader
and DDMWriter
Knut Anders Hatlen created DERBY-5860:
-----------------------------------------
Summary: Remove unused methods in DDMReader and DDMWriter
Key: DERBY-5860
URL: https://issues.apache.org/jira/browse/DERBY-5860
Project: Derby
Issue Type: Improvement
Components: Network Server
Affects Versions: 10.10.0.0
Reporter: Knut Anders Hatlen
Assignee: Knut Anders Hatlen
Many of the methods in DDMReader and DDMWriter are not used anymore. Those methods could be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5860) Remove unused methods in DDMReader and
DDMWriter
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen closed DERBY-5860.
-------------------------------------
Resolution: Fixed
Fix Version/s: 10.10.0.0
Issue & fix info: (was: Patch Available)
Committed revision 1362837.
> Remove unused methods in DDMReader and DDMWriter
> ------------------------------------------------
>
> Key: DERBY-5860
> URL: https://issues.apache.org/jira/browse/DERBY-5860
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.10.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Fix For: 10.10.0.0
>
> Attachments: d5860-1a.diff
>
>
> Many of the methods in DDMReader and DDMWriter are not used anymore. Those methods could be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5860) Remove unused methods in DDMReader
and DDMWriter
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-5860:
--------------------------------------
Attachment: d5860-1a.diff
The attached patch removes the unused methods.
DDMReader:
- getCurrentCcsidManager()
- getExtData(boolean)
- readBoolean()
- readStringData()
- toDebugString(String)
DDMWriter:
- startDdm(int, int)
- writeScalarBytes(int, byte[], int)
- writeScalarPaddedString (String, int)
- writeScalarBytes (int, byte[], int, int)
- zeroPadString(String, int)
- toDebugString(String)
The toDebugString(String) methods could perhaps be kept in case someone needs them when debugging. However, they only return the buffer size, so they are not very useful in their current state.
All the regression tests ran cleanly with the patch.
> Remove unused methods in DDMReader and DDMWriter
> ------------------------------------------------
>
> Key: DERBY-5860
> URL: https://issues.apache.org/jira/browse/DERBY-5860
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.10.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Attachments: d5860-1a.diff
>
>
> Many of the methods in DDMReader and DDMWriter are not used anymore. Those methods could be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira