You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "JinHelin404 (via GitHub)" <gi...@apache.org> on 2024/02/28 02:43:07 UTC
[PR] [SPARK-43255][SQL]Replace the error class _LEGACY_ERROR_TEMP_2020 by an internal error [spark]
JinHelin404 opened a new pull request, #45302:
URL: https://github.com/apache/spark/pull/45302
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Change the error class_LEGACY_ERROR_TEMP_2022 to internal error as it cannot be accessed by public API.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
User experience improvement
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Tests already exist.
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
No
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43255][SQL] Replace the error class _LEGACY_ERROR_TEMP_2020 by an internal error [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #45302:
URL: https://github.com/apache/spark/pull/45302#issuecomment-1972809205
+1, LGTM. Merging to master.
Thank you, @JinHelin404 and @eejbyfeldt @amaliujia for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43255][SQL]Replace the error class _LEGACY_ERROR_TEMP_2020 by an internal error [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #45302:
URL: https://github.com/apache/spark/pull/45302#issuecomment-1969884526
If I am not wrong: `StaticInvoke` could trigger this error and `StaticInvoke` could be used by a user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43255][SQL]Replace the error class _LEGACY_ERROR_TEMP_2020 by an internal error [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #45302:
URL: https://github.com/apache/spark/pull/45302#issuecomment-1969886400
cc @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43255][SQL] Replace the error class _LEGACY_ERROR_TEMP_2020 by an internal error [spark]
Posted by "JinHelin404 (via GitHub)" <gi...@apache.org>.
JinHelin404 commented on PR #45302:
URL: https://github.com/apache/spark/pull/45302#issuecomment-1972782237
> @JinHelin404 Do you have an account at OSS JIRA: https://issues.apache.org/jira/browse/SPARK-43255? If so, please, leave a comment in the ticket (I will assign it to you) otherwise submit a request for the account.
@MaxGekk I have left a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43255][SQL]Replace the error class _LEGACY_ERROR_TEMP_2020 by an internal error [spark]
Posted by "eejbyfeldt (via GitHub)" <gi...@apache.org>.
eejbyfeldt commented on PR #45302:
URL: https://github.com/apache/spark/pull/45302#issuecomment-1972662822
@MaxGekk To me it seems correct to make it an internal error. I think the cases it could come up from using user defined types in the Scala API are meant to be captured earlier by other code and it failing with this would indicate a spark bug.
> If I am not wrong: StaticInvoke could trigger this error and StaticInvoke could be used by a user?
> I saw in the past users use StaticInvoke in their library.
My understanding is that classes `org.apache.spark.sql.catalyst` were consider semi private/developer api. But I have not really found the documentation where this is clarified so maybe I have misunderstood something. Anyway to me it does not seem realistic to provide good errors for all possible missuses of classes that live in there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43255][SQL] Replace the error class _LEGACY_ERROR_TEMP_2020 by an internal error [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #45302:
URL: https://github.com/apache/spark/pull/45302#issuecomment-1972676151
@JinHelin404 Do you have an account at OSS JIRA: https://issues.apache.org/jira/browse/SPARK-43255? If so, please, leave a comment in the ticket (I will assign it to you) otherwise submit a request for the account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43255][SQL] Replace the error class _LEGACY_ERROR_TEMP_2020 by an internal error [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #45302: [SPARK-43255][SQL] Replace the error class _LEGACY_ERROR_TEMP_2020 by an internal error
URL: https://github.com/apache/spark/pull/45302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org