You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Eugene Kirpichov (JIRA)" <ji...@apache.org> on 2018/07/02 23:23:00 UTC

[jira] [Closed] (BEAM-3907) Clarify how watermark is estimated for watchForNewFiles() transforms

     [ https://issues.apache.org/jira/browse/BEAM-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugene Kirpichov closed BEAM-3907.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 2.6.0

This will not need clarification since I fixed a bug in watermark advancement in watchForNewFiles(). It will need clarification if somebody adds custom timestamps/watermarks.

> Clarify how watermark is estimated for watchForNewFiles() transforms
> --------------------------------------------------------------------
>
>                 Key: BEAM-3907
>                 URL: https://issues.apache.org/jira/browse/BEAM-3907
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Chamikara Jayalath
>            Assignee: Eugene Kirpichov
>            Priority: Major
>             Fix For: 2.6.0
>
>
> For example [https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java#L488]
> It's not clear how the watermark will be estimated/incremented when using these transforms. 
> Other source implementations seems to be describing this. For example: https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubUnboundedSource.java#L89



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)