[jira] [Commented] (FLINK-18487) New table source factory omits unrecognized properties silently

["Jingsong Lee (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151705#comment-17151705 ] 

Jingsong Lee commented on FLINK-18487:
--------------------------------------

It is true, we can implement a validator for this. But it is not easy to re-use FactoryUtil:
 * Like old schema config option style, datagen source needs option keys related to the fields. like "fields.*.generator".
 * FactoryUtil not accept wildcard now.

There is no clear answer in 1.11, but we can move forward in 1.12.

> New table source factory omits unrecognized properties silently
> ---------------------------------------------------------------
>
>                 Key: FLINK-18487
>                 URL: https://issues.apache.org/jira/browse/FLINK-18487
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / API
>    Affects Versions: 1.11.0
>            Reporter: Benchao Li
>            Priority: Major
>
> For the following DDL, we just omits the unrecognized property 'records-per-second'.
> {code:sql}
> CREATE TABLE MyDataGen (
>   int_field int,
>   double_field double,
>   string_field varchar
> ) WITH (
>   'connector' = 'datagen',
>   'records-per-second' = '1'  -- should be rows-per-second
> )
> {code}
> IMO, we should throw Exceptions to tell users that they used a wrong property. 
>  CC [~jark] [~twalthr]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)