You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "healchow (via GitHub)" <gi...@apache.org> on 2023/03/27 03:55:35 UTC

[GitHub] [inlong] healchow commented on a diff in pull request #7674: [INLONG-7673][Manager] Remove whitespace when saving url

healchow commented on code in PR #7674:
URL: https://github.com/apache/inlong/pull/7674#discussion_r1148758318


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/mysql/MySQLSinkDTO.java:
##########
@@ -221,7 +221,7 @@ public static String filterSensitive(String url) {
             return url;
         }
         try {
-            String resultUrl = url;
+            String resultUrl = url.replaceAll(InlongConstants.BLANK, "");

Review Comment:
   @fuweng11 I think we should replace/trim the data when it comes in.
   Because the external data is untrustworthy, it is processed uniformly when it enters the system;
   
   Once the data is saved in the DB of our system, the data transferring within the system should be regarded as credible data and does not need to be processed repeatedly in every place of use.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org