[GitHub] [tvm] comaniac commented on a change in pull request #7038: [ROCm][Auto schedular] Support Auto schedular and NHWC convolution on ROCm

[GitBox <gi...@apache.org>]

comaniac commented on a change in pull request #7038:
URL: https://github.com/apache/tvm/pull/7038#discussion_r536509015



##########
File path: src/auto_scheduler/search_task.cc
##########
@@ -66,6 +69,11 @@ HardwareParams HardwareParamsNode::GetDefaultHardwareParams(const Target& target
 
     device_api->GetAttr(ctx, tvm::runtime::DeviceAttrKind::kMaxRegistersPerBlock, &ret);
     int max_registers_per_block = ret;
+    if (max_registers_per_block == 0) {
+      LOG(INFO) << "Device API reported kMaxRegistersPerBlock being 0, using the value of "
+                   "kMaxSharedMemoryPerBlock as max_registers_per_block.";

Review comment:
       It seems to me that most people won't understand the meaning of this message. Maybe either turning it to a comment, or mentioning this is for the performance cost model?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org