You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by liuyu000 <gi...@git.apache.org> on 2018/08/14 07:07:28 UTC
[GitHub] trafodion pull request #1695: [TRAFODION-3184] Correct Syntax Descriptions a...
GitHub user liuyu000 opened a pull request:
https://github.com/apache/trafodion/pull/1695
[TRAFODION-3184] Correct Syntax Descriptions and Add Examples for *TIME* and *TIMESTAMP(P)* in *Trafodion SQL Reference Manual*
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liuyu000/trafodion Timestamp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1695.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1695
----
commit 9f488bad9b1dce72b62c9c9f64f7a07deea1002d
Author: liu.yu <qw...@...>
Date: 2018-08-14T07:03:56Z
[TRAFODION-3184] Correct Syntax Descriptions and Add Examples for *TIME* and *TIMESTAMP(P)* in *Trafodion SQL Reference Manual*
----
---
[GitHub] trafodion pull request #1695: [TRAFODION-3184] Correct Syntax Descriptions a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1695
---
[GitHub] trafodion pull request #1695: [TRAFODION-3184] Correct Syntax Descriptions a...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1695#discussion_r210818947
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc ---
@@ -776,14 +776,105 @@ of digits in the fractional seconds and is stored in four bytes. The
default for _time-precision_ is 0, and the maximum is 6.
* `TIMESTAMP [(_timestamp-precision_)]`
+
++
+** specifies a datetime column that, without the optional
--- End diff --
@DaveBirdsall thanks 😁
For clear and clarity, _`Timestamp`_ and _`Timestamp (time-precision)`_ are written separately , could you please help review?
---
[GitHub] trafodion pull request #1695: [TRAFODION-3184] Correct Syntax Descriptions a...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1695#discussion_r210709602
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc ---
@@ -776,14 +776,105 @@ of digits in the fractional seconds and is stored in four bytes. The
default for _time-precision_ is 0, and the maximum is 6.
* `TIMESTAMP [(_timestamp-precision_)]`
+
++
+** specifies a datetime column that, without the optional
--- End diff --
Just noticed that you have a table below that gives the storage sizes. So we don't even have to mention it in this paragraph. Possible revised wordsmith: "** specifies a datetime column. If _timestamp-precision_ is specified and is zero, the timestamp in external form is yyyy-mm-dd hh:mm:ss. In all other cases, the timestamp in external form is yyyy-mm-dd hh:mm:ss.ffffff, the number of digits to the right of the decimal point being equal to _timestamp-precision_. If _timestamp-precision_ is omitted, it defaults to six."
---
[GitHub] trafodion pull request #1695: [TRAFODION-3184] Correct Syntax Descriptions a...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1695#discussion_r210705551
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc ---
@@ -776,14 +776,105 @@ of digits in the fractional seconds and is stored in four bytes. The
default for _time-precision_ is 0, and the maximum is 6.
* `TIMESTAMP [(_timestamp-precision_)]`
+
++
+** specifies a datetime column that, without the optional
--- End diff --
The wording of this paragraph is a bit awkward. Possible wordsmith: "** specifies a datetime column. If `_timestamp-precision_` is specified and is zero, the timestamp in external form is `yyyy-mm-dd hh:mm:ss` and the database storage is 7 bytes. In all other cases, the timestamp in external form is `yyyy-mm-dd hh:mm:ss.ffffff`, the number of digits to the right of the decimal point being equal to `_timestamp-precision_`. If `_timestamp-precision_` is omitted, it defaults to six. Database storage is 11 bytes in these cases.
---