You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/20 06:16:25 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #5938: VR: remove old json config when start vmware/xenserver VPC VRs
weizhouapache opened a new pull request, #5938:
URL: https://github.com/apache/cloudstack/pull/5938
### Description
This PR fixes the issue that the IPs are associated to wrong interfaces when reboot a VR on vmware/xen environment.
However, VR will be broken if it is rebooted in vCenter or XenCenter (not in cloudstack).
steps to reproduce the issue
(1) create vpc, and a vpc tier
(2) acquire an ip in additional ip range, enable static nat or pf/lb
(3) reboot VR in cloudstack
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1087368345
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1107058424
<b>Trillian test result (tid-3992)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49381 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t3992-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1208960520
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1198957517
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1207729314
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106468795
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106331963
@weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1208956225
@blueorangutan test centos7 xs71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1208983282
<b>Trillian Build Failed (tid-4659)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1089284770
<b>Trillian test result (tid-3820)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35151 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t3820-vmware-65u2.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1105751021
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106193814
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106467682
@Pearl1594 @nvazquez
this requires new systemvm template, as it changes init.sh which is the entry point of systemvms and VRs.
moved to 4.17.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1207706785
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1209605507
<b>Trillian test result (tid-4660)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35299 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t4660-xenserver-71.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106522950
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106940930
<b>Trillian test result (tid-3990)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42451 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t3990-xenserver-71.zip
Smoke tests completed. 50 look OK, 46 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 8.99 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Error` | 8.04 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 8.06 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 8.03 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 8.00 | test_vpc_redundant.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
test_09_reboot_ssvm_forced | `Failure` | 0.03 | test_ssvm.py
test_10_reboot_cpvm_forced | `Failure` | 0.03 | test_ssvm.py
test_11_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
test_10_project_activation | `Error` | 3671.46 | test_projects.py
test_deploy_vm_from_iso | `Error` | 1513.24 | test_deploy_vm_iso.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
test_01_add_primary_storage_disabled_host | `Error` | 36.89 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.13 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.21 | test_primary_storage.py
test_01_vpc_privategw_acl | `Failure` | 5.96 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Failure` | 6.05 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 6.07 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 10.11 | test_privategw_acl.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.37 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.39 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.36 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.36 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 4.54 | test_templates.py
test_07_deploy_vm_with_extraconfig_xenserver | `Error` | 2.28 | test_deploy_vm_extra_config_data.py
test_01_isolated_persistent_network | `Error` | 3.46 | test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Failure` | 3.22 | test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Error` | 3.22 | test_persistent_network.py
ContextSuite context=TestL2PersistentNetworks>:teardown | `Error` | 3.26 | test_persistent_network.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
test_00_deploy_vm_root_resize | `Error` | 1.23 | test_deploy_vm_root_resize.py
test_deployvm_userdata | `Error` | 1.23 | test_deploy_vm_with_userdata.py
test_deployvm_userdata_post | `Error` | 1.18 | test_deploy_vm_with_userdata.py
test_deployvm_firstfit | `Error` | 1.25 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | `Error` | 1.19 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdispersing | `Error` | 1.17 | test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
test_01_create_delete_portforwarding_fornonvpc | `Error` | 1.74 | test_portforwardingrules.py
test_03_deploy_vm_domain_service_offering | `Error` | 10.63 | test_domain_service_offerings.py
test_01_so_removal_resource_update | `Error` | 1.31 | test_resource_accounting.py
test_03_create_vpc_domain_vpc_offering | `Error` | 10.54 | test_domain_vpc_offerings.py
test_list_vms_metrics | `Error` | 0.17 | test_metrics_api.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
test_01_nic | `Error` | 51.45 | test_nic.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
test_01_create_iso_with_checksum_sha1 | `Error` | 66.39 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 66.39 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 66.39 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 66.39 | test_iso.py
test_01_create_iso | `Failure` | 1513.57 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 3026.13 | test_iso.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.16 | test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.15 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.29 | test_routers_network_ops.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version | `Error` | 0.14 | test_kubernetes_supported_versions.py
ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py
test_03_network_operations_on_created_vm_of_otheruser | `Error` | 0.03 | test_network_permissions.py
test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 0.14 | test_network_permissions.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_delete_account | `Error` | 1.70 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 1.14 | test_network.py
test_deploy_vm_l2network | `Error` | 1.14 | test_network.py
test_l2network_restart | `Error` | 2.23 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 3.41 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 3.51 | test_network.py
test_reboot_router | `Failure` | 0.05 | test_network.py
test_releaseIP | `Error` | 1.63 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 1.68 | test_network.py
test_01_deployVMInSharedNetwork | `Failure` | 1.15 | test_network.py
test_02_verifyRouterIpAfterNetworkRestart | `Failure` | 1.07 | test_network.py
test_03_destroySharedNetwork | `Failure` | 1.07 | test_network.py
ContextSuite context=TestSharedNetwork>:teardown | `Error` | 1.14 | test_network.py
test_01_create_private_gateway_with_vlan | `Error` | 1.13 | test_user_private_gateway.py
test_02_create_private_gateway_with_associated_network | `Error` | 0.59 | test_user_private_gateway.py
ContextSuite context=TestUserPrivateGateways>:teardown | `Error` | 5.98 | test_user_private_gateway.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.13 | test_service_offerings.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
test_01_sys_vm_start | `Failure` | 0.10 | test_secondary_storage.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
test_01_create_user_shared_network_without_vlan | `Failure` | 0.13 | test_user_shared_network.py
test_03_create_domain_shared_network_with_associated_network | `Failure` | 3.44 | test_user_shared_network.py
test_04_create_account_shared_network_with_associated_network | `Failure` | 4.00 | test_user_shared_network.py
ContextSuite context=TestUserSharedNetworks>:teardown | `Error` | 9.35 | test_user_shared_network.py
test_01_deploy_vm_on_specific_host | `Error` | 2.31 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 2.23 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 1.25 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 2.32 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.24 | test_vm_deployment_planner.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1347952755
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1413266250
@blueorangutan test centos7 xcpng-82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106200192
## PR Coverage Report
|**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
|-----|-----|-----|-----|-----|-----|-----|
|VmwareResource|20483|0|2284|0|4422|0|
|CitrixResourceBase|14658|557|1456|34|3169|122|
|CitrixCheckSshCommandWrapper|52|61|7|3|12|16|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1087369621
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1087402115
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1087426074
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1088513709
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106468477
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1347955691
@weizhouapache can you reply on @GutoVeronezi ś comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1412133371
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1208515474
<b>Trillian Build Failed (tid-4657)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1207730133
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1087426226
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1208955696
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1208978097
<b>Trillian test result (tid-4658)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42346 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t4658-vmware-65u2.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 700.01 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106435486
<b>Trillian Build Failed (tid-3994)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106128608
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106406590
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1199201493
<b>Trillian Build Failed (tid-4565)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1412243667
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1413288048
@DaanHoogland
I moved this to draft. no need for 4.18.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Draft] VR: remove old json config when start vmware/xenserver VPC VRs [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1934109762
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1208960230
@blueorangutan test centos7 xenserver-71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1207776669
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1208956546
@shwstppr unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1208955894
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1347951600
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1414378710
<b>Trillian test result (tid-6082)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46071 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t6082-vmware-67u3.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1088514447
@weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1089355712
<b>Trillian test result (tid-3819)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38186 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t3819-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1088001159
<b>Trillian test result (tid-3806)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33111 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t3806-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106238858
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106469577
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1673312601
moved to 4.18.2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1537884036
@weizhouapache is this still relevant, or the issue has been addressed (or doesn't need to be addressed)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1413263576
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1087426454
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1219421219
Moving this to next milestone as this may need new systemvm template (and changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1209085471
@weizhouapache there seems to be some issue with systemvms on KVM with this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1199188837
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1200052359
<b>Trillian test result (tid-4566)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45146 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t4566-vmware-65u2.zip
Smoke tests completed. 99 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 648.24 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
URL: https://github.com/apache/cloudstack/pull/5938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106330736
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106376088
<b>Trillian Build Failed (tid-3991)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106406050
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106469014
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106508134
## PR Coverage Report
|**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
|-----|-----|-----|-----|-----|-----|-----|
||
||
||
||
||
||
||
||
||
|ConnectedAgentAttache|149|0|20|0|40|0|
||
|HostDaoImpl|4983|0|180|0|803|0|
||
||
||
||
||
||
|CloudStackContextLoaderListener|77|0|2|0|21|0|
|LibvirtComputingResource|8888|1988|1087|147|1983|451|
||
|VmwareResource|20483|0|2284|0|4422|0|
|CitrixResourceBase|14658|557|1456|34|3169|122|
|CitrixCheckSshCommandWrapper|52|61|7|3|12|16|
||
|MetricsServiceImpl|2130|0|134|0|446|0|
|ClusterMetricsResponse|523|0|132|0|60|0|
|VmMetricsResponse|142|0|22|0|25|0|
|VolumeMetricsResponse|69|0|8|0|10|0|
|ZoneMetricsResponse|501|0|126|0|56|0|
||
||
|ApiDBUtils|2374|0|210|0|592|0|
|QueryManagerImpl|14257|0|1248|0|2409|0|
|StatsCollector|2178|0|124|0|359|0|
||
||
||
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1199189528
@sureshanaparti a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
URL: https://github.com/apache/cloudstack/pull/5938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1207682604
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1207683727
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1207683470
Changed base branch to 4.17 as it was marked for 4.17.1 @weizhouapache
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1208490774
<b>Trillian Build Failed (tid-4656)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1208472562
@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on code in PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#discussion_r856531949
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -1804,9 +1804,43 @@ protected CheckSshAnswer execute(CheckSshCommand cmd) {
networkUsage(privateIp, "create", null);
}
+ if (VirtualMachineName.isValidRouterName(vmName)) {
+ reconfigureDomainRouterAfterStart(vmName);
+ }
+
return new CheckSshAnswer(cmd);
}
+ private void reconfigureDomainRouterAfterStart(String vmName) {
+ s_logger.debug("Reconfigure to remove machine.id from domain router after start. vmName: " + vmName);
+ VmwareContext context = getServiceContext();
+ try {
+ VmwareHypervisorHost hyperHost = getHyperHost(context);
+ VirtualMachineMO vmMo = hyperHost.findVmOnHyperHost(vmName);
+ if (vmMo == null) {
+ if (hyperHost instanceof HostMO) {
+ ClusterMO clusterMo = new ClusterMO(hyperHost.getContext(), ((HostMO) hyperHost).getParentMor());
+ vmMo = clusterMo.findVmOnHyperHost(vmName);
+ }
+ }
Review Comment:
```suggestion
if (vmMo == null && hyperHost instanceof HostMO) {
ClusterMO clusterMo = new ClusterMO(hyperHost.getContext(), ((HostMO) hyperHost).getParentMor());
vmMo = clusterMo.findVmOnHyperHost(vmName);
}
```
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -1804,9 +1804,43 @@ protected CheckSshAnswer execute(CheckSshCommand cmd) {
networkUsage(privateIp, "create", null);
}
+ if (VirtualMachineName.isValidRouterName(vmName)) {
+ reconfigureDomainRouterAfterStart(vmName);
+ }
+
return new CheckSshAnswer(cmd);
}
+ private void reconfigureDomainRouterAfterStart(String vmName) {
+ s_logger.debug("Reconfigure to remove machine.id from domain router after start. vmName: " + vmName);
+ VmwareContext context = getServiceContext();
+ try {
+ VmwareHypervisorHost hyperHost = getHyperHost(context);
+ VirtualMachineMO vmMo = hyperHost.findVmOnHyperHost(vmName);
+ if (vmMo == null) {
+ if (hyperHost instanceof HostMO) {
+ ClusterMO clusterMo = new ClusterMO(hyperHost.getContext(), ((HostMO) hyperHost).getParentMor());
+ vmMo = clusterMo.findVmOnHyperHost(vmName);
+ }
+ }
+ if (vmMo == null) {
+ String msg = "VM " + vmName + " no longer exists to execute UnPlugNic command";
+ s_logger.error(msg);
+ throw new Exception(msg);
+ }
+ VirtualMachineConfigSpec vmConfigSpec = new VirtualMachineConfigSpec();
+ OptionValue option = new OptionValue();
+ option.setKey("machine.id");
+ option.setValue("");
+ vmConfigSpec.getExtraConfig().add(option);
+ if (!vmMo.configureVm(vmConfigSpec)) {
+ throw new Exception("Failed to reconfigure domain router after start. vmName: " + vmName);
+ }
+ } catch (Exception e) {
+ s_logger.error("Unexpected exception when reconfigure domain router after start: ", e);
Review Comment:
We can add the name of the VM to the log and pass the exception as parameter.
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -1804,9 +1804,43 @@ protected CheckSshAnswer execute(CheckSshCommand cmd) {
networkUsage(privateIp, "create", null);
}
+ if (VirtualMachineName.isValidRouterName(vmName)) {
+ reconfigureDomainRouterAfterStart(vmName);
+ }
+
return new CheckSshAnswer(cmd);
}
+ private void reconfigureDomainRouterAfterStart(String vmName) {
+ s_logger.debug("Reconfigure to remove machine.id from domain router after start. vmName: " + vmName);
+ VmwareContext context = getServiceContext();
+ try {
+ VmwareHypervisorHost hyperHost = getHyperHost(context);
+ VirtualMachineMO vmMo = hyperHost.findVmOnHyperHost(vmName);
+ if (vmMo == null) {
+ if (hyperHost instanceof HostMO) {
+ ClusterMO clusterMo = new ClusterMO(hyperHost.getContext(), ((HostMO) hyperHost).getParentMor());
+ vmMo = clusterMo.findVmOnHyperHost(vmName);
+ }
+ }
+ if (vmMo == null) {
+ String msg = "VM " + vmName + " no longer exists to execute UnPlugNic command";
+ s_logger.error(msg);
+ throw new Exception(msg);
+ }
+ VirtualMachineConfigSpec vmConfigSpec = new VirtualMachineConfigSpec();
+ OptionValue option = new OptionValue();
+ option.setKey("machine.id");
+ option.setValue("");
+ vmConfigSpec.getExtraConfig().add(option);
+ if (!vmMo.configureVm(vmConfigSpec)) {
+ throw new Exception("Failed to reconfigure domain router after start. vmName: " + vmName);
Review Comment:
We could instantiate a more specific exception.
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -1804,9 +1804,43 @@ protected CheckSshAnswer execute(CheckSshCommand cmd) {
networkUsage(privateIp, "create", null);
}
+ if (VirtualMachineName.isValidRouterName(vmName)) {
+ reconfigureDomainRouterAfterStart(vmName);
+ }
+
return new CheckSshAnswer(cmd);
}
+ private void reconfigureDomainRouterAfterStart(String vmName) {
+ s_logger.debug("Reconfigure to remove machine.id from domain router after start. vmName: " + vmName);
+ VmwareContext context = getServiceContext();
+ try {
+ VmwareHypervisorHost hyperHost = getHyperHost(context);
+ VirtualMachineMO vmMo = hyperHost.findVmOnHyperHost(vmName);
+ if (vmMo == null) {
+ if (hyperHost instanceof HostMO) {
+ ClusterMO clusterMo = new ClusterMO(hyperHost.getContext(), ((HostMO) hyperHost).getParentMor());
+ vmMo = clusterMo.findVmOnHyperHost(vmName);
+ }
+ }
+ if (vmMo == null) {
+ String msg = "VM " + vmName + " no longer exists to execute UnPlugNic command";
+ s_logger.error(msg);
+ throw new Exception(msg);
Review Comment:
We could instantiate a more specific exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106215829
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1413401612
@blueorangutan test centos7 xcpng82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1412134793
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1348217336
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1609138521
@weizhouapache ping, any advise on this? Is this still necessary? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1089227309
<b>Trillian test result (tid-3818)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32051 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t3818-xenserver-71.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1200008781
<b>Trillian test result (tid-4564)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37951 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t4564-xenserver-71.zip
Smoke tests completed. 99 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 626.03 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1208471916
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106194628
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1106476811
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5938 (SL-JID-1440)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1198956575
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1198987169
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1413264621
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1413266538
@DaanHoogland unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1413402861
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1414912526
<b>Trillian test result (tid-6088)</b>
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 67465 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t6088-xcpng82.zip
Smoke tests completed. 103 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_list_volumes_metrics_history | `Failure` | 181.14 | test_metrics_api.py
test_01_non_strict_host_anti_affinity | `Error` | 198.60 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 115.05 | test_nonstrict_affinity_group.py
test_deploy_vm_with_registered_userdata | `Error` | 783.14 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow | `Error` | 792.49 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append | `Error` | 788.46 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params | `Error` | 815.93 | test_register_userdata.py
test_08_upgrade_kubernetes_ha_cluster | `Error` | 4127.66 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 98.91 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1348003885
> @weizhouapache can you reply on @GutoVeronezi ś comments?
@DaanHoogland
moved this to draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Draft] VR: remove old json config when start vmware/xenserver VPC VRs [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #5938:
URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1743045597
is there a way forward with this @weizhouapache ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org