You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by shaoxuan-wang <gi...@git.apache.org> on 2017/03/08 15:14:41 UTC
[GitHub] flink pull request #3496: [FLINK-5984] [table] add resetAccumulator method f...
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3496
[FLINK-5984] [table] add resetAccumulator method for AggregateFunction
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shaoxuan-wang/flink F5984-submit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3496.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3496
----
commit d60ef3e67736c6cf366a486d0c57b13874c381bd
Author: shaoxuan-wang <ws...@gmail.com>
Date: 2017-03-08T15:10:28Z
[FLINK-5984] [table] add resetAccumulator method for AggregateFunction
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3496: [FLINK-5984] [table] add resetAccumulator method for Aggr...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3496
@fhueske and @shaoxuan-wang. I will rebase and merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3496: [FLINK-5984] [table] add resetAccumulator method for Aggr...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3496
Thanks @shaoxuan-wang. The PR looks good.
FLINK-5983 has been merged and FLINK-5963 will be merged soon.
It would be great if you could rebase your code on the master once that was done.
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3496: [FLINK-5984] [table] add resetAccumulator method f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3496
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3496: [FLINK-5984] [table] add resetAccumulator method for Aggr...
Posted by shaoxuan-wang <gi...@git.apache.org>.
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3496
@fhueske , do you have plan to merge FLINK-5983 and FLINK-5963 very soon? This PR probably need rebase once your two PRs are merged, as changes are overlapped.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---