[jira] [Issue Comment Edited] (OPENNLP-494) Merging results from several name-finders

["Jim Piliouras (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246432#comment-13246432 ] 

Jim Piliouras edited comment on OPENNLP-494 at 4/4/12 4:29 PM:
---------------------------------------------------------------

Ok what if we make a "super evaluator" rather than a "super name-finder"? Then the code will be contained in a separate class...I still think the namefind package is the wrong place for something related only to evaluation...

In any case i will try it out tomorrow. Then you guys can review both approaches and decide accordingly...

                
      was (Author: jim-85):
    Ok what if we make a "super evaluator" rather than a "super name-finder"? Then the code will be contained in a separate class...I still think the namefind package is the wrong place for something related only to evaluation...

In any case i will try it out tomorrow. Then you guys can review both approaches and decide accordingly...

Jim
                  
> Merging results from several name-finders
> -----------------------------------------
>
>                 Key: OPENNLP-494
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-494
>             Project: OpenNLP
>          Issue Type: New Feature
>          Components: Name Finder
>    Affects Versions: tools-1.5.3
>         Environment: Ubuntu oneiric x64 Java 7 update 3
>            Reporter: Jim Piliouras
>              Labels: patch
>             Fix For: tools-1.5.3
>
>         Attachments: TokenNameFinderEvaluator.java
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Made some small changes to the TokenNameFinderEvaluator class which hopefully allow merging of results from several name-finders. It just does that by calling the find method of all supplied name-finders. The only break is the fact that Java does not allow varargs anywhere but at the end of the argument list so i could not use "TokenNameFinder... namefinders" as the first parameter in the constructor - i had to pass an array instead. I think it's worth reversing the order of arguments  but that is a break too...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira