[GitHub] [flink] fsk119 commented on a diff in pull request #19741: [FLINK-27794][connector/jdbc] The primary key obtained from MySQL is incorrect by using MysqlCatalog

[GitBox <gi...@apache.org>]

fsk119 commented on code in PR #19741:
URL: https://github.com/apache/flink/pull/19741#discussion_r890139979


##########
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java:
##########
@@ -42,15 +42,16 @@ public class JdbcCatalog extends AbstractJdbcCatalog {
 
     public JdbcCatalog(
             String catalogName,
+            String dbCatalog,

Review Comment:
   We should infer the catalog from the input table path.



##########
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/AbstractJdbcCatalog.java:
##########
@@ -516,4 +519,8 @@ protected String getSchemaName(ObjectPath tablePath) {
     protected String getSchemaTableName(ObjectPath tablePath) {
         throw new UnsupportedOperationException();
     }
+
+    protected String getDbCatalog() {

Review Comment:
   It should be like getSchemaName(ObjectPath tablePath)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org