You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2017/12/18 01:08:46 UTC

[GitHub] jiazhai commented on a change in pull request #868: ISSUE #863: BK client error messages need to be more descriptive

jiazhai commented on a change in pull request #868: ISSUE #863: BK client error messages need to be more descriptive
URL: https://github.com/apache/bookkeeper/pull/868#discussion_r157387091
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/BKException.java
 ##########
 @@ -240,4 +255,60 @@ public static String getMessage(int code) {
         int UnexpectedConditionException = -999;
     }
 
+    /**
+     * Code log message pool.
+     */
+    private static class LogMessagePool {
+        private static final int lastKnown = 200;
 
 Review comment:
   Currently it seems OK. It would be better to have this connected with size of Code above, and not hard coded.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services