You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2019/05/15 12:49:08 UTC
Review Request 70649: RANGER-2429: Ranger KMS is not starting properly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70649/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2429
https://issues.apache.org/jira/browse/RANGER-2429
Repository: ranger
Description
-------
Ranger KMS start is failing with java.lang.NoClassDefFoundError as zookeeper, common-codec jar is not available.
Diffs
-----
agents-common/pom.xml 27be45f9d
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSslHelper.java 5fc3358c6
kms/pom.xml 856eebd91
pom.xml c0a480c65
Diff: https://reviews.apache.org/r/70649/diff/1/
Testing
-------
Build Ranger with proposed changes and can see required jars in ranger-kms module.
After installation java.lang.NoClassDefFoundError is not coming and ranger-kms is loading properly.
Thanks,
Pradeep Agrawal
Re: Review Request 70649: RANGER-2429: Ranger KMS is not starting
properly
Posted by Pradeep Agrawal <pr...@gmail.com>.
> On May 15, 2019, 6:17 p.m., Abhay Kulkarni wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSslHelper.java
> > Line 49 (original), 49 (patched)
> > <https://reviews.apache.org/r/70649/diff/1/?file=2145420#file2145420line49>
> >
> > If MoreObjects package is included only for printing debug messages, please consider removing this dependency altogether.
I have create RANGER-2434 to consider removing dependecy of MoreObjects class. Please review other dependent classes mentioned there and add the suggestions(if any)
- Pradeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70649/#review215282
-----------------------------------------------------------
On May 15, 2019, 12:49 p.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70649/
> -----------------------------------------------------------
>
> (Updated May 15, 2019, 12:49 p.m.)
>
>
> Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2429
> https://issues.apache.org/jira/browse/RANGER-2429
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger KMS start is failing with java.lang.NoClassDefFoundError as zookeeper, common-codec jar is not available.
>
>
> Diffs
> -----
>
> kms/pom.xml 856eebd91
> pom.xml c0a480c65
>
>
> Diff: https://reviews.apache.org/r/70649/diff/2/
>
>
> Testing
> -------
>
> Build Ranger with proposed changes and can see required jars in ranger-kms module.
> After installation java.lang.NoClassDefFoundError is not coming and ranger-kms is loading properly.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>
Re: Review Request 70649: RANGER-2429: Ranger KMS is not starting
properly
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70649/#review215282
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSslHelper.java
Line 49 (original), 49 (patched)
<https://reviews.apache.org/r/70649/#comment301943>
If MoreObjects package is included only for printing debug messages, please consider removing this dependency altogether.
- Abhay Kulkarni
On May 15, 2019, 12:49 p.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70649/
> -----------------------------------------------------------
>
> (Updated May 15, 2019, 12:49 p.m.)
>
>
> Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2429
> https://issues.apache.org/jira/browse/RANGER-2429
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger KMS start is failing with java.lang.NoClassDefFoundError as zookeeper, common-codec jar is not available.
>
>
> Diffs
> -----
>
> agents-common/pom.xml 27be45f9d
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSslHelper.java 5fc3358c6
> kms/pom.xml 856eebd91
> pom.xml c0a480c65
>
>
> Diff: https://reviews.apache.org/r/70649/diff/1/
>
>
> Testing
> -------
>
> Build Ranger with proposed changes and can see required jars in ranger-kms module.
> After installation java.lang.NoClassDefFoundError is not coming and ranger-kms is loading properly.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>
Re: Review Request 70649: RANGER-2429: Ranger KMS is not starting
properly
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70649/#review215312
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On May 15, 2019, 12:49 p.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70649/
> -----------------------------------------------------------
>
> (Updated May 15, 2019, 12:49 p.m.)
>
>
> Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2429
> https://issues.apache.org/jira/browse/RANGER-2429
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger KMS start is failing with java.lang.NoClassDefFoundError as zookeeper, common-codec jar is not available.
>
>
> Diffs
> -----
>
> kms/pom.xml 856eebd91
> pom.xml c0a480c65
>
>
> Diff: https://reviews.apache.org/r/70649/diff/2/
>
>
> Testing
> -------
>
> Build Ranger with proposed changes and can see required jars in ranger-kms module.
> After installation java.lang.NoClassDefFoundError is not coming and ranger-kms is loading properly.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>