You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2005/04/10 21:24:30 UTC

Issue 1361: "svn cat file -r BASE contacts repository"

Well done for fixing this long-standing issue, John.  A little bug:

svn cat unversioned-or-nonexistent-file
Segmentation fault.

- Julian

-- 
http://www.foad.me.uk/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Issue 1361: "svn cat file -r BASE contacts repository"

Posted by John Szakmeister <jo...@szakmeister.net>.
On Sunday 10 April 2005 17:24, Julian Foad wrote:
> Well done for fixing this long-standing issue, John.  A little bug:
>
> svn cat unversioned-or-nonexistent-file
> Segmentation fault.

I'm on it.  I swore I tested that case...

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Issue 1361: "svn cat file -r BASE contacts repository"

Posted by John Szakmeister <jo...@szakmeister.net>.
Erik Huelsmann wrote:
>>On Sunday 10 April 2005 17:24, Julian Foad wrote:
>>
>>>Well done for fixing this long-standing issue, John.  A little bug:
>>>
>>>svn cat unversioned-or-nonexistent-file
>>>Segmentation fault.
>>
>>I apparently missed the check for a NULL wc entry in my original diff (it 
>>was pretty old and didn't apply cleanly).  This is fixed in r14098.  I 
>>also added a few more cat tests so that it doesn't slip by again.
> 
> 
> I'm not behind a machine with commit access at the moment, but it you want
> to add my +1 to r14098, then go ahead! (Yes, I did review the change.)
> 
> If you don't do it, I will probably get around to it somewhere this week.

I'll take care of it later tonight when I get back in front of my 
working copy at home.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Issue 1361: "svn cat file -r BASE contacts repository"

Posted by Erik Huelsmann <e....@gmx.net>.
> On Sunday 10 April 2005 17:24, Julian Foad wrote:
> > Well done for fixing this long-standing issue, John.  A little bug:
> >
> > svn cat unversioned-or-nonexistent-file
> > Segmentation fault.
> 
> I apparently missed the check for a NULL wc entry in my original diff (it 
> was pretty old and didn't apply cleanly).  This is fixed in r14098.  I 
> also added a few more cat tests so that it doesn't slip by again.

I'm not behind a machine with commit access at the moment, but it you want
to add my +1 to r14098, then go ahead! (Yes, I did review the change.)

If you don't do it, I will probably get around to it somewhere this week.


bye,

Erik.

-- 
Handyrechnung zu hoch? Tipp: SMS und MMS mit GMX
Seien Sie so frei: Alle Infos unter http://www.gmx.net/de/go/freesms

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Issue 1361: "svn cat file -r BASE contacts repository"

Posted by John Szakmeister <jo...@szakmeister.net>.
On Sunday 10 April 2005 17:24, Julian Foad wrote:
> Well done for fixing this long-standing issue, John.  A little bug:
>
> svn cat unversioned-or-nonexistent-file
> Segmentation fault.

I apparently missed the check for a NULL wc entry in my original diff (it 
was pretty old and didn't apply cleanly).  This is fixed in r14098.  I 
also added a few more cat tests so that it doesn't slip by again.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org