You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/02/13 08:38:24 UTC

Review Request 30970: Added JNI construct for booleans.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30970/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Repository: mesos


Description
-------

This makes booleans consistent with other construction from java types.


Diffs
-----

  src/java/jni/construct.hpp a1907a14c5174c8c47e5512dc009c372eb62df75 
  src/java/jni/construct.cpp 0d0207fab6481c7e86d9b59c9e6a1aea1979cf6d 

Diff: https://reviews.apache.org/r/30970/diff/


Testing
-------

This was tested through my API changes.


Thanks,

Ben Mahler

Re: Review Request 30970: Added JNI construct for booleans.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30970/#review72777
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Feb. 17, 2015, 6 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30970/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 6 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This makes booleans consistent with other construction from java types.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/construct.hpp a1907a14c5174c8c47e5512dc009c372eb62df75 
>   src/java/jni/construct.cpp 0d0207fab6481c7e86d9b59c9e6a1aea1979cf6d 
> 
> Diff: https://reviews.apache.org/r/30970/diff/
> 
> 
> Testing
> -------
> 
> This was tested through my API changes.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 30970: Added JNI construct for booleans.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30970/
-----------------------------------------------------------

(Updated Feb. 17, 2015, 6 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Removed dependency now that we're no longer changing the `statusUpdate` signature in the Java API.


Repository: mesos


Description
-------

This makes booleans consistent with other construction from java types.


Diffs (updated)
-----

  src/java/jni/construct.hpp a1907a14c5174c8c47e5512dc009c372eb62df75 
  src/java/jni/construct.cpp 0d0207fab6481c7e86d9b59c9e6a1aea1979cf6d 

Diff: https://reviews.apache.org/r/30970/diff/


Testing
-------

This was tested through my API changes.


Thanks,

Ben Mahler