You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2005/07/09 22:02:53 UTC
cvs commit: jakarta-tapestry/framework/src/java/org/apache/tapestry/form/validator MaxLength.java MinLength.java
hlship 2005/07/09 13:02:53
Modified: . status.xml project.properties
framework/src/test/org/apache/tapestry/form/validator
TestMaxLength.java TestMinLength.java
framework/src/java/org/apache/tapestry/form/validator
MaxLength.java MinLength.java
Log:
TAPESTRY-384: Client Side Validation inconsistent
Revision Changes Path
1.159 +1 -0 jakarta-tapestry/status.xml
Index: status.xml
===================================================================
RCS file: /home/cvs/jakarta-tapestry/status.xml,v
retrieving revision 1.158
retrieving revision 1.159
diff -u -r1.158 -r1.159
--- status.xml 9 Jul 2005 16:40:31 -0000 1.158
+++ status.xml 9 Jul 2005 20:02:52 -0000 1.159
@@ -66,6 +66,7 @@
<action type="fix" dev="HLS" fixes-bug="TAPESTRY-374" due-to="Paul Green">Script component is not picking up the symbols parameter</action>
<action type="add" dev="HLS">Add blank component reference pages for If and For</action>
<action type="fix" dev="HLS" fixes-bug="TAPESTRY-391">Cannot inject the same bean twice</action>
+ <action type="fix" dev="HLS" fixes-bug="TAPESTRY-384">Client Side Validation inconsistent</action>
</release>
<release version="4.0-beta-1" date="Jun 24 2005">
<action type="add" dev="HLS">Add InvokeListener component.</action>
1.11 +2 -2 jakarta-tapestry/project.properties
Index: project.properties
===================================================================
RCS file: /home/cvs/jakarta-tapestry/project.properties,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- project.properties 1 Jul 2005 13:58:36 -0000 1.10
+++ project.properties 9 Jul 2005 20:02:52 -0000 1.11
@@ -12,8 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-project.name=tapestry
-project.version=4.0-beta-2-snapshot
+project.name=jakarta-tapestry
+project.version=4.0-beta-2
dist.name=tapestry
1.2 +2 -0 jakarta-tapestry/framework/src/test/org/apache/tapestry/form/validator/TestMaxLength.java
Index: TestMaxLength.java
===================================================================
RCS file: /home/cvs/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/validator/TestMaxLength.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- TestMaxLength.java 18 Jun 2005 19:56:26 -0000 1.1
+++ TestMaxLength.java 9 Jul 2005 20:02:52 -0000 1.2
@@ -100,6 +100,8 @@
FormComponentContributorContext context = (FormComponentContributorContext) contextc
.getMock();
+ context.includeClasspathScript("/org/apache/tapestry/form/validator/StringValidator.js");
+
context.getFieldDOM();
contextc.setReturnValue("document.myform.myfield");
1.2 +5 -4 jakarta-tapestry/framework/src/test/org/apache/tapestry/form/validator/TestMinLength.java
Index: TestMinLength.java
===================================================================
RCS file: /home/cvs/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/validator/TestMinLength.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- TestMinLength.java 18 Jun 2005 18:13:19 -0000 1.1
+++ TestMinLength.java 9 Jul 2005 20:02:52 -0000 1.2
@@ -83,10 +83,7 @@
try
{
- new MinLength("minLength=10,message=Too Short").validate(
- field,
- messages,
- "short");
+ new MinLength("minLength=10,message=Too Short").validate(field, messages, "short");
}
catch (ValidatorException ex)
{
@@ -104,6 +101,8 @@
FormComponentContributorContext context = (FormComponentContributorContext) contextc
.getMock();
+ context.includeClasspathScript("/org/apache/tapestry/form/validator/StringValidator.js");
+
context.getFieldDOM();
contextc.setReturnValue("document.myform.myfield");
@@ -129,6 +128,8 @@
FormComponentContributorContext context = (FormComponentContributorContext) contextc
.getMock();
+ context.includeClasspathScript("/org/apache/tapestry/form/validator/StringValidator.js");
+
context.getFieldDOM();
contextc.setReturnValue("document.myform.myfield");
1.3 +2 -0 jakarta-tapestry/framework/src/java/org/apache/tapestry/form/validator/MaxLength.java
Index: MaxLength.java
===================================================================
RCS file: /home/cvs/jakarta-tapestry/framework/src/java/org/apache/tapestry/form/validator/MaxLength.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- MaxLength.java 20 Jun 2005 20:20:08 -0000 1.2
+++ MaxLength.java 9 Jul 2005 20:02:53 -0000 1.3
@@ -70,6 +70,8 @@
public void renderContribution(IMarkupWriter writer, IRequestCycle cycle,
FormComponentContributorContext context, IFormComponent field)
{
+ context.includeClasspathScript("/org/apache/tapestry/form/validator/StringValidator.js");
+
StringBuffer buffer = new StringBuffer("function(event) { validate_max_length(event, ");
buffer.append(context.getFieldDOM());
buffer.append(", ");
1.3 +2 -0 jakarta-tapestry/framework/src/java/org/apache/tapestry/form/validator/MinLength.java
Index: MinLength.java
===================================================================
RCS file: /home/cvs/jakarta-tapestry/framework/src/java/org/apache/tapestry/form/validator/MinLength.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- MinLength.java 20 Jun 2005 20:20:08 -0000 1.2
+++ MinLength.java 9 Jul 2005 20:02:53 -0000 1.3
@@ -74,6 +74,8 @@
public void renderContribution(IMarkupWriter writer, IRequestCycle cycle,
FormComponentContributorContext context, IFormComponent field)
{
+ context.includeClasspathScript("/org/apache/tapestry/form/validator/StringValidator.js");
+
StringBuffer buffer = new StringBuffer("function(event) { validate_min_length(event, ");
buffer.append(context.getFieldDOM());
buffer.append(", ");
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org