You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/06/20 12:29:08 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4954: fix lettuce plugin sometimes trace doesn‘t show span layer

wu-sheng commented on a change in pull request #4954:
URL: https://github.com/apache/skywalking/pull/4954#discussion_r443127353



##########
File path: apm-sniffer/apm-sdk-plugin/lettuce-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/lettuce/v5/AsyncCommandMethodInterceptor.java
##########
@@ -40,6 +42,8 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
         String operationName = "Lettuce/" + asyncCommand.getType().name();
         AbstractSpan span = ContextManager.createLocalSpan(operationName + "/onComplete");
         span.setComponent(ComponentsDefine.LETTUCE);
+        Tags.DB_TYPE.set(span, "Redis");

Review comment:
       I think you should create `Tags#CACHE_TYPE`. Redis is not DB from my understanding.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org