You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "sobomax (via GitHub)" <gi...@apache.org> on 2023/03/02 18:02:08 UTC
[GitHub] [thrift] sobomax opened a new pull request, #2764: Add NewTServerSocketUnix() and NewTServerSocketTimeoutUnix()
sobomax opened a new pull request, #2764:
URL: https://github.com/apache/thrift/pull/2764
<!-- Explain the changes in the pull request below: -->
The change adds ability to create servers that are listening on local unix domain sockets. We cannot implement it via existing API since necessary members of the TServerSocket() struct are not public (addr & clientTimeout).
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ x ] Did you squash your changes to a single commit? (not required, but preferred)
- [ x ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on pull request #2764: Add NewTServerSocketUnix() and NewTServerSocketTimeoutUnix()
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy commented on PR #2764:
URL: https://github.com/apache/thrift/pull/2764#issuecomment-1452330482
Doesn't [`thrift.NewTServerSocketFromAddrTimeout`](https://pkg.go.dev/github.com/apache/thrift/lib/go/thrift#NewTServerSocketFromAddrTimeout) work for unix domain sockets? you just create a `net.Addr` from [`net.ResolveUnixAddr`](https://pkg.go.dev/net#ResolveUnixAddr) to be passed in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] sobomax closed pull request #2764: Add NewTServerSocketUnix() and NewTServerSocketTimeoutUnix()
Posted by "sobomax (via GitHub)" <gi...@apache.org>.
sobomax closed pull request #2764: Add NewTServerSocketUnix() and NewTServerSocketTimeoutUnix()
URL: https://github.com/apache/thrift/pull/2764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] sobomax commented on pull request #2764: Add NewTServerSocketUnix() and NewTServerSocketTimeoutUnix()
Posted by "sobomax (via GitHub)" <gi...@apache.org>.
sobomax commented on PR #2764:
URL: https://github.com/apache/thrift/pull/2764#issuecomment-1452719880
> Doesn't [`thrift.NewTServerSocketFromAddrTimeout`](https://pkg.go.dev/github.com/apache/thrift/lib/go/thrift#NewTServerSocketFromAddrTimeout) work for unix domain sockets? you just create a `net.Addr` from [`net.ResolveUnixAddr`](https://pkg.go.dev/net#ResolveUnixAddr) to be passed in?
@fishy you are absolutely right! somehow I've overlooked it, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org