You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "jerqi (via GitHub)" <gi...@apache.org> on 2023/03/03 08:06:04 UTC

[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #677: [#675] fix: check disk enough avoid No Enough exception in checkStorageReadAndWrite

jerqi commented on code in PR #677:
URL: https://github.com/apache/incubator-uniffle/pull/677#discussion_r1124133176


##########
server/src/main/java/org/apache/uniffle/server/LocalStorageChecker.java:
##########
@@ -200,6 +202,9 @@ boolean checkStorageReadAndWrite() {
         }
       } catch (Exception e) {
         LOG.error("Storage read and write error. Storage dir: {}", storageDir, e);
+        if(e.getMessage()!= null && DEVICE_NO_SPACE_ERROR_MESSAGE.equals(e.getMessage())){

Review Comment:
   Could you add some comments to explain why we do so?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org