You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/12/20 00:51:46 UTC
Review Request 64738: Pulled out `upgradeResources` out of
`validateAndNormalizeResources`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64738/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/common/resources_utils.cpp 1676b72a9ad15bf8b131698a0600a1b0937c00b4
Diff: https://reviews.apache.org/r/64738/diff/1/
Testing
-------
Thanks,
Michael Park
Re: Review Request 64738: Pulled out `upgradeResources` out of
`validateAndNormalizeResources`.
Posted by Michael Park <mp...@apache.org>.
> On Dec. 19, 2017, 6:13 p.m., Benjamin Mahler wrote:
> > The "upgrade" vs "normalize" inconsistency seems a little odd?
I'll follow up with a patch to change "normalize" to "upgrade".
Seems more fitting with the presence of "downgrade".
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64738/#review194205
-----------------------------------------------------------
On Dec. 19, 2017, 4:51 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64738/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2017, 4:51 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources_utils.cpp 1676b72a9ad15bf8b131698a0600a1b0937c00b4
>
>
> Diff: https://reviews.apache.org/r/64738/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 64738: Pulled out `upgradeResources` out of
`validateAndNormalizeResources`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64738/#review194205
-----------------------------------------------------------
Ship it!
The "upgrade" vs "normalize" inconsistency seems a little odd?
- Benjamin Mahler
On Dec. 20, 2017, 12:51 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64738/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 12:51 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/resources_utils.cpp 1676b72a9ad15bf8b131698a0600a1b0937c00b4
>
>
> Diff: https://reviews.apache.org/r/64738/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>