You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by Allen Gilliland <Al...@Sun.COM> on 2005/12/07 18:21:55 UTC

Re: svn commit: r354245 - /incubator/roller/trunk/src/org/roller/presentation/velocity/FlavorServlet.java

yeah, to be honest I didn't think it was going to fix the problem because we were actaully already doing the right things before.  we need to keep gathering info though.

sorry about the SearchServlet thing.  i realized yesterday on my flight home that I had missed that one during my commit :/

-- Allen


On Tue, 2005-12-06 at 20:21, Dave Johnson wrote:
> I've been running my blog with this code for a day. Unfortunately, I  
> just encountered the blank blog page error again. So, I guess this  
> change didn't solve the problem as we had hoped.
> 
> I'll work on diagnosing the problem tomorrow -- perhaps by changing the  
> cache so that it logs the URL of all cache entries smaller than some  
> threshold (maybe 50 bytes).
> 
> - Dave
> 
> 
> 
> On Dec 5, 2005, at 7:43 PM, agilliland@apache.org wrote:
> 
> > Author: agilliland
> > Date: Mon Dec  5 16:43:23 2005
> > New Revision: 354245
> >
> > URL: http://svn.apache.org/viewcvs?rev=354245&view=rev
> > Log:
> > make sure "DisplayException" request attribute is set when there is a  
> > problem constructing the RollerRequest.
> >
> >
> > Modified:
> >      
> > incubator/roller/trunk/src/org/roller/presentation/velocity/ 
> > FlavorServlet.java
> >
> > Modified:  
> > incubator/roller/trunk/src/org/roller/presentation/velocity/ 
> > FlavorServlet.java
> > URL:  
> > http://svn.apache.org/viewcvs/incubator/roller/trunk/src/org/roller/
> > presentation/velocity/FlavorServlet.java? 
> > rev=354245&r1=354244&r2=354245&view=diff
> > ======================================================================= 
> > =======
> > ---  
> > incubator/roller/trunk/src/org/roller/presentation/velocity/ 
> > FlavorServlet.java (original)
> > +++  
> > incubator/roller/trunk/src/org/roller/presentation/velocity/ 
> > FlavorServlet.java Mon Dec  5 16:43:23 2005
> > @@ -69,16 +69,9 @@
> >              }
> >          } catch (RollerException e) {
> >              // An error initializing the request is considered to be  
> > a 404
> > -            if (mLogger.isDebugEnabled()) {
> > -                mLogger.debug("RollerRequest threw Exception", e);
> > -            }
> > -            try {
> > -                response.sendError(HttpServletResponse.SC_NOT_FOUND);
> > -            } catch (IOException e1) {
> > -                if (mLogger.isDebugEnabled()) {
> > -                    mLogger.debug("IOException sending error", e);
> > -                }
> > -            }
> > +            response.setStatus(HttpServletResponse.SC_NOT_FOUND);
> > +            request.setAttribute("DisplayException", e);
> > +
> >              return null;
> >          }
> >
> >
>