You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/07 05:51:26 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request #13161: [Java Client] Send CloseProducer on timeout
michaeljmarshall opened a new pull request #13161:
URL: https://github.com/apache/pulsar/pull/13161
### Motivation
When producer creation times out, send the `CloseProducer` before sending a command to recreate the `Producer`. This ensures a better time to recovery.
This issue was discussed on the mailing list here, https://lists.apache.org/thread/tko0z4jg0oq0yf931rbow2zf9fq8wjt1. The protocol spec has already been updated to indicate that this is the correct client behavior https://github.com/apache/pulsar/pull/12948.
### Modifications
* Update the java client to send `CloseProducer` when the producer creation times out.
* Add tests.
* Clean up some comments and unnecessary calls to `close()` in the modified test file.
### Verifying this change
I added tests to verify this change.
### Does this pull request potentially affect one of the following parts:
There are no breaking changes. This is an improvement to the protocol. The previous implementation was valid, but not ideal.
### Documentation
- [x] `no-need-doc`
Docs were added here: https://github.com/apache/pulsar/pull/12948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #13161: [Java Client] Send CloseProducer on timeout
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #13161:
URL: https://github.com/apache/pulsar/pull/13161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #13161: [Java Client] Send CloseProducer on timeout
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #13161:
URL: https://github.com/apache/pulsar/pull/13161#issuecomment-988034090
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #13161: [Java Client] Send CloseProducer on timeout
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #13161:
URL: https://github.com/apache/pulsar/pull/13161#issuecomment-988005416
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #13161: [Java Client] Send CloseProducer on timeout
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #13161:
URL: https://github.com/apache/pulsar/pull/13161#issuecomment-988108639
Closing and reopening to get the fix to the `BrokerServiceLookupTest`, a flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #13161: [Java Client] Send CloseProducer on timeout
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #13161:
URL: https://github.com/apache/pulsar/pull/13161#issuecomment-988243259
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall closed pull request #13161: [Java Client] Send CloseProducer on timeout
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #13161:
URL: https://github.com/apache/pulsar/pull/13161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #13161: [Java Client] Send CloseProducer on timeout
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #13161:
URL: https://github.com/apache/pulsar/pull/13161#issuecomment-988068360
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org