You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "seekskyworld (via GitHub)" <gi...@apache.org> on 2026/09/15 16:09:01 UTC
[PR] fix(core): preserve calendar anchors after DST gaps [maka]
seekskyworld opened a new pull request, #5354:
URL: https://github.com/apache/maka/pull/5354
## Summary
Daily and weekly calendar schedules now build each occurrence from its intended date and the original anchor's clock time. Evaluating a 02:30 schedule on the spring DST transition day no longer moves the following Monday or Sunday to 03:30. Occurrences that actually fall inside a gap retain the existing Date normalization; the fall-back fold policy is unchanged.
Fixes #5353
## Verification
- Core build, typecheck and all 844 Core tests passed.
- Regression test fails on the previous implementation (next daily/weekly occurrences are one hour late). Covers New York's one-hour gap, Lord Howe's half-hour gap, a weekly target on another weekday, seconds/milliseconds, and the existing fall-back behavior in isolated timezone subprocesses.
- Repository lint, format check and ASF header audit passed.
- Full application build, application suites and UI execution were not run for this Core-only branch.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: OpenAI Codex inspected the source, authored the fix and regression test, and ran the checks. Commit includes `Generated-by: OpenAI Codex`.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(core): preserve calendar anchors after DST gaps [maka]
Posted by "seekskyworld (via GitHub)" <gi...@apache.org>.
seekskyworld commented on PR #5354:
URL: https://github.com/apache/maka/pull/5354#issuecomment-6095650259
Translated the calendar DST rationale into English in ad387e3a5. This is comment-only; diff check passes. The existing timezone regression evidence remains scoped to the tested Node/macOS/Linux environments; no new Windows claim is made.
Automated update by OpenAI Codex under the contributor’s direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(core): preserve calendar anchors after DST gaps [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #5354:
URL: https://github.com/apache/maka/pull/5354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org