You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "CzyerChen (via GitHub)" <gi...@apache.org> on 2024/05/13 14:19:21 UTC
[PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]
CzyerChen opened a new pull request, #691:
URL: https://github.com/apache/skywalking-java/pull/691
### Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x
- [x] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
Since Spring 6.1.x, the intercepted method deprecated
```java
@Deprecated(
since = "6.1"
)
@Nullable
protected Runnable createRunnable(Object target, Method method) {
return null;
}
```
use the constructor method instead:
```java
public ScheduledMethodRunnable(Object target, Method method, @Nullable String qualifier, Supplier<ObservationRegistry> observationRegistrySupplier) {
this.target = target;
this.method = method;
this.qualifier = qualifier;
this.observationRegistrySupplier = observationRegistrySupplier;
}
```
----
Before adjustment:
<img width="905" alt="image" src="https://github.com/apache/skywalking-java/assets/22817918/0320c001-ed9b-4d84-ab75-a7bed6e2db22">
the method name missing wiith Spring 6.1.x
Now:
<img width="1121" alt="image" src="https://github.com/apache/skywalking-java/assets/22817918/a518a6dd-d1e8-4136-a771-534ce61343ff">
Meanwhile, optimize test cases of `spring-scheduled`.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #691:
URL: https://github.com/apache/skywalking-java/pull/691#issuecomment-2109895082
I can see RocketMQ fails again. From what I see, 50% chance fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #691:
URL: https://github.com/apache/skywalking-java/pull/691#issuecomment-2109656114
Are we sending too frequently? The test GHA env is only 3u8g for all runtime. It could be super slow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #691:
URL: https://github.com/apache/skywalking-java/pull/691#issuecomment-2108028821
I can see RocketMQ case fails again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]
Posted by "CzyerChen (via GitHub)" <gi...@apache.org>.
CzyerChen commented on PR #691:
URL: https://github.com/apache/skywalking-java/pull/691#issuecomment-2109206083
> I can see RocketMQ case fails again.
OK，I will check RocketMQ case first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #691:
URL: https://github.com/apache/skywalking-java/pull/691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #691:
URL: https://github.com/apache/skywalking-java/pull/691#discussion_r1598620639
##########
CHANGES.md:
##########
@@ -11,6 +11,7 @@ Release Notes.
* Use a daemon thread to flush logs.
* Fix typos in `URLParser`.
* Add support for `Derby`/`Sybase`/`SQLite`/`DB2`/`OceanBase` jdbc url format in `URLParser`.
+* Optimize spring-plugins:scheduled-annotation-plugin compatibility.
Review Comment:
```suggestion
* Optimize spring-plugins:scheduled-annotation-plugin compatibility about Spring 6.1.x support.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]
Posted by "CzyerChen (via GitHub)" <gi...@apache.org>.
CzyerChen commented on PR #691:
URL: https://github.com/apache/skywalking-java/pull/691#issuecomment-2109653475
> I can see RocketMQ case fails again.
The problem is not reproduced locally, and the sending and receiving of async messages are enhanced.
Please do inform me when the recurrence of the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]
Posted by "CzyerChen (via GitHub)" <gi...@apache.org>.
CzyerChen commented on PR #691:
URL: https://github.com/apache/skywalking-java/pull/691#issuecomment-2109729418
> Are we sending too frequently? The test GHA env is only 3u8g for all runtime. It could be super slow.
May have an impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org