You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/11/20 06:32:59 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request #4932: [Bug] Fix the bug of NULL do not show in CTE statement.
HappenLee opened a new pull request #4932:
URL: https://github.com/apache/incubator-doris/pull/4932
issue:#4926
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on pull request #4932: [Bug] Fix the bug of NULL do not show in CTE statement.
Posted by GitBox <gi...@apache.org>.
HappenLee commented on pull request #4932:
URL: https://github.com/apache/incubator-doris/pull/4932#issuecomment-731049057
> Please add more commit log
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4932: [Bug] Fix the bug of NULL do not show in CTE statement.
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4932:
URL: https://github.com/apache/incubator-doris/pull/4932
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #4932: [Bug] Fix the bug of NULL do not show in CTE statement.
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #4932:
URL: https://github.com/apache/incubator-doris/pull/4932#discussion_r527514868
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/InlineViewRef.java
##########
@@ -266,7 +266,9 @@ public TupleDescriptor createTupleDescriptor(Analyzer analyzer) throws AnalysisE
}
columnSet.add(colAlias);
- columnList.add(new Column(colAlias, selectItemExpr.getType().getPrimitiveType()));
+ // TODO: inlineView threat all column is nullable to make sure query results are correct
+ // we should judge column whether is nullable by selectItemExpr in the future
+ columnList.add(new Column(colAlias, selectItemExpr.getType().getPrimitiveType(), true));
Review comment:
Unfortunately, we cannot directly obtain the information about whether slot desc is nullable or not from Expr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #4932: [Bug] Fix the bug of NULL do not show in CTE statement.
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #4932:
URL: https://github.com/apache/incubator-doris/pull/4932#issuecomment-731018393
Please add more commit log
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org