[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #183: [build][site] cleanup previous content before copy new ones

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #183:
URL: https://github.com/apache/pulsar-site/pull/183#discussion_r956845707


##########
site2/tools/publish-website.sh:
##########
@@ -52,11 +51,7 @@ PULSAR_SITE_TMP=/tmp/pulsar-site
     mkdir -p $PULSAR_SITE_TMP/content/
   fi
 
-  echo "BUILD_ALL:"$BUILD_ALL
-  if [[ $BUILD_ALL"" == "11" ]]; then
-    echo "clean all the old random js files because a new all version build done, all the js is regenerated with a random name"
-    rm -rf $PULSAR_SITE_TMP/content/assets/js
-  fi
+  rm -rf $PULSAR_SITE_TMP/content/*

Review Comment:
   It seems a full build takes 40 minutes to complete, while we normally build every six hours. Do we really need this improvement?
   
   The current issue is that if we don't remove content, we can have dangling pages even if it's removed on the master branch.
   
   But yes, we can retain the current logic while removing all content when build all :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org