You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wayang.apache.org by "kmoltke (via GitHub)" <gi...@apache.org> on 2023/04/28 09:52:49 UTC

[GitHub] [incubator-wayang] kmoltke opened a new pull request, #309: Bugfix on WayangJoinVisitor

kmoltke opened a new pull request, #309:
URL: https://github.com/apache/incubator-wayang/pull/309

   Michelle and I fixed a small bug on WayangJoinVisitor related to the UnsupportedOperationException which was not thrown before.
   
   The rest of the contribution consists of documentation comments and minor clean ups.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-wayang] zkaoudi merged pull request #309: Bugfix on WayangJoinVisitor

Posted by "zkaoudi (via GitHub)" <gi...@apache.org>.
zkaoudi merged PR #309:
URL: https://github.com/apache/incubator-wayang/pull/309


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-wayang] kmoltke commented on pull request #309: Bugfix on WayangJoinVisitor

Posted by "kmoltke (via GitHub)" <gi...@apache.org>.
kmoltke commented on PR #309:
URL: https://github.com/apache/incubator-wayang/pull/309#issuecomment-1527404968

   Hi Zoi,
   Yes, of course. It is a quick fix we can do right away. It builds on our machines after we update the maven project however.
   But how do I fix it most elegantly in terms of this PR? Do I close the PR and open a new one or what is the right approach? :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-wayang] kmoltke commented on pull request #309: Bugfix on WayangJoinVisitor

Posted by "kmoltke (via GitHub)" <gi...@apache.org>.
kmoltke commented on PR #309:
URL: https://github.com/apache/incubator-wayang/pull/309#issuecomment-1527414558

   We found out - it updated the PR automatically :-) It should be fixed with the newly added commit.
   I believe it was related to the SDK 11 vs SDK 20. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org